spec\BitBag\SyliusQuadPayPlugin\PaymentProcessing\RefundPaymentProcessorSpec

Complexity

Total Complexity

4

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	it_implements_payment_processor_interface()	0	3	1
A	it_is_initializable()	0	3	1
A	it_processes()	0	34	1
A	let()	0	3	1

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on mikolaj.krol@bitbag.pl.
 */

declare(strict_types=1);

namespace spec\BitBag\SyliusQuadPayPlugin\PaymentProcessing;

use BitBag\SyliusQuadPayPlugin\Client\QuadPayApiClientInterface;
use BitBag\SyliusQuadPayPlugin\PaymentProcessing\PaymentProcessorInterface;
use BitBag\SyliusQuadPayPlugin\PaymentProcessing\RefundPaymentProcessor;
use BitBag\SyliusQuadPayPlugin\QuadPayGatewayFactory;
use Payum\Core\Model\GatewayConfigInterface;
use PhpSpec\ObjectBehavior;
use Prophecy\Argument;
use Sylius\Component\Core\Model\PaymentInterface;
use Sylius\Component\Core\Model\PaymentMethodInterface;
use Symfony\Component\HttpFoundation\Session\Session;

final class RefundPaymentProcessorSpec extends ObjectBehavior
{
    function let(Session $session, QuadPayApiClientInterface $quadPayApiClient): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->beConstructedWith($session, $quadPayApiClient);
    }

    function it_is_initializable(): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(RefundPaymentProcessor::class);
    }

    function it_implements_payment_processor_interface(): void
    {
        $this->shouldHaveType(PaymentProcessorInterface::class);
    }

    function it_processes(
        PaymentInterface $payment,
        PaymentMethodInterface $paymentMethod,
        GatewayConfigInterface $gatewayConfig,
        QuadPayApiClientInterface $quadPayApiClient
    ): void {
        $gatewayConfig->getFactoryName()->willReturn(QuadPayGatewayFactory::FACTORY_NAME);

The function Payum\Core\Model\GatewayConfigInterface::getFactoryName() has been deprecated: since 1.3.3 will be removed in 2.0. set factory option inside the config

        $gatewayConfig->getConfig()->willReturn([
            'clientId' => 'test',
            'clientSecret' => 'test',
            'apiEndpoint' => 'https://api-ci.quadpay.com/',
            'authTokenEndpoint' => 'https://api-ci.quadpay.com/',
            'apiAudience' => 'https://api-ci.quadpay.com/',
        ]);
        $paymentMethod->getGatewayConfig()->willReturn($gatewayConfig);

The method willReturn() does not exist on Payum\Core\Model\GatewayConfigInterface.

        $payment->getMethod()->willReturn($paymentMethod);

The method willReturn() does not exist on Sylius\Component\Payment\Model\PaymentMethodInterface.

        $payment->getAmount()->willReturn(222222);
        $payment->getDetails()->willReturn([
            'orderToken' => 'test',
        ]);
        /** @var string|array $argumentAny */
        $argumentAny = Argument::any();
        $quadPayApiClient->setConfig(
            'test',
            'test',
            'https://api-ci.quadpay.com/',
            'https://api-ci.quadpay.com/',
            'https://api-ci.quadpay.com/'
        );
        $quadPayApiClient->refund(2222.22, $argumentAny, 'test', null)->willReturn(['refundId' => 'test']);

It seems like $argumentAny can also be of type array; however, parameter $merchantRefundReference of BitBag\SyliusQuadPayPlugin\Client\QuadPayApiClientInterface::refund() does only seem to accept string, maybe add an additional type check?

        $payment->setDetails($argumentAny)->shouldBeCalled();

Are you sure the usage of $payment->setDetails($argumentAny) targeting Sylius\Component\Payment\Model\PaymentInterface::setDetails() seems to always return null.

It seems like $argumentAny can also be of type string; however, parameter $details of Sylius\Component\Payment\Model\PaymentInterface::setDetails() does only seem to accept array, maybe add an additional type check?

        $this->process($payment);

The method process() does not exist on spec\BitBag\SyliusQuadPayPlugin\PaymentProcessing\RefundPaymentProcessorSpec. Since you implemented __call, consider adding a @method annotation.

    }
}