BitBagCommerce / SyliusMolliePlugin

src/Resolver/MollieAllowedMethodsResolver.php

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * You can find more information about us on https://bitbag.io and write us
 * an email on hello@bitbag.io.
 */

declare(strict_types=1);

namespace BitBag\SyliusMolliePlugin\Resolver;

use BitBag\SyliusMolliePlugin\Creator\MollieMethodsCreatorInterface;
use Sylius\Component\Core\Model\OrderInterface;
use Mollie\Api\Resources\Method;

final class MollieAllowedMethodsResolver implements MollieAllowedMethodsResolverInterface
{
    /** @var MollieApiClientKeyResolverInterface */
    private $mollieApiClientKeyResolver;

    public function __construct(MollieApiClientKeyResolverInterface $mollieApiClientKeyResolver)
    {
        $this->mollieApiClientKeyResolver = $mollieApiClientKeyResolver;
    }

    public function resolve(OrderInterface $order): array
    {
        $allowedMethodsIds = [];

        $client = $this->mollieApiClientKeyResolver->getClientWithKey();

        /** API will return only payment methods allowed for order total, currency, billing country */
        $allowedMethods = $client->methods->allActive($this->createParametersByOrder($order));

        /** @var Method $method */
        foreach ($allowedMethods as $method) {
            $allowedMethodsIds[] = $method->id;
        }

        return $allowedMethodsIds;
    }

    private function createParametersByOrder($order): array
    {
        return array_merge(
            [
                'amount' => [
                    'value' => $this->parseTotalToString($order->getTotal()),
                    'currency' => $order->getCurrencyCode(),
                ],
                'locale' => $order->getLocaleCode(),
                'billingCountry' => null !== $order->getBillingAddress()
                    ? $order->getBillingAddress()->getCountryCode()
                    : null
            ],
            MollieMethodsCreatorInterface::PARAMETERS
        );
    }

    private function parseTotalToString(int $total): string
    {
        return substr_replace((string)$total, '.', -2, 0);

The expression return substr_replace((string)$total, '.', -2, 0) could return the type array which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}