BitBagCommerce / SyliusMolliePlugin

src/Provider/Apple/ApplePayDirectProvider.php

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * You can find more information about us on https://bitbag.io and write us
 * an email on hello@bitbag.io.
 */

declare(strict_types=1);

namespace BitBag\SyliusMolliePlugin\Provider\Apple;

use BitBag\SyliusMolliePlugin\Client\MollieApiClient;
use BitBag\SyliusMolliePlugin\Provider\Order\OrderPaymentApplePayDirectProviderInterface;
use BitBag\SyliusMolliePlugin\Resolver\Address\ApplePayAddressResolverInterface;
use Sylius\AdminOrderCreationPlugin\Provider\CustomerProviderInterface;
use Sylius\Component\Core\Model\PaymentInterface;
use Sylius\Component\Order\Model\OrderInterface;
use Symfony\Component\HttpFoundation\Request;
use Webmozart\Assert\Assert;

final class ApplePayDirectProvider implements ApplePayDirectProviderInterface
{
    /** @var ApplePayAddressResolverInterface */
    private $applePayAddressResolver;

    /** @var MollieApiClient */
    private $mollieApiClient;

    /** @var OrderPaymentApplePayDirectProviderInterface */
    private $paymentApplePayDirectProvider;

    /** @var CustomerProviderInterface */
    private $customerProvider;

    /** @var ApplePayDirectPaymentProviderInterface */
    private $applePayDirectPaymentProvider;

    public function __construct(
        ApplePayAddressResolverInterface $applePayAddressResolver,
        MollieApiClient $mollieApiClient,
        OrderPaymentApplePayDirectProviderInterface $paymentApplePayDirectProvider,
        CustomerProviderInterface $customerProvider,
        ApplePayDirectPaymentProviderInterface $applePayDirectPaymentProvider
    ) {
        $this->applePayAddressResolver = $applePayAddressResolver;
        $this->mollieApiClient = $mollieApiClient;
        $this->paymentApplePayDirectProvider = $paymentApplePayDirectProvider;
        $this->customerProvider = $customerProvider;
        $this->applePayDirectPaymentProvider = $applePayDirectPaymentProvider;
    }

    public function provideOrder(OrderInterface $order, Request $request): void
    {
        $applePayPaymentToken = $request->get('token');
        $applePayAddress['shippingContact'] = $request->get('shippingContact');

$applePayAddress was never initialized. Although not strictly required by PHP, it is generally a good practice to add $applePayAddress = array(); before regardless.

        $applePayAddress['billingContact'] = $request->get('billingContact');

        Assert::notNull($applePayPaymentToken);
        Assert::notNull($applePayAddress['shippingContact']);
        Assert::notNull($applePayAddress['billingContact']);

        if (isset($applePayAddress['shippingContact']['emailAddress'])) {
            $applePayAddress['billingContact']['emailAddress'] = $applePayAddress['shippingContact']['emailAddress'];
        }

        $this->applePayAddressResolver->resolve($order, $applePayAddress);
        $this->paymentApplePayDirectProvider->provideOrderPayment($order, PaymentInterface::STATE_NEW);

        if (null !== $customer = $order->getShippingAddress()->getCustomer()) {

The method getShippingAddress() does not exist on Sylius\Component\Order\Model\OrderInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Sylius\Component\Order\Model\Order. Are you sure you never get one of those?

            $order->setCustomer($customer);

The method setCustomer() does not exist on Sylius\Component\Order\Model\OrderInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Sylius\Component\Order\Model\Order. Are you sure you never get one of those?

        }

        if (null === $order->getCustomer()) {

The method getCustomer() does not exist on Sylius\Component\Order\Model\OrderInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Sylius\Component\Order\Model\Order. Are you sure you never get one of those?

            $this->customerProvider->provideNewCustomer($applePayAddress['shippingContact']['emailAddress']);
        }

        $this->applePayDirectPaymentProvider->provideApplePayPayment($order, $applePayPaymentToken);

It seems like $applePayPaymentToken can also be of type null; however, parameter $applePayPaymentToken of BitBag\SyliusMolliePlugin\Provider\Apple\ApplePayDirectPaymentProviderInterface::provideApplePayPayment() does only seem to accept array, maybe add an additional type check?

    }
}