BitBagCommerce / SyliusMolliePlugin

spec/Action/NotifyActionSpec.php

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on mikolaj.krol@bitbag.pl.
 */

declare(strict_types=1);

namespace spec\BitBag\SyliusMolliePlugin\Action;

use BitBag\SyliusMolliePlugin\Action\NotifyAction;
use BitBag\SyliusMolliePlugin\Client\MollieApiClient;
use BitBag\SyliusMolliePlugin\Repository\SubscriptionRepositoryInterface;
use Mollie\Api\Endpoints\PaymentEndpoint;
use Payum\Core\Action\ActionInterface;
use Payum\Core\ApiAwareInterface;
use Payum\Core\GatewayAwareInterface;
use Payum\Core\GatewayInterface;
use Payum\Core\Request\GetHttpRequest;
use Payum\Core\Request\Notify;
use PhpSpec\ObjectBehavior;

final class NotifyActionSpec extends ObjectBehavior
{
    function let(GetHttpRequest $getHttpRequest, SubscriptionRepositoryInterface $subscriptionRepository): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->beConstructedWith($getHttpRequest, $subscriptionRepository);
    }

    function it_is_initializable(): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(NotifyAction::class);
    }

    function it_implements_action_interface(): void
    {
        $this->shouldHaveType(ActionInterface::class);
    }

    function it_implements_api_aware_interface(): void
    {
        $this->shouldHaveType(ApiAwareInterface::class);
    }

    function it_implements_gateway_aware_interface(): void
    {
        $this->shouldHaveType(GatewayAwareInterface::class);
    }

    function it_executes(
        Notify $request,
        \ArrayObject $arrayObject,
        GatewayInterface $gateway,
        GetHttpRequest $getHttpRequest,
        MollieApiClient $mollieApiClient,
        PaymentEndpoint $paymentEndpoint
    ): void {
        $this->setGateway($gateway);

The method setGateway() does not exist on spec\BitBag\SyliusMolliePlugin\Action\NotifyActionSpec. Since you implemented __call, consider adding a @method annotation.

        $this->setApi($mollieApiClient);

The method setApi() does not exist on spec\BitBag\SyliusMolliePlugin\Action\NotifyActionSpec. Since you implemented __call, consider adding a @method annotation.

        $getHttpRequest->request = ['id' => 1];
        $request->getModel()->willReturn($arrayObject);
        $payment = \Mockery::mock('payment');
        $payment->id = 1;

Accessing id on the interface Mockery\MockInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing id on the interface Mockery\LegacyMockInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $payment->metadata = (object) [

Accessing metadata on the interface Mockery\MockInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing metadata on the interface Mockery\LegacyMockInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            'order_id' => 1,
        ];
        $payment->shouldReceive('getCheckoutUrl')->andReturn('');
        $paymentEndpoint->get(1)->willReturn($payment);

The method willReturn() does not exist on Mollie\Api\Resources\Payment.

        $mollieApiClient->payments = $paymentEndpoint;

        $this->execute($request);

The method execute() does not exist on spec\BitBag\SyliusMolliePlugin\Action\NotifyActionSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_supports_only_notify_request_and_array_access(
        Notify $request,
        \ArrayAccess $arrayAccess
    ): void {
        $request->getModel()->willReturn($arrayAccess);

        $this->supports($request)->shouldReturn(true);

The method supports() does not exist on spec\BitBag\SyliusMolliePlugin\Action\NotifyActionSpec. Since you implemented __call, consider adding a @method annotation.

    }
}