CaptureActionSpec::it_executes() - Code Metrics - Inspection of "Update README.md" - BitBagCommerce/SyliusMolliePlugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2bdea1...160902 )

by Mikołaj

created 2018-05-04 09:58 UTC

CaptureActionSpec::it_executes() A

↳ Parent: CaptureActionSpec

Complexity

Conditions	1
Paths	1

Size

Total Lines	56
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	56
rs	9.7251
c	0
b	0
f	0
cc	1
eloc	42
nc	1
nop	10

How to fix Long Method Many Parameters

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on [email protected].
 */

declare(strict_types=1);

namespace spec\BitBag\SyliusMolliePlugin\Action;

use BitBag\SyliusMolliePlugin\Action\CaptureAction;
use BitBag\SyliusMolliePlugin\Client\MollieApiClient;
use Payum\Core\Action\ActionInterface;
use Payum\Core\ApiAwareInterface;
use Payum\Core\Bridge\Spl\ArrayObject;
use Payum\Core\GatewayAwareInterface;
use Payum\Core\GatewayInterface;
use Payum\Core\Payum;
use Payum\Core\Reply\HttpPostRedirect;
use Payum\Core\Request\Capture;
use Payum\Core\Security\GenericTokenFactory;
use Payum\Core\Security\GenericTokenFactoryAwareInterface;
use Payum\Core\Security\TokenInterface;
use PhpSpec\ObjectBehavior;
use Sylius\Component\Core\Model\PaymentInterface;

final class CaptureActionSpec extends ObjectBehavior
{
    function it_is_initializable(): void

    {
        $this->shouldHaveType(CaptureAction::class);
    }

    function it_implements_action_interface(): void
    {
        $this->shouldHaveType(ActionInterface::class);
    }

    function it_implements_generic_token_factory_aware(): void
    {
        $this->shouldHaveType(GenericTokenFactoryAwareInterface::class);
    }

    function it_implements_api_aware_interface(): void
    {
        $this->shouldHaveType(ApiAwareInterface::class);
    }

    function it_implements_gateway_aware_interface(): void
    {
        $this->shouldHaveType(GatewayAwareInterface::class);
    }

    function it_executes(
        Capture $request,
        ArrayObject $arrayObject,
        PaymentInterface $payment,
        TokenInterface $token,
        TokenInterface $notifyToken,
        Payum $payum,
        GenericTokenFactory $genericTokenFactory,
        GatewayInterface $gateway,
        MollieApiClient $mollieApiClient,
        \Mollie_API_Resource_Base $mollieApiResourceBase
    ): void {
        $this->setGateway($gateway);
               setGateway($gateway);
        $mollieApiClient->isRecurringSubscription()->willReturn(false);
        $this->setApi($mollieApiClient);
               setApi($mollieApiClient);
        $notifyToken->getTargetUrl()->willReturn('url');
        $notifyToken->getHash()->willReturn('test');
        $token->getTargetUrl()->willReturn('url');
        $token->getAfterUrl()->willReturn('url');
        $token->getGatewayName()->willReturn('test');
        $token->getDetails()->willReturn([]);
        $token->getHash()->willReturn('test');
        $genericTokenFactory->createNotifyToken('test', [])->willReturn($notifyToken);
        $genericTokenFactory->createNotifyToken('test', [])->/** @scrutinizer ignore-call */ willReturn($notifyToken);
        $genericTokenFactory->createRefundToken('test', [])->willReturn($notifyToken);
        $this->setGenericTokenFactory($genericTokenFactory);
               setGenericTokenFactory($genericTokenFactory);
        $payum->getTokenFactory()->willReturn($genericTokenFactory);
        $payum->getTokenFactory()->/** @scrutinizer ignore-call */ willReturn($genericTokenFactory);
        $arrayObject->toUnsafeArray()->willReturn([]);
        $request->getModel()->willReturn($arrayObject);
        $request->getFirstModel()->willReturn($payment);
        $request->getToken()->willReturn($token);
        $payment = \Mockery::mock('payment');
        $payment->id = 1;

        $payment->shouldReceive('getPaymentUrl')->andReturn('');
        $mollieApiResourceBase->create([
            'amount' => null,
            'description' => null,
            'redirectUrl' => 'url',
            'webhookUrl' => null,
            'metadata' => null,
        ])->willReturn($payment);
        $mollieApiClient->payments = $mollieApiResourceBase;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}

        $arrayObject->offsetGet('description')->shouldBeCalled();
        $arrayObject->offsetGet('webhookUrl')->shouldBeCalled();
        $arrayObject->offsetGet('amount')->shouldBeCalled();
        $arrayObject->offsetExists('subscription_mollie_id')->shouldBeCalled();
        $arrayObject->offsetExists('payment_mollie_id')->shouldBeCalled();
        $arrayObject->offsetExists('payment_mollie_id')->shouldBeCalled();
        $arrayObject->offsetGet('metadata')->shouldBeCalled();
        $arrayObject->offsetSet('metadata', ['refund_token' => 'test'])->shouldBeCalled();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $arrayObject->offsetSet('payment_mollie_id', 1)->shouldBeCalled();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $arrayObject->offsetSet('webhookUrl', 'url')->shouldBeCalled();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

        $this
            ->shouldThrow(HttpPostRedirect::class)
            ->during('execute', [$request])
        ;
    }

    function it_supports_only_capture_request_and_array_access(
        Capture $request,
        \ArrayAccess $arrayAccess
    ): void {
        $request->getModel()->willReturn($arrayAccess);

        $this->supports($request)->shouldReturn(true);
               supports($request)->shouldReturn(true);
    }
}


BitBagCommerce / SyliusMolliePlugin

Push — master ( 2bdea1...160902 )

CaptureActionSpec::it_executes() A

Complexity

Size

Duplication

Importance

How to fix Long Method Many Parameters

Long Method

Many Parameters

Duplication Side-by-Side

Filter issues like