CreateRecurringSubscriptionActionSpec::it_executes() - Code Metrics - Inspection of "Update README.md" - BitBagCommerce/SyliusMolliePlugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2bdea1...160902 )

by Mikołaj

created 2018-05-04 09:58 UTC

it_executes() B

↳ Parent: CreateRecurringSubscriptionActionSpec

Complexity

Conditions	1
Paths	1

Size

Total Lines	39
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	39
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	24
nc	1
nop	11

How to fix Many Parameters

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on [email protected].
 */

declare(strict_types=1);

namespace spec\BitBag\SyliusMolliePlugin\Action\Api;

use BitBag\SyliusMolliePlugin\Action\Api\BaseApiAwareAction;
use BitBag\SyliusMolliePlugin\Action\Api\CreateRecurringSubscriptionAction;
use BitBag\SyliusMolliePlugin\Client\MollieApiClient;
use BitBag\SyliusMolliePlugin\Entity\SubscriptionInterface;
use BitBag\SyliusMolliePlugin\Request\Api\CreateRecurringSubscription;
use Doctrine\ORM\EntityManagerInterface;
use Payum\Core\Action\ActionInterface;
use Payum\Core\ApiAwareInterface;
use Payum\Core\Bridge\Spl\ArrayObject;
use Payum\Core\GatewayAwareInterface;
use Payum\Core\GatewayInterface;
use PhpSpec\ObjectBehavior;
use SM\Factory\FactoryInterface as SateMachineFactoryInterface;
use Sylius\Component\Core\Model\OrderInterface;
use Sylius\Component\Core\Repository\OrderRepositoryInterface;
use Sylius\Component\Resource\Factory\FactoryInterface;

final class CreateRecurringSubscriptionActionSpec extends ObjectBehavior
{
    function let(

        FactoryInterface $subscriptionFactory,
        EntityManagerInterface $subscriptionManager,
        SateMachineFactoryInterface $subscriptionSateMachineFactory,
        OrderRepositoryInterface $orderRepository
    ): void {
        $this->beConstructedWith(
            $subscriptionFactory,
            $subscriptionManager,
            $subscriptionSateMachineFactory,
            $orderRepository
        );
    }

    function it_is_initializable(): void

    {
        $this->shouldHaveType(CreateRecurringSubscriptionAction::class);
    }

    function it_implements_action_interface(): void
    {
        $this->shouldHaveType(ActionInterface::class);
    }

    function it_implements_api_aware_interface(): void
    {
        $this->shouldHaveType(ApiAwareInterface::class);
    }

    function it_implements_gateway_aware_interface(): void
    {
        $this->shouldHaveType(GatewayAwareInterface::class);
    }

    function it_extends_base_api_aware(): void
    {
        $this->shouldHaveType(BaseApiAwareAction::class);
    }

    function it_executes(
        CreateRecurringSubscription $request,
        MollieApiClient $mollieApiClient,
        ArrayObject $arrayObject,
        \Mollie_API_Resource_Customers_Subscriptions $subscriptions,
        \Mollie_API_Object_Customer_Subscription $customerSubscription,
        \Mollie_API_Resource_Base $resourceBase,
        FactoryInterface $subscriptionFactory,
        SubscriptionInterface $subscription,
        OrderInterface $order,
        OrderRepositoryInterface $orderRepository,
        GatewayInterface $gateway
    ): void {
        $this->setApi($mollieApiClient);
               setApi($mollieApiClient);
        $this->setGateway($gateway);
               setGateway($gateway);
        $mollieApiClient->customers_subscriptions = $subscriptions;
        $orderRepository->find(1)->willReturn($order);
        $subscriptionFactory->createNew()->willReturn($subscription);
        $arrayObject->offsetGet('customer_mollie_id')->willReturn('id_1');
        $arrayObject->offsetGet('interval')->willReturn('3 days');
        $arrayObject->offsetGet('description')->willReturn('');
        $arrayObject->offsetGet('webhookUrl')->willReturn('www.example.com/webhookUrl');
        $arrayObject->offsetGet('metadata')->willReturn(['order_id' => 1]);
        $arrayObject->offsetGet('amount')->willReturn(100);
        $resourceBase->create([
            'amount' => 100,
            'interval' => '3 days',
            'description' => '',
            'method' => 'directdebit',
            'webhookUrl' => 'www.example.com/webhookUrl',
            'metadata' => ['order_id' => 1],
        ])->willReturn($customerSubscription);
        $subscriptions->withParentId('id_1')->willReturn($resourceBase);
        $subscriptions->withParentId('id_1')->/** @scrutinizer ignore-call */ willReturn($resourceBase);
        $request->getModel()->willReturn($arrayObject);

        $arrayObject->offsetExists('subscription_id')->shouldBeCalled();
        $arrayObject->offsetSet('subscription_mollie_id', null)->shouldBeCalled();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

        $this->execute($request);
               execute($request);
    }

    function it_supports_only_create_recurring_subscription_request_and_array_access(
        CreateRecurringSubscription $request,
        \ArrayAccess $arrayAccess
    ): void {
        $request->getModel()->willReturn($arrayAccess);

        $this->supports($request)->shouldReturn(true);
               supports($request)->shouldReturn(true);
    }
}


BitBagCommerce / SyliusMolliePlugin

Push — master ( 2bdea1...160902 )

it_executes() B

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like