ApiKeysTestCreator::testApiKey() - Code Metrics - Inspection of "Fix template render" - BitBagCommerce/SyliusMolliePlugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d0defb...6219a1 )

unknown

created 2021-01-29 10:23 UTC

ApiKeysTestCreator::testApiKey() A

↳ Parent: ApiKeysTestCreator

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	2
c	1
b	0
f	0
dl	0
loc	5
rs	10
cc	1
nc	1
nop	1

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * You can find more information about us on https://bitbag.io and write us
 * an email on [email protected].
 */

declare(strict_types=1);

namespace BitBag\SyliusMolliePlugin\Creator;

use BitBag\SyliusMolliePlugin\Client\MollieApiClient;
use BitBag\SyliusMolliePlugin\DTO\ApiKeyTest;
use Mollie\Api\Resources\MethodCollection;

final class ApiKeysTestCreator implements ApiKeysTestCreatorInterface
{
    /** @var MollieApiClient */
    private $mollieApiClient;

    public function __construct(MollieApiClient $mollieApiClient)
    {
        $this->mollieApiClient = $mollieApiClient;
    }

    public function create(string $keyType, string $key = null): ApiKeyTest
    {
        if (null !== $key && !empty(trim($key))) {
            return new ApiKeyTest(
                $keyType,
                $key ? true : false,
                $this->testApiKey($key)
            );
        }

        return new ApiKeyTest(
            $keyType,
        );
    }

    private function testApiKey(string $apiKey): MethodCollection
    {
        $client = $this->mollieApiClient->setApiKey($apiKey);

        return $client->methods->allActive(MollieMethodsCreatorInterface::PARAMETERS);

    }
}


1			<?php
2
3			/*
4			* This file has been created by developers from BitBag.
5			* Feel free to contact us once you face any issues or want to start
6			* You can find more information about us on https://bitbag.io and write us
7			* an email on [email protected].
8			*/
9
10			declare(strict_types=1);
11
12			namespace BitBag\SyliusMolliePlugin\Creator;
13
14			use BitBag\SyliusMolliePlugin\Client\MollieApiClient;
15			use BitBag\SyliusMolliePlugin\DTO\ApiKeyTest;
16			use Mollie\Api\Resources\MethodCollection;
17
18			final class ApiKeysTestCreator implements ApiKeysTestCreatorInterface
19			{
20			/** @var MollieApiClient */
21			private $mollieApiClient;
22
23			public function __construct(MollieApiClient $mollieApiClient)
24			{
25			$this->mollieApiClient = $mollieApiClient;
26			}
27
28			public function create(string $keyType, string $key = null): ApiKeyTest
29			{
30			if (null !== $key && !empty(trim($key))) {
31			return new ApiKeyTest(
32			$keyType,
33			$key ? true : false,
34			$this->testApiKey($key)
35			);
36			}
37
38			return new ApiKeyTest(
39			$keyType,
40			);
41			}
42
43			private function testApiKey(string $apiKey): MethodCollection
44			{
45			$client = $this->mollieApiClient->setApiKey($apiKey);
46
47			return $client->methods->allActive(MollieMethodsCreatorInterface::PARAMETERS);
			0 ignored issues – show Bug Best Practice introduced 2021-01-29 09:25 UTC by Report Bug Copy Issue Report The expression `return $client->methods-...rInterface::PARAMETERS)` returns the type `Mollie\Api\Resources\BaseCollection` which includes types incompatible with the type-hinted return `Mollie\Api\Resources\MethodCollection`. Loading history...
48			}
49			}
50

BitBagCommerce / SyliusMolliePlugin

Push — master ( d0defb...6219a1 )

ApiKeysTestCreator::testApiKey() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like