BitBag\SyliusMolliePlugin\Resolver\MolliePaymentsMethodResolver

Complexity

Total Complexity

11

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	1
A	resolve()	0	27	5
A	getDefaultOptions()	0	7	1
A	getMolliePaymentOptions()	0	25	4

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on mikolaj.krol@bitbag.pl.
 */

declare(strict_types=1);

namespace BitBag\SyliusMolliePlugin\Resolver;

use BitBag\SyliusMolliePlugin\Entity\GatewayConfigInterface;
use BitBag\SyliusMolliePlugin\Entity\MollieGatewayConfigInterface;
use BitBag\SyliusMolliePlugin\Factory\MollieGatewayFactory;
use Sylius\Component\Core\Model\OrderInterface;
use Sylius\Component\Order\Context\CartContextInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Symfony\Component\HttpFoundation\Session\Session;

final class MolliePaymentsMethodResolver implements MolliePaymentsMethodResolverInterface
{
    /** @var RepositoryInterface */
    private $orderRepository;

    /** @var RepositoryInterface */
    private $gatewayConfigRepository;

    /** @var RepositoryInterface */
    private $mollieGatewayRepository;

    /** @var Session */
    private $session;

    /** @var CartContextInterface */
    private $cartContext;

    /** @var MollieCountriesRestrictionResolverInterface */
    private $countriesRestrictionResolver;

    public function __construct(
        RepositoryInterface $orderRepository,
        RepositoryInterface $gatewayConfigRepository,
        RepositoryInterface $mollieGatewayRepository,
        Session $session,
        CartContextInterface $cartContext,
        MollieCountriesRestrictionResolverInterface $countriesRestrictionResolver
    ) {
        $this->orderRepository = $orderRepository;
        $this->gatewayConfigRepository = $gatewayConfigRepository;
        $this->mollieGatewayRepository = $mollieGatewayRepository;
        $this->session = $session;
        $this->cartContext = $cartContext;
        $this->countriesRestrictionResolver = $countriesRestrictionResolver;
    }

    public function resolve(): array
    {
        $orderId = $this->session->get('sylius_order_id');
        $orderFromSession = null;

        $order = $this->cartContext->getCart();

        if (null !== $orderId) {
            $orderFromSession = $this->orderRepository->findOneBy(['id' => $orderId]);
        }

        if (null !== $orderFromSession) {
            $order = $orderFromSession;
        }

        /** @var OrderInterface $order */
        $address = $order->getBillingAddress();

        if (null === $address) {
            $address = $order->getShippingAddress();
        }

        if (null === $address) {
            return $this->getDefaultOptions();
        }

        return $this->getMolliePaymentOptions($address->getCountryCode());

It seems like $address->getCountryCode() can also be of type null; however, parameter $countryCode of BitBag\SyliusMolliePlugin\Resolver\MolliePaymentsMethodResolver::getMolliePaymentOptions() does only seem to accept string, maybe add an additional type check?

    }

    private function getMolliePaymentOptions(string $countryCode): array
    {
        $methods = $this->getDefaultOptions();

        /** @var GatewayConfigInterface $gateway */
        $gateway = $this->gatewayConfigRepository->findOneBy([
            'factoryName' => MollieGatewayFactory::FACTORY_NAME,
        ]);

        if (null === $gateway) {
            return $this->getDefaultOptions();
        }

        $paymentConfigs = $this->mollieGatewayRepository->findAllEnabledByGateway($gateway);

The method findAllEnabledByGateway() does not exist on Sylius\Component\Resource\Repository\RepositoryInterface. Did you maybe mean findAll()?

        if (empty($paymentConfigs)) {
            return $this->getDefaultOptions();
        }

        /** @var MollieGatewayConfigInterface $paymentMethod */
        foreach ($paymentConfigs as $paymentMethod) {
            $methods = $this->countriesRestrictionResolver->resolve($paymentMethod, $methods, $countryCode);
        }

        return $methods;

The expression return $methods could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    private function getDefaultOptions(): array
    {
        return [
            'data' => [],
            'image' => [],
            'issuers' => [],
            'paymentFee' => [],
        ];
    }
}