BitBag\SyliusMolliePlugin\Creator\ApiKeysTestCreator

Complexity

Total Complexity

5

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	testApiKey()	0	5	1
A	create()	0	12	3

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * You can find more information about us on https://bitbag.io and write us
 * an email on hello@bitbag.io.
 */

declare(strict_types=1);

namespace BitBag\SyliusMolliePlugin\Creator;

use BitBag\SyliusMolliePlugin\Client\MollieApiClient;
use BitBag\SyliusMolliePlugin\DTO\ApiKeyTest;
use Mollie\Api\Resources\MethodCollection;

final class ApiKeysTestCreator implements ApiKeysTestCreatorInterface
{
    /** @var MollieApiClient */
    private $mollieApiClient;

    public function __construct(MollieApiClient $mollieApiClient)
    {
        $this->mollieApiClient = $mollieApiClient;
    }

    public function create(string $keyType, string $key = null): ApiKeyTest
    {
        if (!empty(trim($key))) {

It seems like $key can also be of type null; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

            return new ApiKeyTest(
                $keyType,
                $key ? true : false,
                $this->testApiKey($key)

It seems like $key can also be of type null; however, parameter $apiKey of BitBag\SyliusMolliePlugin\Creator\ApiKeysTestCreator::testApiKey() does only seem to accept string, maybe add an additional type check?

            );
        }

        return new ApiKeyTest(
            $keyType,
        );
    }

    private function testApiKey(string $apiKey): MethodCollection
    {
        $client = $this->mollieApiClient->setApiKey($apiKey);

        return $client->methods->allActive();

The expression return $client->methods->allActive() returns the type Mollie\Api\Resources\BaseCollection which includes types incompatible with the type-hinted return Mollie\Api\Resources\MethodCollection.

    }
}