BitBag\SyliusMolliePlugin\Validator\Constraints\PaymentMethodMollieChannelUniqueValidator

Complexity

Total Complexity

18

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	isMolliePaymentMethod()	0	6	1
A	getChannelsNameByChannels()	0	10	2
A	getAlreadyUsedChannels()	0	15	4
A	validate()	0	4	4
A	isTheSameChannel()	0	9	3
A	__construct()	0	6	1
A	validateMolliePaymentMethod()	0	16	3

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * You can find more information about us on https://bitbag.io and write us
 * an email on hello@bitbag.io.
 */

declare(strict_types=1);

namespace BitBag\SyliusMolliePlugin\Validator\Constraints;

use BitBag\SyliusMolliePlugin\Entity\GatewayConfigInterface;
use BitBag\SyliusMolliePlugin\Factory\MollieGatewayFactory;
use BitBag\SyliusMolliePlugin\Repository\PaymentMethodRepositoryInterface;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Sylius\Component\Core\Model\ChannelInterface;
use Sylius\Component\Core\Model\PaymentMethodInterface;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator as ConstraintValidatorAlias;
use Symfony\Contracts\Translation\TranslatorInterface;

final class PaymentMethodMollieChannelUniqueValidator extends ConstraintValidatorAlias
{
    /** @var PaymentMethodRepositoryInterface */
    private $paymentMethodRepository;

    /** @var TranslatorInterface */
    private $translator;

    public function __construct(
        PaymentMethodRepositoryInterface $paymentMethodRepository,
        TranslatorInterface $translator
    ) {
        $this->paymentMethodRepository = $paymentMethodRepository;
        $this->translator = $translator;
    }

    public function validate($value, Constraint $constraint): void
    {
        if ($value instanceof PaymentMethodInterface && null !== $value->getCode()) {
            false === $this->isMolliePaymentMethod($value) ?: $this->validateMolliePaymentMethod($value, $constraint);
        }
    }

    private function validateMolliePaymentMethod(PaymentMethodInterface $paymentMethod, Constraint $constraint): void

The parameter $constraint is not used and could be removed.

    {
        $molliePaymentMethods = $this->paymentMethodRepository->findAllByFactoryNameAndCode($paymentMethod->getCode());

It seems like $paymentMethod->getCode() can also be of type null; however, parameter $code of BitBag\SyliusMolliePlugin\Repository\PaymentMethodRepositoryInterface::findAllByFactoryNameAndCode() does only seem to accept string, maybe add an additional type check?

        if (0 === count($molliePaymentMethods)) {
            return;
        }

        $alreadyUsedChannels = $this->getAlreadyUsedChannels($molliePaymentMethods);

        if ($this->isTheSameChannel($paymentMethod->getChannels(), $alreadyUsedChannels)) {
            $translation = $this->translator->trans('bitbag_sylius_mollie_plugin.form.channel_should_be_unique', [
                '{channels}' => $this->getChannelsNameByChannels($alreadyUsedChannels),
            ]);

            $this->context->buildViolation($translation)->atPath('channels')->addViolation();
        }
    }

    private function getAlreadyUsedChannels(array $molliePaymentMethods): Collection
    {
        $alreadyUsedChannels = new ArrayCollection();

        /** @var PaymentMethodInterface $molliePaymentMethod */
        foreach ($molliePaymentMethods as $molliePaymentMethod) {
            /** @var ChannelInterface $channel */
            foreach ($molliePaymentMethod->getChannels() as $channel) {
                if (!$alreadyUsedChannels->contains($channel)) {
                    $alreadyUsedChannels->add($channel);
                }
            }
        }

        return $alreadyUsedChannels;
    }

    private function isTheSameChannel(Collection $newChannels, Collection $paymentMethodExistingChannels): bool
    {
        foreach ($paymentMethodExistingChannels as $paymentMethodExistingChannel) {
            if ($newChannels->contains($paymentMethodExistingChannel)) {
                return true;
            }
        }

        return false;
    }

    private function isMolliePaymentMethod(PaymentMethodInterface $paymentMethod): bool
    {
        /** @var GatewayConfigInterface $gateway */
        $gateway = $paymentMethod->getGatewayConfig();

        return $gateway->getFactoryName() === MollieGatewayFactory::FACTORY_NAME;

The function Payum\Core\Model\GatewayConfigInterface::getFactoryName() has been deprecated: since 1.3.3 will be removed in 2.0. set factory option inside the config

    }

    private function getChannelsNameByChannels(Collection $alreadyUsedChannels): string
    {
        $channelsNames = '';

        /** @var ChannelInterface $channel */
        foreach ($alreadyUsedChannels as $channel) {
            $channelsNames .= \sprintf('%s ', $channel->getName());
        }

        return $channelsNames;
    }
}