MolliePaymentsMethodResolver::getMolliePaymentOptions()

Complexity

Conditions	9
Paths	13

Size

Total Lines	55
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    private function getMolliePaymentOptions(OrderInterface $order, string $countryCode): array
    {
        $allowedMethods = [];

        $methods = $this->getDefaultOptions();

        /** @var GatewayConfigInterface $gateway */
        $paymentMethod = $this->paymentMethodRepository->findOneByChannelAndGatewayFactoryName(
            $order->getChannel(),

It seems like $order->getChannel() can also be of type null; however, parameter $channel of BitBag\SyliusMolliePlugin\Repository\PaymentMethodRepositoryInterface::findOneByChannelAndGatewayFactoryName() does only seem to accept Sylius\Component\Core\Model\ChannelInterface, maybe add an additional type check?

            MollieGatewayFactory::FACTORY_NAME
        );

        if (null === $paymentMethod) {
            return $this->getDefaultOptions();
        }

        $gateway = $paymentMethod->getGatewayConfig();

        if (null === $gateway) {
            return $this->getDefaultOptions();
        }

        $paymentConfigs = $this->mollieGatewayRepository->findAllEnabledByGateway($gateway);

The method findAllEnabledByGateway() does not exist on Sylius\Component\Resource\Repository\RepositoryInterface. Did you maybe mean findAll()?

        if (empty($paymentConfigs)) {
            return $this->getDefaultOptions();
        }

        try {
            $allowedMethodsIds = $this->allowedMethodsResolver->resolve($order);
        } catch (ApiException $e) {
            $this->loggerAction->addNegativeLog($e->getMessage());

            return $this->getDefaultOptions();
        }

        /** @var MollieGatewayConfig $paymentMethod */
        foreach ($paymentConfigs as $paymentMethod) {
            if (in_array($paymentMethod->getMethodId(), $allowedMethodsIds, true)) {
                $allowedMethods[] = $paymentMethod;
            }
        }

        if (empty($allowedMethods)) {
            return $this->getDefaultOptions();
        }

        /** @var MollieGatewayConfigInterface $paymentMethod */
        foreach ($allowedMethods as $paymentMethod) {
            $methods = $this->countriesRestrictionResolver->resolve($paymentMethod, $methods, $countryCode);

It seems like $methods can also be of type null; however, parameter $methods of BitBag\SyliusMolliePlugin\Resolver\MollieCountriesRestrictionResolverInterface::resolve() does only seem to accept array, maybe add an additional type check?

        }

        $methods = $this->productVoucherTypeChecker->checkTheProductTypeOnCart($order, $methods);

It seems like $methods can also be of type null; however, parameter $methods of BitBag\SyliusMolliePlugin\Checker\Voucher\ProductVoucherTypeCheckerInterface::checkTheProductTypeOnCart() does only seem to accept array, maybe add an additional type check?

        return $methods;
    }