ConvertPaymentAction::execute() - Code Metrics - Inspection of "Feature/single click payment" - BitBagCommerce/SyliusMolliePlugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#35)

unknown

created 2020-07-29 11:00 UTC

ConvertPaymentAction::execute() B

↳ Parent: ConvertPaymentAction

Complexity

Conditions	7
Paths	20

Size

Total Lines	67
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	40
c	1
b	0
f	0
dl	0
loc	67
rs	8.3466
cc	7
nc	20
nop	1

How to fix Long Method

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on [email protected].
 */

declare(strict_types=1);

namespace BitBag\SyliusMolliePlugin\Action;

use BitBag\SyliusMolliePlugin\Action\Api\BaseApiAwareAction;
use BitBag\SyliusMolliePlugin\Entity\MollieGatewayConfigInterface;
use BitBag\SyliusMolliePlugin\Factory\MollieGatewayFactoryInterface;
use BitBag\SyliusMolliePlugin\Helper\ConvertOrderInterface;
use BitBag\SyliusMolliePlugin\Payments\PaymentTerms\Options;
use BitBag\SyliusMolliePlugin\Request\Api\CreateCustomer;
use Payum\Core\Action\ActionInterface;
use Payum\Core\ApiAwareInterface;
use Payum\Core\Exception\RequestNotSupportedException;
use Payum\Core\GatewayAwareInterface;
use Payum\Core\GatewayAwareTrait;
use Payum\Core\Request\Convert;
use Payum\Core\Request\GetCurrency;
use Sylius\Bundle\CoreBundle\Context\CustomerContext;
use Sylius\Bundle\PayumBundle\Provider\PaymentDescriptionProviderInterface;
use Sylius\Component\Core\Model\OrderInterface;
use Sylius\Component\Core\Model\PaymentInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Symfony\Component\HttpFoundation\Session\SessionInterface;

final class ConvertPaymentAction extends BaseApiAwareAction implements ActionInterface, GatewayAwareInterface, ApiAwareInterface
{
    use GatewayAwareTrait;

    /** @var PaymentDescriptionProviderInterface */
    private $paymentDescriptionProvider;

    /** @var SessionInterface */
    private $session;

    /** @var RepositoryInterface */
    private $mollieMethodsRepository;

    /** @var ConvertOrderInterface */
    private $orderConverter;

    /** @var CustomerContext */
    private $customerContext;

    public function __construct(
        PaymentDescriptionProviderInterface $paymentDescriptionProvider,
        SessionInterface $session,
        RepositoryInterface $mollieMethodsRepository,
        ConvertOrderInterface $orderConverter,
        CustomerContext $customerContext
    ) {
        $this->paymentDescriptionProvider = $paymentDescriptionProvider;
        $this->session = $session;
        $this->mollieMethodsRepository = $mollieMethodsRepository;
        $this->orderConverter = $orderConverter;
        $this->customerContext = $customerContext;
    }

    /** @param Convert $request */
    public function execute($request): void
    {
        RequestNotSupportedException::assertSupports($this, $request);

        /** @var PaymentInterface $payment */
        $payment = $request->getSource();

        /** @var OrderInterface $order */
        $order = $payment->getOrder();

        $customer = $order->getCustomer();

        $this->gateway->execute($currency = new GetCurrency($payment->getCurrencyCode()));

        $divisor = 10 ** $currency->exp;

        $amount = number_format(abs($payment->getAmount() / $divisor), 2, '.', '');
        $paymentOptions = $this->session->get('mollie_payment_options');

        /** @var MollieGatewayConfigInterface $method */
        $method = $this->mollieMethodsRepository->findOneBy(['methodId' => $paymentOptions['molliePaymentMethods']]);
        $gatewayConfig = $method->getGateway()->getConfig();

        $details = [
            'amount' => [
                'value' => "$amount",
                'currency' => $currency->code,
            ],
            'description' => $this->paymentDescriptionProvider->getPaymentDescription($payment),
            'metadata' => [
                'order_id' => $order->getId(),
                'customer_id' => $customer->getId() ?? null,
                'molliePaymentMethods' => $paymentOptions['molliePaymentMethods'] ?? null,
                'cartToken' => $paymentOptions['cartToken'] ?? null,
                'selected_issuer' => $paymentOptions['selected_issuer'] ?? null,
            ],
            'full_name' => $customer->getFullName() ?? null,
            'email' => $customer->getEmail() ?? null,
        ];

        if (null !== $this->customerContext->getCustomer() && true === $gatewayConfig['single_click_enabled']) {
            $this->gateway->execute($mollieCustomer = new CreateCustomer($details));
            $model = $mollieCustomer->getModel();
            $details['metadata']['customer_mollie_id'] = $model['customer_mollie_id'];
        }

        if (true === $this->mollieApiClient->isRecurringSubscription()) {
            $config = $this->mollieApiClient->getConfig();

            $details['times'] = $config['times'];
            $details['interval'] = $config['interval'];
        }

        if (false === $this->mollieApiClient->isRecurringSubscription()) {
            $details['customerId'] = $model['customer_mollie_id'] ?? null;
            $details['metadata']['methodType'] = Options::PAYMENT_API;
            $details['locale'] = true === in_array($order->getLocaleCode(), MollieGatewayFactoryInterface::LOCALES_AVAILABLE) ? $order->getLocaleCode() : 'en_US';

            if (array_search($method->getPaymentType(), Options::getAvailablePaymentType()) === Options::ORDER_API) {
                unset($details['customerId']);

                $details['metadata']['methodType'] = Options::ORDER_API;
                $details = $this->orderConverter->convert($order, $details, $divisor);
            }
        }

        $request->setResult($details);
    }

    public function supports($request): bool
    {
        return
            $request instanceof Convert &&
            $request->getSource() instanceof PaymentInterface &&
            $request->getTo() === 'array'
            ;
    }
}


1			<?php
2
3			/*
4			* This file has been created by developers from BitBag.
5			* Feel free to contact us once you face any issues or want to start
6			* another great project.
7			* You can find more information about us on https://bitbag.shop and write us
8			* an email on [email protected].
9			*/
10
11			declare(strict_types=1);
12
13			namespace BitBag\SyliusMolliePlugin\Action;
14
15			use BitBag\SyliusMolliePlugin\Action\Api\BaseApiAwareAction;
16			use BitBag\SyliusMolliePlugin\Entity\MollieGatewayConfigInterface;
17			use BitBag\SyliusMolliePlugin\Factory\MollieGatewayFactoryInterface;
18			use BitBag\SyliusMolliePlugin\Helper\ConvertOrderInterface;
19			use BitBag\SyliusMolliePlugin\Payments\PaymentTerms\Options;
20			use BitBag\SyliusMolliePlugin\Request\Api\CreateCustomer;
21			use Payum\Core\Action\ActionInterface;
22			use Payum\Core\ApiAwareInterface;
23			use Payum\Core\Exception\RequestNotSupportedException;
24			use Payum\Core\GatewayAwareInterface;
25			use Payum\Core\GatewayAwareTrait;
26			use Payum\Core\Request\Convert;
27			use Payum\Core\Request\GetCurrency;
28			use Sylius\Bundle\CoreBundle\Context\CustomerContext;
29			use Sylius\Bundle\PayumBundle\Provider\PaymentDescriptionProviderInterface;
30			use Sylius\Component\Core\Model\OrderInterface;
31			use Sylius\Component\Core\Model\PaymentInterface;
32			use Sylius\Component\Resource\Repository\RepositoryInterface;
33			use Symfony\Component\HttpFoundation\Session\SessionInterface;
34
35			final class ConvertPaymentAction extends BaseApiAwareAction implements ActionInterface, GatewayAwareInterface, ApiAwareInterface
36			{
37			use GatewayAwareTrait;
38
39			/** @var PaymentDescriptionProviderInterface */
40			private $paymentDescriptionProvider;
41
42			/** @var SessionInterface */
43			private $session;
44
45			/** @var RepositoryInterface */
46			private $mollieMethodsRepository;
47
48			/** @var ConvertOrderInterface */
49			private $orderConverter;
50
51			/** @var CustomerContext */
52			private $customerContext;
53
54			public function __construct(
55			PaymentDescriptionProviderInterface $paymentDescriptionProvider,
56			SessionInterface $session,
57			RepositoryInterface $mollieMethodsRepository,
58			ConvertOrderInterface $orderConverter,
59			CustomerContext $customerContext
60			) {
61			$this->paymentDescriptionProvider = $paymentDescriptionProvider;
62			$this->session = $session;
63			$this->mollieMethodsRepository = $mollieMethodsRepository;
64			$this->orderConverter = $orderConverter;
65			$this->customerContext = $customerContext;
66			}
67
68			/** @param Convert $request */
69			public function execute($request): void
70			{
71			RequestNotSupportedException::assertSupports($this, $request);
72
73			/** @var PaymentInterface $payment */
74			$payment = $request->getSource();
75
76			/** @var OrderInterface $order */
77			$order = $payment->getOrder();
78
79			$customer = $order->getCustomer();
80
81			$this->gateway->execute($currency = new GetCurrency($payment->getCurrencyCode()));
82
83			$divisor = 10 ** $currency->exp;
84
85			$amount = number_format(abs($payment->getAmount() / $divisor), 2, '.', '');
86			$paymentOptions = $this->session->get('mollie_payment_options');
87
88			/** @var MollieGatewayConfigInterface $method */
89			$method = $this->mollieMethodsRepository->findOneBy(['methodId' => $paymentOptions['molliePaymentMethods']]);
90			$gatewayConfig = $method->getGateway()->getConfig();
91
92			$details = [
93			'amount' => [
94			'value' => "$amount",
95			'currency' => $currency->code,
96			],
97			'description' => $this->paymentDescriptionProvider->getPaymentDescription($payment),
98			'metadata' => [
99			'order_id' => $order->getId(),
100			'customer_id' => $customer->getId() ?? null,
101			'molliePaymentMethods' => $paymentOptions['molliePaymentMethods'] ?? null,
102			'cartToken' => $paymentOptions['cartToken'] ?? null,
103			'selected_issuer' => $paymentOptions['selected_issuer'] ?? null,
104			],
105			'full_name' => $customer->getFullName() ?? null,
106			'email' => $customer->getEmail() ?? null,
107			];
108
109			if (null !== $this->customerContext->getCustomer() && true === $gatewayConfig['single_click_enabled']) {
110			$this->gateway->execute($mollieCustomer = new CreateCustomer($details));
111			$model = $mollieCustomer->getModel();
112			$details['metadata']['customer_mollie_id'] = $model['customer_mollie_id'];
113			}
114
115			if (true === $this->mollieApiClient->isRecurringSubscription()) {
116			$config = $this->mollieApiClient->getConfig();
117
118			$details['times'] = $config['times'];
119			$details['interval'] = $config['interval'];
120			}
121
122			if (false === $this->mollieApiClient->isRecurringSubscription()) {
123			$details['customerId'] = $model['customer_mollie_id'] ?? null;
124			$details['metadata']['methodType'] = Options::PAYMENT_API;
125			$details['locale'] = true === in_array($order->getLocaleCode(), MollieGatewayFactoryInterface::LOCALES_AVAILABLE) ? $order->getLocaleCode() : 'en_US';
126
127			if (array_search($method->getPaymentType(), Options::getAvailablePaymentType()) === Options::ORDER_API) {
128			unset($details['customerId']);
129
130			$details['metadata']['methodType'] = Options::ORDER_API;
131			$details = $this->orderConverter->convert($order, $details, $divisor);
132			}
133			}
134
135			$request->setResult($details);
136			}
137
138			public function supports($request): bool
139			{
140			return
141			$request instanceof Convert &&
142			$request->getSource() instanceof PaymentInterface &&
143			$request->getTo() === 'array'
144			;
145			}
146			}
147

BitBagCommerce / SyliusMolliePlugin

Pull Request — master (#35)

ConvertPaymentAction::execute() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like