BitBag\SyliusMolliePlugin\Controller\Action\Shop\OrderController::updateAppleOrderAction()

Complexity

Conditions	9
Paths	12

Size

Total Lines	69
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function updateAppleOrderAction(Request $request): Response
    {
        $configuration = $this->requestConfigurationFactory->create($this->metadata, $request);

        $this->isGrantedOr403($configuration, ResourceActions::UPDATE);
        $resource = $this->findOr404($configuration);

        /** @var ResourceControllerEvent $event */
        $event = $this->eventDispatcher->dispatchPreEvent(ResourceActions::UPDATE, $configuration, $resource);

        if ($event->isStopped() && !$configuration->isHtmlRequest()) {
            throw new HttpException($event->getErrorCode(), $event->getMessage());
        }

        if ($event->isStopped()) {
            $eventResponse = $event->getResponse();
            if (!empty($eventResponse)) {
                return $eventResponse;
            }

            return new JsonResponse([], Response::HTTP_BAD_REQUEST);
        }

        try {
            $this->getApplePayProviderService()->provideOrder($this->getCurrentCart(), $request);

            /** @var PaymentInterface $payment */
            $payment = $this->getCurrentCart()->getLastPayment();

The method getLastPayment() does not exist on Sylius\Component\Order\Model\OrderInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Sylius\Component\Order\Model\Order. Are you sure you never get one of those?

            if ($payment->getState() !== PaymentInterface::STATE_COMPLETED) {
                $response = [
                    'status' => 1,
                    'errors' => 'Payment not created',
                ];

                return new JsonResponse($response, Response::HTTP_BAD_REQUEST);
            }

            $this->resourceUpdateHandler->handle($resource, $configuration, $this->manager);
        } catch (UpdateHandlingException $exception) {
            return new JsonResponse([], Response::HTTP_BAD_REQUEST);
        }

        $postEvent = $this->eventDispatcher->dispatchPostEvent(ResourceActions::UPDATE, $configuration, $resource);

        $postEventResponse = $postEvent->getResponse();

        if (!empty($postEventResponse)) {
            return $postEventResponse;
        }

        $initializeEvent = $this->eventDispatcher->dispatchInitializeEvent(ResourceActions::UPDATE, $configuration, $resource);

        $initializeEventResponse = $initializeEvent->getResponse();

        if (!empty($initializeEventResponse)) {
            return $initializeEventResponse;
        }

        $redirect = $this->redirectToRoute('sylius_shop_order_thank_you');
        $dataResponse['returnUrl'] = $redirect->getTargetUrl();

$dataResponse was never initialized. Although not strictly required by PHP, it is generally a good practice to add $dataResponse = array(); before regardless.

        $dataResponse['responseToApple'] = ['status' => 0];

        $response = [
            'success' => true,
            'data' => $dataResponse,
        ];

        return new JsonResponse($response, Response::HTTP_OK);
    }