BitBagCommerce / SyliusElasticsearchPlugin

src/Facet/PriceFacet.php

<?php

/*
 * This file was created by developers working at BitBag
 * Do you need more information about us and what we do? Visit our https://bitbag.io website!
 * We are hiring developers from all over the world. Join us and start your new, exciting adventure and become part of us: https://bitbag.io/career
*/

declare(strict_types=1);

namespace BitBag\SyliusElasticsearchPlugin\Facet;

use BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\ConcatedNameResolverInterface;
use Elastica\Aggregation\AbstractAggregation;
use Elastica\Aggregation\Histogram;
use Elastica\Query\AbstractQuery;
use Elastica\Query\BoolQuery;
use Elastica\Query\Range;
use Sylius\Bundle\MoneyBundle\Formatter\MoneyFormatterInterface;
use Sylius\Component\Core\Context\ShopperContextInterface;

final class PriceFacet implements FacetInterface
{
    public const FACET_ID = 'price';

    /** @var ConcatedNameResolverInterface */
    private $channelPricingNameResolver;

    /** @var MoneyFormatterInterface */
    private $moneyFormatter;

    /** @var ShopperContextInterface */
    private $shopperContext;

    /** @var int */
    private $interval;

    public function __construct(
        ConcatedNameResolverInterface $channelPricingNameResolver,
        MoneyFormatterInterface $moneyFormatter,
        ShopperContextInterface $shopperContext,
        int $interval
    ) {
        $this->channelPricingNameResolver = $channelPricingNameResolver;
        $this->moneyFormatter = $moneyFormatter;
        $this->interval = $interval;
        $this->shopperContext = $shopperContext;
    }

    public function getAggregation(): AbstractAggregation
    {
        $priceFieldName = $this->channelPricingNameResolver->resolvePropertyName(
            $this->shopperContext->getChannel()->getCode()

It seems like $this->shopperContext->getChannel()->getCode() can also be of type null; however, parameter $suffix of BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\ConcatedNameResolverInterface::resolvePropertyName() does only seem to accept string, maybe add an additional type check?

        );
        $histogram = new Histogram(self::FACET_ID, $priceFieldName, $this->interval);
        $histogram->setMinimumDocumentCount(1);

        return $histogram;
    }

    public function getQuery(array $selectedBuckets): AbstractQuery
    {
        $priceFieldName = $this->channelPricingNameResolver->resolvePropertyName(
            $this->shopperContext->getChannel()->getCode()

It seems like $this->shopperContext->getChannel()->getCode() can also be of type null; however, parameter $suffix of BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\ConcatedNameResolverInterface::resolvePropertyName() does only seem to accept string, maybe add an additional type check?

        );
        $query = new BoolQuery();
        foreach ($selectedBuckets as $selectedBucket) {
            $query->addShould(
                new Range($priceFieldName, ['gte' => $selectedBucket, 'lte' => $selectedBucket + $this->interval])
            );
        }

        return $query;
    }

    public function getBucketLabel(array $bucket): string
    {
        $from = $this->moneyFormatter->format(
            (int) $bucket['key'],
            $this->shopperContext->getCurrencyCode(),
            $this->shopperContext->getLocaleCode()
        );
        $to = $this->moneyFormatter->format(
            (int) ($bucket['key'] + $this->interval),
            $this->shopperContext->getCurrencyCode(),
            $this->shopperContext->getLocaleCode()
        );

        return sprintf('%s - %s (%s)', $from, $to, $bucket['doc_count']);
    }

    public function getLabel(): string
    {
        return 'bitbag_sylius_elasticsearch_plugin.ui.facet.price.label';
    }
}