spec\BitBag\SyliusElasticsearchPlugin\QueryBuilder\SearchProductsQueryBuilderSpec

Complexity

Total Complexity

7

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	it_implements_query_builder_interface()	0	3	1
A	it_builds_multi_match_query_with_provided_query_string()	0	12	1
A	let()	0	19	1
A	it_is_initializable()	0	3	1
A	it_throws_an_exception_if_query_is_not_a_string()	0	3	1
A	it_throws_an_exception_if_query_is_not_present_in_data()	0	3	1
A	it_builds_multi_match_query_with_provided_query_string_and_fields_from_registry()	0	20	1

<?php

declare(strict_types=1);

namespace spec\BitBag\SyliusElasticsearchPlugin\QueryBuilder;

use BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\ConcatedNameResolverInterface;
use BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\SearchPropertyNameResolverRegistryInterface;
use BitBag\SyliusElasticsearchPlugin\QueryBuilder\QueryBuilderInterface;
use BitBag\SyliusElasticsearchPlugin\QueryBuilder\SearchProductsQueryBuilder;
use Elastica\Query\BoolQuery;
use Elastica\Query\MultiMatch;
use Elastica\Query\Term;
use Elastica\Query\Terms;
use PhpSpec\ObjectBehavior;
use Sylius\Component\Locale\Context\LocaleContextInterface;

final class SearchProductsQueryBuilderSpec extends ObjectBehavior
{
    private $isEnabeldQuery;
    private $hasChannelQuery;

    function let(
        SearchPropertyNameResolverRegistryInterface $searchPropertyNameResolverRegistry,
        LocaleContextInterface $localeContext,
        QueryBuilderInterface $isEnabledQueryBuilder,
        QueryBuilderInterface $hasChannelQueryBuilder
    ): void {
        $localeContext->getLocaleCode()->willReturn('en_US');
        $searchPropertyNameResolverRegistry->getPropertyNameResolvers()->willReturn([]);
        $this->isEnabeldQuery = new Term();
        $this->isEnabeldQuery->setTerm('enabled', true);

true of type true is incompatible with the type array|string expected by parameter $value of Elastica\Query\Term::setTerm().

        $isEnabledQueryBuilder->buildQuery([])->willReturn($this->isEnabeldQuery);

The method willReturn() does not exist on Elastica\Query\AbstractQuery.

        $this->hasChannelQuery = new Terms();
        $this->hasChannelQuery->setTerms('channels', ['web_us']);
        $hasChannelQueryBuilder->buildQuery([])->willReturn($this->hasChannelQuery);
        $this->beConstructedWith(
            $searchPropertyNameResolverRegistry,
            $localeContext,
            $isEnabledQueryBuilder,
            $hasChannelQueryBuilder
        );
    }

    function it_is_initializable(): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(SearchProductsQueryBuilder::class);
    }

    function it_implements_query_builder_interface(): void
    {
        $this->shouldHaveType(QueryBuilderInterface::class);
    }

    function it_throws_an_exception_if_query_is_not_present_in_data(): void
    {
        $this->shouldThrow(\RuntimeException::class)->during('buildQuery', [['not_relevant_key' => 'value']]);
    }

    function it_throws_an_exception_if_query_is_not_a_string(): void
    {
        $this->shouldThrow(\RuntimeException::class)->during('buildQuery', [['query' => new \stdClass()]]);
    }

    function it_builds_multi_match_query_with_provided_query_string(): void
    {
        $expectedMultiMatch = new MultiMatch();
        $expectedMultiMatch->setQuery('bmw');
        $expectedMultiMatch->setFuzziness('AUTO');
        $expectedMultiMatch->setFields([]);
        $expectedQuery = new BoolQuery();
        $expectedQuery->addMust($expectedMultiMatch);
        $expectedQuery->addFilter($this->isEnabeldQuery);
        $expectedQuery->addFilter($this->hasChannelQuery);

        $this->buildQuery(['query' => 'bmw'])->shouldBeLike($expectedQuery);

The method buildQuery() does not exist on spec\BitBag\SyliusElasticsearchPlugin\QueryBuilder\SearchProductsQueryBuilderSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_builds_multi_match_query_with_provided_query_string_and_fields_from_registry(
        SearchPropertyNameResolverRegistryInterface $searchPropertyNameResolverRegistry,
        ConcatedNameResolverInterface $firstPropertyNameResolver,
        ConcatedNameResolverInterface $secondPropertyNameResolver
    ): void {
        $firstPropertyNameResolver->resolvePropertyName('en_US')->shouldBeCalled()->willReturn('property_1_en_us');
        $secondPropertyNameResolver->resolvePropertyName('en_US')->shouldBeCalled()->willReturn('property_2_en_us');
        $searchPropertyNameResolverRegistry->getPropertyNameResolvers()->willReturn(
            [$firstPropertyNameResolver, $secondPropertyNameResolver]
        );
        $expectedMultiMatch = new MultiMatch();
        $expectedMultiMatch->setQuery('bmw');
        $expectedMultiMatch->setFuzziness('AUTO');
        $expectedMultiMatch->setFields(['property_1_en_us', 'property_2_en_us']);
        $expectedQuery = new BoolQuery();
        $expectedQuery->addMust($expectedMultiMatch);
        $expectedQuery->addFilter($this->isEnabeldQuery);
        $expectedQuery->addFilter($this->hasChannelQuery);

        $this->buildQuery(['query' => 'bmw'])->shouldBeLike($expectedQuery);
    }
}