BitBag\SyliusElasticsearchPlugin\QueryBuilder\HasPriceBetweenQueryBuilder

Complexity

Total Complexity

4

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	buildQuery()	0	4	3

<?php

/*
 * This file has been created by developers from BitBag. 
 * Feel free to contact us once you face any issues or want to start
 * another great project. 
 * You can find more information about us on https://bitbag.shop and write us
 * an email on mikolaj.krol@bitbag.pl. 
 */

declare(strict_types=1);

namespace BitBag\SyliusElasticsearchPlugin\QueryBuilder;

use BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\ConcatedNameResolverInterface;
use Elastica\Query\AbstractQuery;

final class HasPriceBetweenQueryBuilder implements QueryBuilderInterface
{
    /**
     * @var ConcatedNameResolverInterface
     */
    private $channelPricingNameResolver;

    /**
     * @var string
     */
    private $pricePropertyPrefix;

    /**
     * @param ConcatedNameResolverInterface $channelPricingNameResolver
     * @param string $pricePropertyPrefix
     */
    public function __construct(ConcatedNameResolverInterface $channelPricingNameResolver, string $pricePropertyPrefix)
    {
        $this->channelPricingNameResolver = $channelPricingNameResolver;
        $this->pricePropertyPrefix = $pricePropertyPrefix;
    }

    /**
     * {@inheritdoc}
     */
    public function buildQuery(array $data): ?AbstractQuery
    {
        if (!$minPrice = $data[$this->pricePropertyPrefix] || !$maxPrice = $data['max_' . $this->pricePropertyPrefix]) {

The assignment to $maxPrice is dead and can be removed.

Consider adding parentheses for clarity. Current Interpretation: $minPrice = ($data[$this->pricePropertyPrefix] || ! $maxPrice = $data['max_' . $this->pricePropertyPrefix]), Probably Intended Meaning: ($minPrice = $data[$this->pricePropertyPrefix]) || ! $maxPrice = $data['max_' . $this->pricePropertyPrefix]

The assignment to $minPrice is dead and can be removed.

            return null;
        }


    }
}