spec\BitBag\SyliusElasticsearchPlugin\Finder\NamedProductsFinderSpec

Complexity

Total Complexity

3

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	it_is_a_named_products_finder()	0	3	1
A	let()	0	5	1
A	it_finds_by_partial_name_of_products()	0	10	1

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on mikolaj.krol@bitbag.pl.
 */

declare(strict_types=1);

namespace spec\BitBag\SyliusElasticsearchPlugin\Finder;

use BitBag\SyliusElasticsearchPlugin\Finder\NamedProductsFinderInterface;
use BitBag\SyliusElasticsearchPlugin\QueryBuilder\QueryBuilderInterface;
use Elastica\Query\AbstractQuery;
use FOS\ElasticaBundle\Finder\FinderInterface;
use PhpSpec\ObjectBehavior;

final class NamedProductsFinderSpec extends ObjectBehavior
{
    function let(

It is generally recommended to explicitly declare the visibility for methods.

        QueryBuilderInterface $productsByPartialNameQueryBuilder,
        FinderInterface $productsFinder
    ): void {
        $this->beConstructedWith($productsByPartialNameQueryBuilder, $productsFinder);
    }

    function it_is_a_named_products_finder(): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldImplement(NamedProductsFinderInterface::class);
    }

    function it_finds_by_partial_name_of_products(
        QueryBuilderInterface $productsByPartialNameQueryBuilder,
        FinderInterface $productsFinder,
        AbstractQuery $query
    ): void {
        $productsByPartialNameQueryBuilder->buildQuery(['name' => 'part'])->willReturn($query);

The method willReturn() does not exist on Elastica\Query\AbstractQuery.

        $productsFinder->find($query)->willReturn([]);

        $this->findByNamePart('part')->shouldBeArray();

The method findByNamePart() does not exist on spec\BitBag\SyliusElasticsearchPlugin\Finder\NamedProductsFinderSpec. Since you implemented __call, consider adding a @method annotation.

    }
}