spec\BitBag\SyliusElasticsearchPlugin\QueryBuilder\HasPriceBetweenQueryBuilderSpec

Complexity

Total Complexity

4

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	it_is_initializable()	0	3	1
A	let()	0	9	1
A	it_implements_query_builder_interface()	0	3	1
A	it_builds_query()	0	19	1

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on mikolaj.krol@bitbag.pl.
 */

declare(strict_types=1);

namespace spec\BitBag\SyliusElasticsearchPlugin\QueryBuilder;

use BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\ConcatedNameResolverInterface;
use BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\PriceNameResolverInterface;
use BitBag\SyliusElasticsearchPlugin\QueryBuilder\HasPriceBetweenQueryBuilder;
use BitBag\SyliusElasticsearchPlugin\QueryBuilder\QueryBuilderInterface;
use Elastica\Query\Range;
use PhpSpec\ObjectBehavior;
use Sylius\Component\Channel\Context\ChannelContextInterface;
use Sylius\Component\Core\Model\ChannelInterface;

final class HasPriceBetweenQueryBuilderSpec extends ObjectBehavior
{
    function let(

It is generally recommended to explicitly declare the visibility for methods.

        PriceNameResolverInterface $priceNameResolver,
        ConcatedNameResolverInterface $channelPricingNameResolver,
        ChannelContextInterface $channelContext
    ): void {
        $this->beConstructedWith(
            $priceNameResolver,
            $channelPricingNameResolver,
            $channelContext
        );
    }

    function it_is_initializable(): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(HasPriceBetweenQueryBuilder::class);
    }

    function it_implements_query_builder_interface(): void
    {
        $this->shouldHaveType(QueryBuilderInterface::class);
    }

    function it_builds_query(
        PriceNameResolverInterface $priceNameResolver,
        ChannelContextInterface $channelContext,
        ChannelInterface $channel,
        ConcatedNameResolverInterface $channelPricingNameResolver
    ): void {
        $channel->getCode()->willReturn('web');

        $channelContext->getChannel()->willReturn($channel);

The method willReturn() does not exist on Sylius\Component\Channel\Model\ChannelInterface.

        $priceNameResolver->resolveMinPriceName()->willReturn('min_price');
        $priceNameResolver->resolveMaxPriceName()->willReturn('max_price');

        $channelPricingNameResolver->resolvePropertyName('web')->willReturn('web');

        $this->buildQuery([

The method buildQuery() does not exist on spec\BitBag\SyliusElasticsearchPlugin\QueryBuilder\HasPriceBetweenQueryBuilderSpec. Since you implemented __call, consider adding a @method annotation.

            'min_price' => '200',
            'max_price' => '1000',
        ])->shouldBeAnInstanceOf(Range::class);
    }
}