spec\BitBag\SyliusElasticsearchPlugin\Facet\AttributeFacetSpec

Complexity

Total Complexity

7

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	it_returns_bucket_label_from_config_for_select_attribute()	0	8	1
A	it_returns_human_readable_bucket_label_for_text_attribute()	0	7	1
A	it_is_initializable()	0	3	1
A	it_implements_facet_interface()	0	3	1
A	it_returns_terms_query()	0	6	1
A	let()	0	8	1
A	it_returns_terms_aggregation()	0	6	1

<?php

declare(strict_types=1);

namespace spec\BitBag\SyliusElasticsearchPlugin\Facet;

use BitBag\SyliusElasticsearchPlugin\Facet\AttributeFacet;
use BitBag\SyliusElasticsearchPlugin\Facet\FacetInterface;
use BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\ConcatedNameResolverInterface;
use Elastica\Aggregation\Terms;
use PhpSpec\ObjectBehavior;
use Prophecy\Argument;
use Sylius\Component\Attribute\Model\Attribute;
use Sylius\Component\Locale\Context\LocaleContextInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;

final class AttributeFacetSpec extends ObjectBehavior
{
    function let(

It is generally recommended to explicitly declare the visibility for methods.

        ConcatedNameResolverInterface $attributeNameResolver,
        RepositoryInterface $attributeRepository,
        LocaleContextInterface $localeContext
    ): void {
        $attributeNameResolver->resolvePropertyName('attribute_code')->willReturn('attribute_attribute_code');
        $localeContext->getLocaleCode()->willReturn('en_US');
        $this->beConstructedWith($attributeNameResolver, $attributeRepository, $localeContext, 'attribute_code');
    }

    function it_is_initializable(): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(AttributeFacet::class);
    }

    function it_implements_facet_interface(): void
    {
        $this->shouldHaveType(FacetInterface::class);
    }

    function it_returns_terms_aggregation(): void
    {
        $expectedAggregation = new Terms('');
        $expectedAggregation->setField('attribute_attribute_code.keyword');

        $this->getAggregation()->shouldBeLike($expectedAggregation);

The method getAggregation() does not exist on spec\BitBag\SyliusElasticsearchPlugin\Facet\AttributeFacetSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_returns_terms_query(): void
    {
        $selectedBuckets = ['selected_value'];
        $expectedQuery = new \Elastica\Query\Terms('attribute_attribute_code.keyword', $selectedBuckets);

        $this->getQuery($selectedBuckets)->shouldBeLike($expectedQuery);

The method getQuery() does not exist on spec\BitBag\SyliusElasticsearchPlugin\Facet\AttributeFacetSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_returns_bucket_label_from_config_for_select_attribute(RepositoryInterface $attributeRepository): void
    {
        $attribute = new Attribute();
        $attribute->setType('select');
        $attribute->setConfiguration(['choices' => ['value_id' => ['en_US' => 'Value Label']]]);
        $attributeRepository->findOneBy(['code' => 'attribute_code'])->willReturn($attribute);

        $this->getBucketLabel(['key' => 'value_id', 'doc_count' => 3])->shouldReturn('Value Label (3)');

The method getBucketLabel() does not exist on spec\BitBag\SyliusElasticsearchPlugin\Facet\AttributeFacetSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_returns_human_readable_bucket_label_for_text_attribute(RepositoryInterface $attributeRepository): void
    {
        $attribute = new Attribute();
        $attribute->setType('text');
        $attributeRepository->findOneBy(['code' => 'attribute_code'])->willReturn($attribute);

        $this->getBucketLabel(['key' => 'green_&_white', 'doc_count' => 3])->shouldReturn('Green & White (3)');
    }
}