spec\BitBag\SyliusElasticsearchPlugin\Finder\ProductAttributesFinderSpec

Complexity

Total Complexity

4

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	it_is_initializable()	0	3	1
A	let()	0	8	1
A	it_implements_product_attributes_finder_interface()	0	3	1
A	it_finds_by_taxon()	0	13	1

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on mikolaj.krol@bitbag.pl.
 */

declare(strict_types=1);

namespace spec\BitBag\SyliusElasticsearchPlugin\Finder;

use BitBag\SyliusElasticsearchPlugin\Finder\ProductAttributesFinder;
use BitBag\SyliusElasticsearchPlugin\Finder\ProductAttributesFinderInterface;
use BitBag\SyliusElasticsearchPlugin\QueryBuilder\QueryBuilderInterface;
use Elastica\Query\AbstractQuery;
use FOS\ElasticaBundle\Finder\FinderInterface;
use PhpSpec\ObjectBehavior;
use Sylius\Component\Core\Model\TaxonInterface;

final class ProductAttributesFinderSpec extends ObjectBehavior
{
    function let(

It is generally recommended to explicitly declare the visibility for methods.

        FinderInterface $attributesFinder,
        QueryBuilderInterface $attributesByTaxonQueryBuilder
    ): void {
        $this->beConstructedWith(
            $attributesFinder,
            $attributesByTaxonQueryBuilder,
            'taxons'
        );
    }

    function it_is_initializable(): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(ProductAttributesFinder::class);
    }

    function it_implements_product_attributes_finder_interface(): void
    {
        $this->shouldHaveType(ProductAttributesFinderInterface::class);
    }

    function it_finds_by_taxon(
        TaxonInterface $taxon,
        QueryBuilderInterface $attributesByTaxonQueryBuilder,
        FinderInterface $attributesFinder,
        AbstractQuery $query
    ): void {
        $taxon->getCode()->willReturn('book');

        $attributesByTaxonQueryBuilder->buildQuery(['taxons' => 'book'])->willReturn($query);

The method willReturn() does not exist on Elastica\Query\AbstractQuery.

        $attributesFinder->find($query)->willReturn([]);

        $this->findByTaxon($taxon)->shouldBeEqualTo([]);

The method findByTaxon() does not exist on spec\BitBag\SyliusElasticsearchPlugin\Finder\ProductAttributesFinderSpec. Since you implemented __call, consider adding a @method annotation.

    }
}