spec\BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\PriceNameResolverSpec

Complexity

Total Complexity

5

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	it_resolves_min_price_name()	0	3	1
A	it_is_initializable()	0	3	1
A	it_resolves_max_price_name()	0	3	1
A	let()	0	3	1
A	it_implements_price_name_resolver_interface()	0	3	1

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on mikolaj.krol@bitbag.pl.
 */

declare(strict_types=1);

namespace spec\BitBag\SyliusElasticsearchPlugin\PropertyNameResolver;

use BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\PriceNameResolver;
use BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\PriceNameResolverInterface;
use PhpSpec\ObjectBehavior;

final class PriceNameResolverSpec extends ObjectBehavior
{
    function let(): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->beConstructedWith('price');
    }

    function it_is_initializable(): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(PriceNameResolver::class);
    }

    function it_implements_price_name_resolver_interface(): void
    {
        $this->shouldHaveType(PriceNameResolverInterface::class);
    }

    function it_resolves_min_price_name(): void
    {
        $this->resolveMinPriceName()->shouldBeEqualTo('min_price');

The method resolveMinPriceName() does not exist on spec\BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\PriceNameResolverSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_resolves_max_price_name(): void
    {
        $this->resolveMaxPriceName()->shouldBeEqualTo('max_price');

The method resolveMaxPriceName() does not exist on spec\BitBag\SyliusElasticsearchPlugin\PropertyNameResolver\PriceNameResolverSpec. Since you implemented __call, consider adding a @method annotation.

    }
}