BitBag\SyliusCmsPlugin\Twig\Runtime\RenderProductPagesRuntime

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	4
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	renderProductPages()	0	14	2

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.io and write us
 * an email on mikolaj.krol@bitbag.pl.
 */

declare(strict_types=1);

namespace BitBag\SyliusCmsPlugin\Twig\Runtime;

use BitBag\SyliusCmsPlugin\Repository\PageRepositoryInterface;
use BitBag\SyliusCmsPlugin\Sorter\SectionsSorterInterface;
use Sylius\Component\Channel\Context\ChannelContextInterface;
use Sylius\Component\Core\Model\ProductInterface;
use Twig\Environment;

final class RenderProductPagesRuntime implements RenderProductPagesRuntimeInterface
{
    /** @var PageRepositoryInterface */
    private $pageRepository;

    /** @var ChannelContextInterface */
    private $channelContext;

    /** @var Environment */
    private $templatingEngine;

    /** @var SectionsSorterInterface */
    private $sectionsSorter;

    public function __construct(
        PageRepositoryInterface $pageRepository,
        ChannelContextInterface $channelContext,
        Environment $templatingEngine,
        SectionsSorterInterface $sectionsSorter
    ) {
        $this->pageRepository = $pageRepository;
        $this->channelContext = $channelContext;
        $this->templatingEngine = $templatingEngine;
        $this->sectionsSorter = $sectionsSorter;
    }

    public function renderProductPages(ProductInterface $product, string $sectionCode = null): string
    {
        $channelCode = $this->channelContext->getChannel()->getCode();

        if (null !== $sectionCode) {
            $pages = $this->pageRepository->findByProductAndSectionCode($product, $sectionCode, $channelCode);

The call to BitBag\SyliusCmsPlugin\Repository\PageRepositoryInterface::findByProductAndSectionCode() has too few arguments starting with date.

It seems like $channelCode can also be of type null; however, parameter $channelCode of BitBag\SyliusCmsPlugin\Repository\PageRepositoryInterface::findByProductAndSectionCode() does only seem to accept string, maybe add an additional type check?

        } else {
            $pages = $this->pageRepository->findByProduct($product, $channelCode);

It seems like $channelCode can also be of type null; however, parameter $channelCode of BitBag\SyliusCmsPlugin\Repository\PageRepositoryInterface::findByProduct() does only seem to accept string, maybe add an additional type check?

The call to BitBag\SyliusCmsPlugin\Repository\PageRepositoryInterface::findByProduct() has too few arguments starting with date.

        }

        $data = $this->sectionsSorter->sortBySections($pages);

        return $this->templatingEngine->render('@BitBagSyliusCmsPlugin/Shop/Product/_pagesBySection.html.twig', [
            'data' => $data,
        ]);
    }
}