BitBagCommerce / SyliusCmsPlugin

src/Resolver/MediaResourceResolver.php

<?php

/*
 * This file has been created by developers from BitBag.
 * Feel free to contact us once you face any issues or want to start
 * another great project.
 * You can find more information about us on https://bitbag.shop and write us
 * an email on mikolaj.krol@bitbag.pl.
 */

declare(strict_types=1);

namespace BitBag\SyliusCmsPlugin\Resolver;

use BitBag\SyliusCmsPlugin\Entity\MediaInterface;
use BitBag\SyliusCmsPlugin\Repository\MediaRepositoryInterface;
use Psr\Log\LoggerInterface;
use Sylius\Component\Channel\Context\ChannelContextInterface;

final class MediaResourceResolver implements MediaResourceResolverInterface
{
    /** @var MediaRepositoryInterface */
    private $mediaRepository;

    /** @var ChannelContextInterface */
    private $channelContext;

    /** @var LoggerInterface */
    private $logger;

    public function __construct(
        MediaRepositoryInterface $mediaRepository,
        ChannelContextInterface $channelContext,
        LoggerInterface $logger
    ) {
        $this->mediaRepository = $mediaRepository;
        $this->channelContext = $channelContext;
        $this->logger = $logger;
    }

    public function findOrLog(string $code): ?MediaInterface
    {
        $media = $this->mediaRepository->findOneEnabledByCode($code, $this->channelContext->getChannel()->getCode());

It seems like $this->channelContext->getChannel()->getCode() can also be of type null; however, parameter $localeCode of BitBag\SyliusCmsPlugin\Repository\MediaRepositoryInterface::findOneEnabledByCode() does only seem to accept string, maybe add an additional type check?

        if (false === $media instanceof MediaInterface) {
            $this->logger->warning(sprintf(
                'Media with "%s" code was not found in the database.',
                $code
            ));

            return null;
        }

        return $media;
    }
}