BitBag\SyliusCmsPlugin\Repository\FrequentlyAskedQuestionRepository

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	findEnabledOrderedByPosition()	0	13	1
A	createListQueryBuilder()	0	6	1
A	findOneEnabledByCode()	0	8	1

<?php

/*
 * This file was created by developers working at BitBag
 * Do you need more information about us and what we do? Visit our https://bitbag.io website!
 * We are hiring developers from all over the world. Join us and start your new, exciting adventure and become part of us: https://bitbag.io/career
*/

declare(strict_types=1);

namespace BitBag\SyliusCmsPlugin\Repository;

use BitBag\SyliusCmsPlugin\Entity\FrequentlyAskedQuestionInterface;
use Doctrine\ORM\QueryBuilder;
use Sylius\Bundle\ResourceBundle\Doctrine\ORM\EntityRepository;

class FrequentlyAskedQuestionRepository extends EntityRepository implements FrequentlyAskedQuestionRepositoryInterface
{
    public function createListQueryBuilder(string $localeCode): QueryBuilder
    {
        return $this->createQueryBuilder('o')
            ->addSelect('translation')
            ->leftJoin('o.translations', 'translation', 'WITH', 'translation.locale = :localeCode')
            ->setParameter('localeCode', $localeCode)
        ;
    }

    public function findEnabledOrderedByPosition(string $localeCode, string $channelCode): array
    {
        return $this->createQueryBuilder('o')

The expression return $this->createQueryBuilder('o')->leftJoin('o.translations', 'translation')->innerJoin('o.channels', 'channels')->where('translation.locale = :localeCode')->andWhere('o.enabled = true')->andWhere('channels.code = :channelCode')->orderBy('o.position', 'ASC')->setParameter('localeCode', $localeCode)->setParameter('channelCode', $channelCode)->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

            ->leftJoin('o.translations', 'translation')
            ->innerJoin('o.channels', 'channels')
            ->where('translation.locale = :localeCode')
            ->andWhere('o.enabled = true')
            ->andWhere('channels.code = :channelCode')
            ->orderBy('o.position', 'ASC')
            ->setParameter('localeCode', $localeCode)
            ->setParameter('channelCode', $channelCode)
            ->getQuery()
            ->getResult()
        ;
    }

    public function findOneEnabledByCode(string $code): ?FrequentlyAskedQuestionInterface
    {
        return $this->createQueryBuilder('o')

The expression return $this->createQueryBuilder('o')->where('o.code = :code')->andWhere('o.enabled = true')->setParameter('code', $code)->getQuery()->getOneOrNullResult() could return the type integer which is incompatible with the type-hinted return BitBag\SyliusCmsPlugin\Entity\FrequentlyAskedQuestionInterface|null. Consider adding an additional type-check to rule them out.

            ->where('o.code = :code')
            ->andWhere('o.enabled = true')
            ->setParameter('code', $code)
            ->getQuery()
            ->getOneOrNullResult()
        ;
    }
}