BitBag\SyliusCmsPlugin\Assigner\SectionsAssigner

Complexity

Total Complexity

3

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	assign()	0	8	2
A	__construct()	0	3	1

<?php

/*
 * This file was created by developers working at BitBag
 * Do you need more information about us and what we do? Visit our https://bitbag.io website!
 * We are hiring developers from all over the world. Join us and start your new, exciting adventure and become part of us: https://bitbag.io/career
*/

declare(strict_types=1);

namespace BitBag\SyliusCmsPlugin\Assigner;

use BitBag\SyliusCmsPlugin\Entity\SectionableInterface;
use BitBag\SyliusCmsPlugin\Entity\SectionInterface;
use BitBag\SyliusCmsPlugin\Repository\SectionRepositoryInterface;
use Webmozart\Assert\Assert;

final class SectionsAssigner implements SectionsAssignerInterface
{
    /** @var SectionRepositoryInterface */
    private $sectionRepository;

    public function __construct(SectionRepositoryInterface $sectionRepository)
    {
        $this->sectionRepository = $sectionRepository;
    }

    public function assign(SectionableInterface $sectionsAware, array $sectionsCodes): void
    {
        foreach ($sectionsCodes as $sectionCode) {
            /** @var SectionInterface|null $section */
            $section = $this->sectionRepository->findOneBy(['code' => $sectionCode]);

            Assert::notNull($section, sprintf('Section with %s code not found.', $sectionCode));
            $sectionsAware->addSection($section);

It seems like $section can also be of type null; however, parameter $section of BitBag\SyliusCmsPlugin\Entity\SectionableInterface::addSection() does only seem to accept BitBag\SyliusCmsPlugin\Entity\SectionInterface, maybe add an additional type check?

        }
    }
}