ApiError::getId() - Code Metrics - Inspection of "Merge pull request #3 from afk11/project-tidyup" - Bit-Wasp/stratum-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c78d7...6647db )

by thomas

created 2016-05-18 01:11 UTC

ApiError::getId() A

↳ Parent: ApiError

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

namespace BitWasp\Stratum\Exceptions;

class ApiError extends \Exception
{
    /**
     * @var string
     */
    private $id;

    /**
     * @param string $id
     * @param int $error
     */
    public function __construct($id, $error)
    {
        $this->id = $id;
        parent::__construct($error);
    }

    /**
     * @return string
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return string
     */
    public function write()
    {
        return json_encode([
            'id' => $this->id,
            'error' => parent::getMessage()
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        ]) . "\n";
    }
}


1		<?php
2
3		namespace BitWasp\Stratum\Exceptions;
4
5		class ApiError extends \Exception
6		{
7		/**
8		* @var string
9		*/
10		private $id;
11
12		/**
13		* @param string $id
14		* @param int $error
15		*/
16	1	public function __construct($id, $error)
17		{
18	1	$this->id = $id;
19	1	parent::__construct($error);
20	1	}
21
22		/**
23		* @return string
24		*/
25	1	public function getId()
26		{
27	1	return $this->id;
28		}
29
30		/**
31		* @return string
32		*/
33	1	public function write()
34		{
35	1	return json_encode([
36	1	'id' => $this->id,
37	1	'error' => parent::getMessage()
		0 ignored issues – show Comprehensibility Bug introduced 2016-05-17 04:25 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getMessage()` instead of `write()`). Are you sure this is correct? If so, you might want to change this to `$this->getMessage()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
38	1	]) . "\n";
39		}
40		}
41

Bit-Wasp / stratum-php

Push — master ( 5c78d7...6647db )

ApiError::getId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like