RequestFactory::response() - Code Metrics - Inspection of "Large refactoring of the project" - Bit-Wasp/stratum-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by thomas

created 2016-05-17 17:55 UTC

RequestFactory::response() B

↳ Parent: RequestFactory

Complexity

Conditions	7
Paths	9

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	7

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	20
ccs	12
cts	12
cp	1
rs	8.2222
cc	7
eloc	12
nc	9
nop	1
crap	7

<?php

namespace BitWasp\Stratum\Request;

use BitWasp\Stratum\Exceptions\ApiError;

class RequestFactory
{
    /**
     * @var array
     */
    private $nonces = [];

    /**
     * @param $method
     * @param array $params
     * @param bool $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return Request
     */
    public function create($method, $params = array())
    {
        do {
            $id = mt_rand(0, PHP_INT_MAX);
        } while (in_array($id, $this->nonces));

        return new Request($id, $method, $params);
    }

    /**
     * @param $string
     * @return Response|Request
     * @throws \Exception
     */
    public function response($string)
    {
        $decoded = json_decode(trim($string), true);

        if (json_last_error() === JSON_ERROR_NONE) {
            $id = isset($decoded['id']) ? $decoded['id'] : null;

            if (isset($decoded['error'])) {
                throw new ApiError($id, $decoded['error']);
            } elseif (isset($decoded['method']) && isset($decoded['params'])) {
                return new Request($id, $decoded['method'], $decoded['params']);
            } elseif (isset($decoded['result'])) {
                return new Response($id, $decoded['result']);
            }

            throw new \Exception('Response missing error/params/result');
        }

        throw new \Exception('Invalid JSON');
    }
}


1		<?php
2
3		namespace BitWasp\Stratum\Request;
4
5		use BitWasp\Stratum\Exceptions\ApiError;
6
7		class RequestFactory
8		{
9		/**
10		* @var array
11		*/
12		private $nonces = [];
13
14		/**
15		* @param $method
16		* @param array $params
17		* @param bool $id
		0 ignored issues – show Bug introduced 2016-05-17 04:25 UTC by Report Bug Copy Issue Report There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
18		* @return Request
19		*/
20	3	public function create($method, $params = array())
21		{
22		do {
23	3	$id = mt_rand(0, PHP_INT_MAX);
24	3	} while (in_array($id, $this->nonces));
25
26	3	return new Request($id, $method, $params);
27		}
28
29		/**
30		* @param $string
31		* @return Response\|Request
32		* @throws \Exception
33		*/
34	20	public function response($string)
35		{
36	20	$decoded = json_decode(trim($string), true);
37
38	20	if (json_last_error() === JSON_ERROR_NONE) {
39	19	$id = isset($decoded['id']) ? $decoded['id'] : null;
40
41	19	if (isset($decoded['error'])) {
42	1	throw new ApiError($id, $decoded['error']);
43	18	} elseif (isset($decoded['method']) && isset($decoded['params'])) {
44	14	return new Request($id, $decoded['method'], $decoded['params']);
45	5	} elseif (isset($decoded['result'])) {
46	4	return new Response($id, $decoded['result']);
47		}
48
49	1	throw new \Exception('Response missing error/params/result');
50		}
51
52	1	throw new \Exception('Invalid JSON');
53		}
54		}
55

Bit-Wasp / stratum-php

Pull Request — master (#3)

RequestFactory::response() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like