Process::__construct() - Code Metrics - Inspection of "Merge pull request #3 from Bit-Wasp/bump2" - Bit-Wasp/pinentry - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c5e2a6...55323d )

by thomas

created 2018-12-22 16:28 UTC

Process::__construct() A

↳ Parent: Process

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3.0261

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	2
nop	2
dl	0
loc	10
ccs	6
cts	7
cp	0.8571
crap	3.0261
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace BitWasp\PinEntry\Process;

use BitWasp\PinEntry\Exception;

class Process implements ProcessInterface
{
    /**
     * @var resource A 'process' resource
     */
    private $process;

    /**
     * @var IPC -
     */
    private $ipc;

    /**
     * @var bool
     */
    private $running = true;

    public function __construct(string $executable, array $overrideDescriptors = [])
    {
        $pipes = [];
        $process = proc_open($executable, IPC::buildDescriptors($overrideDescriptors), $pipes);
        if (!(is_resource($process) && get_resource_type($process) === "process")) {
            throw new Exception\PinEntryException("Failed to start process");
        }

        $this->ipc = new IPC($pipes);
        $this->process = $process;
    }

    public function __destruct()
    {
        $this->close();
    }

    public function close(): bool
    {
        if ($this->running) {
            $this->stopRunning();
        }
        return true;
    }

    /**
     * Called during shutdown routine. Per documentation,
     * file handles should be closed before we call proc_close
     */
    private function stopRunning()
    {
        $this->ipc->close();
        proc_close($this->process);
        $this->running = false;
    }

    public function getStatus(): array
    {
        $status = proc_get_status($this->process);
        if (false === $status) {
            throw new \RuntimeException("Failed to get status information about process");
        }
        return $status;
    }

    public function send(string $data)
    {
        $this->ipc->send($data);
    }

    public function recv(): string
    {
        return $this->ipc->readStdOut();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace BitWasp\PinEntry\Process;
6
7		use BitWasp\PinEntry\Exception;
8
9		class Process implements ProcessInterface
10		{
11		/**
12		* @var resource A 'process' resource
13		*/
14		private $process;
15
16		/**
17		* @var IPC -
18		*/
19		private $ipc;
20
21		/**
22		* @var bool
23		*/
24		private $running = true;
25
26	1	public function __construct(string $executable, array $overrideDescriptors = [])
27		{
28	1	$pipes = [];
29	1	$process = proc_open($executable, IPC::buildDescriptors($overrideDescriptors), $pipes);
30	1	if (!(is_resource($process) && get_resource_type($process) === "process")) {
31		throw new Exception\PinEntryException("Failed to start process");
32		}
33
34	1	$this->ipc = new IPC($pipes);
35	1	$this->process = $process;
36	1	}
37
38	1	public function __destruct()
39		{
40	1	$this->close();
41	1	}
42
43	1	public function close(): bool
44		{
45	1	if ($this->running) {
46	1	$this->stopRunning();
47		}
48	1	return true;
49		}
50
51		/**
52		* Called during shutdown routine. Per documentation,
53		* file handles should be closed before we call proc_close
54		*/
55	1	private function stopRunning()
56		{
57	1	$this->ipc->close();
58	1	proc_close($this->process);
59	1	$this->running = false;
60	1	}
61
62	1	public function getStatus(): array
63		{
64	1	$status = proc_get_status($this->process);
65	1	if (false === $status) {
66		throw new \RuntimeException("Failed to get status information about process");
67		}
68	1	return $status;
69		}
70
71		public function send(string $data)
72		{
73		$this->ipc->send($data);
74		}
75
76		public function recv(): string
77		{
78		return $this->ipc->readStdOut();
79		}
80		}
81

Bit-Wasp / pinentry

Push — master ( c5e2a6...55323d )

Process::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like