ByteString::write() - Code Metrics - Inspection of "Byte string perf" - Bit-Wasp/buffertools-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#78)

by thomas

created 2018-11-10 20:01 UTC

ByteString::write() A

↳ Parent: ByteString

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	6
cts	6
cp	1
rs	9.8666
c	0
b	0
f	0
cc	3
nc	3
nop	1
crap	3

<?php

declare(strict_types=1);

namespace BitWasp\Buffertools\Types;

use BitWasp\Buffertools\Buffer;
use BitWasp\Buffertools\BufferInterface;
use BitWasp\Buffertools\ByteOrder;
use BitWasp\Buffertools\Parser;

class ByteString extends AbstractType
{
    /**
     * @var int|string
     */
    private $length;

    /**
     * @param int           $length
     * @param int           $byteOrder
     */
    public function __construct(int $length, int $byteOrder = ByteOrder::BE)
    {
        $this->length = $length;
        parent::__construct($byteOrder);
    }

    /**
     * @param Buffer $string
     * @return string
     * @throws \Exception
     */
    public function write($string): string
    {
        if (!($string instanceof Buffer)) {
            throw new \InvalidArgumentException('FixedLengthString::write() must be passed a Buffer');
        }

        $data = new Buffer($string->getBinary(), $this->length);
        if (!$this->isBigEndian()) {
            $data = $data->flip();
        }
        return $data->getBinary();
    }

    /**
     * @param Parser $parser
     * @return BufferInterface
     * @throws \BitWasp\Buffertools\Exceptions\ParserOutOfRange
     */
    public function read(Parser $parser): BufferInterface
    {
        $data = $parser->readBytes($this->length);
        if (!$this->isBigEndian()) {
            $data = $data->flip();
        }

        return $data;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace BitWasp\Buffertools\Types;
6
7		use BitWasp\Buffertools\Buffer;
8		use BitWasp\Buffertools\BufferInterface;
9		use BitWasp\Buffertools\ByteOrder;
10		use BitWasp\Buffertools\Parser;
11
12		class ByteString extends AbstractType
13		{
14		/**
15		* @var int\|string
16		*/
17		private $length;
18
19		/**
20		* @param int $length
21		* @param int $byteOrder
22		*/
23	14	public function __construct(int $length, int $byteOrder = ByteOrder::BE)
24		{
25	14	$this->length = $length;
26	14	parent::__construct($byteOrder);
27	14	}
28
29		/**
30		* @param Buffer $string
31		* @return string
32		* @throws \Exception
33	12	*/
34		public function write($string): string
35	12	{
36	12	if (!($string instanceof Buffer)) {
37	12	throw new \InvalidArgumentException('FixedLengthString::write() must be passed a Buffer');
38	12	}
39	12
40		$data = new Buffer($string->getBinary(), $this->length);
41		if (!$this->isBigEndian()) {
42	12	$data = $data->flip();
43		}
44		return $data->getBinary();
45		}
46
47		/**
48		* @param Parser $parser
49		* @return BufferInterface
50	12	* @throws \BitWasp\Buffertools\Exceptions\ParserOutOfRange
51		*/
52	12	public function read(Parser $parser): BufferInterface
53		{
54		$data = $parser->readBytes($this->length);
55		if (!$this->isBigEndian()) {
56	12	$data = $data->flip();
57	6	}
58	12
59		return $data;
60	12	}
61		}
62

Bit-Wasp / buffertools-php

Pull Request — master (#78)

ByteString::write() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like