Validator::checkSignatures() - Code Metrics - Inspection of "Merge pull request #339 from afk11/param-flags" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e13b09...cea89c )

by thomas

created 2016-07-05 14:54 UTC

Validator::checkSignatures() A

↳ Parent: Validator

Complexity

Conditions	4
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	7
c	1
b	0
f	0
nc	4
nop	3
dl	0
loc	13
ccs	0
cts	8
cp	0
crap	20
rs	9.2

<?php

namespace BitWasp\Bitcoin\Transaction;

use BitWasp\Bitcoin\Script\Consensus\ConsensusInterface;

class Validator implements ValidatorInterface
{
    /**
     * @var TransactionInterface
     */
    private $transaction;

    /**
     * Validator constructor.
     * @param TransactionInterface $transaction
     */
    public function __construct(TransactionInterface $transaction)
    {
        $this->transaction = $transaction;
    }

    /**
     * @param ConsensusInterface $consensus
     * @param int $flags
     * @param int $nInput
     * @param TransactionOutputInterface $output
     * @return bool
     */
    public function checkSignature(ConsensusInterface $consensus, $flags, $nInput, TransactionOutputInterface $output)
    {
        $witnesses = $this->transaction->getWitnesses();
        $witness = isset($witnesses[$nInput]) ? $witnesses[$nInput] : null;
        return $consensus->verify($this->transaction, $output->getScript(), $flags, $nInput, $output->getValue(), $witness);
    }

    /**
     * @param ConsensusInterface $consensus
     * @param int $flags
     * @param TransactionOutputInterface[] $outputs
     * @return bool
     */
    public function checkSignatures(ConsensusInterface $consensus, $flags, array $outputs)
    {
        if (count($this->transaction->getInputs()) !== count($outputs)) {
            throw new \InvalidArgumentException('Incorrect scriptPubKey count');
        }

        $result = true;
        foreach ($outputs as $i => $txOut) {
            $result = $result && $this->checkSignature($consensus, $flags, $i, $txOut);
        }

        return $result;
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Transaction;
4
5		use BitWasp\Bitcoin\Script\Consensus\ConsensusInterface;
6
7		class Validator implements ValidatorInterface
8		{
9		/**
10		* @var TransactionInterface
11		*/
12		private $transaction;
13
14		/**
15		* Validator constructor.
16		* @param TransactionInterface $transaction
17		*/
18	27	public function __construct(TransactionInterface $transaction)
19		{
20	27	$this->transaction = $transaction;
21	27	}
22
23		/**
24		* @param ConsensusInterface $consensus
25		* @param int $flags
26		* @param int $nInput
27		* @param TransactionOutputInterface $output
28		* @return bool
29		*/
30	27	public function checkSignature(ConsensusInterface $consensus, $flags, $nInput, TransactionOutputInterface $output)
31		{
32	27	$witnesses = $this->transaction->getWitnesses();
33	27	$witness = isset($witnesses[$nInput]) ? $witnesses[$nInput] : null;
34	27	return $consensus->verify($this->transaction, $output->getScript(), $flags, $nInput, $output->getValue(), $witness);
35		}
36
37		/**
38		* @param ConsensusInterface $consensus
39		* @param int $flags
40		* @param TransactionOutputInterface[] $outputs
41		* @return bool
42		*/
43		public function checkSignatures(ConsensusInterface $consensus, $flags, array $outputs)
44		{
45		if (count($this->transaction->getInputs()) !== count($outputs)) {
46		throw new \InvalidArgumentException('Incorrect scriptPubKey count');
47		}
48
49		$result = true;
50		foreach ($outputs as $i => $txOut) {
51		$result = $result && $this->checkSignature($consensus, $flags, $i, $txOut);
52		}
53
54		return $result;
55		}
56		}
57

Bit-Wasp / bitcoin-php

Push — master ( e13b09...cea89c )

Validator::checkSignatures() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like