CompactSignature::getS() - Code Metrics - Inspection of "SignatureInterface::getR and getS now return GMP i..." - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#316)

by thomas

created 2016-06-17 16:38 UTC

CompactSignature::getS() A

↳ Parent: CompactSignature

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php


namespace BitWasp\Bitcoin\Crypto\EcAdapter\Impl\PhpEcc\Signature;

use BitWasp\Bitcoin\Crypto\EcAdapter\Impl\PhpEcc\Adapter\EcAdapter;
use BitWasp\Bitcoin\Crypto\EcAdapter\Impl\PhpEcc\Serializer\Signature\CompactSignatureSerializer;

class CompactSignature extends Signature implements CompactSignatureInterface
{
    /**
     * @var EcAdapter
     */
    private $ecAdapter;


    /**
     * @var int|string
     */
    private $recid;

    /**
     * @var bool
     */
    private $compressed;

    /**
     * @param EcAdapter $adapter
     * @param \GMP $r
     * @param \GMP $s
     * @param int $recid
     * @param bool $compressed
     */
    public function __construct(EcAdapter $adapter, \GMP $r, \GMP $s, $recid, $compressed)
    {
        if (!is_bool($compressed)) {
            throw new \InvalidArgumentException('CompactSignature: $compressed must be a boolean');
        }

        $this->ecAdapter = $adapter;
        $this->recid = $recid;
        $this->compressed = $compressed;
        parent::__construct($adapter, $r, $s);
    }

    /**
     * @return Signature
     */
    public function convert()
    {
        return new Signature($this->ecAdapter, $this->getR(), $this->getS());
    }

    /**
     * @return int
     */
    public function getRecoveryId()
    {
        return $this->recid;
    }

    /**
     * @return bool
     */
    public function isCompressed()
    {
        return $this->compressed;
    }

    /**
     * @return int
     */
    public function getFlags()
    {
        return $this->getRecoveryId() + 27 + ($this->isCompressed() ? 4 : 0);
    }

    /**
     * @return \BitWasp\Buffertools\BufferInterface
     */
    public function getBuffer()
    {
        return (new CompactSignatureSerializer($this->ecAdapter))->serialize($this);
    }
}


1		<?php
2
3
4		namespace BitWasp\Bitcoin\Crypto\EcAdapter\Impl\PhpEcc\Signature;
5
6		use BitWasp\Bitcoin\Crypto\EcAdapter\Impl\PhpEcc\Adapter\EcAdapter;
7		use BitWasp\Bitcoin\Crypto\EcAdapter\Impl\PhpEcc\Serializer\Signature\CompactSignatureSerializer;
8
9		class CompactSignature extends Signature implements CompactSignatureInterface
10		{
11		/**
12		* @var EcAdapter
13		*/
14		private $ecAdapter;
		0 ignored issues – show Comprehensibility introduced 2016-06-17 17:50 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
15
16		/**
17		* @var int\|string
18		*/
19		private $recid;
20
21		/**
22		* @var bool
23		*/
24		private $compressed;
25
26		/**
27		* @param EcAdapter $adapter
28		* @param \GMP $r
29		* @param \GMP $s
30		* @param int $recid
31		* @param bool $compressed
32		*/
33		public function __construct(EcAdapter $adapter, \GMP $r, \GMP $s, $recid, $compressed)
34		{
35		if (!is_bool($compressed)) {
36		throw new \InvalidArgumentException('CompactSignature: $compressed must be a boolean');
37		}
38
39		$this->ecAdapter = $adapter;
40		$this->recid = $recid;
41		$this->compressed = $compressed;
42		parent::__construct($adapter, $r, $s);
43		}
44	19
45		/**
46	19	* @return Signature
47		*/
48		public function convert()
49		{
50	19	return new Signature($this->ecAdapter, $this->getR(), $this->getS());
51	19	}
52	19
53	19	/**
54	19	* @return int
55	19	*/
56		public function getRecoveryId()
57		{
58		return $this->recid;
59		}
60	17
61		/**
62	17	* @return bool
63		*/
64		public function isCompressed()
65		{
66		return $this->compressed;
67		}
68	17
69		/**
70	17	* @return int
71		*/
72		public function getFlags()
73		{
74		return $this->getRecoveryId() + 27 + ($this->isCompressed() ? 4 : 0);
75		}
76	17
77		/**
78	17	* @return \BitWasp\Buffertools\BufferInterface
79		*/
80		public function getBuffer()
81		{
82		return (new CompactSignatureSerializer($this->ecAdapter))->serialize($this);
83		}
84		}
85

Bit-Wasp / bitcoin-php

Pull Request — master (#316)

CompactSignature::getS() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like