BitWasp\Bitcoin\Script\Path\LogicOpNode

Complexity

Total Complexity

15

Size/Duplication

Total Lines	102
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	flags()	0	17	6
A	isRoot()	0	4	1
A	getParent()	0	4	1
A	getValue()	0	4	1
A	getChild()	0	7	2
A	split()	0	12	3

<?php

namespace BitWasp\Bitcoin\Script\Path;

class LogicOpNode
{

    /**
     * @var LogicOpNode|null
     */
    private $parent;

    /**
     * @var bool
     */
    private $value;

    /**
     * @var LogicOpNode[]
     */
    private $children = [];

    /**
     * MASTNode constructor.
     * @param self|null $parent
     * @param bool|null $value
     */
    public function __construct(self $parent = null, $value = null)
    {
        $this->parent = $parent;

It seems like $parent can also be of type object<self>. However, the property $parent is declared as type object<BitWasp\Bitcoin\Script\Path\LogicOpNode>|null. Maybe add an additional type check?

        $this->value = $value;
    }

    /**
     * @return array
     */
    public function flags()
    {
        if (count($this->children) > 0) {
            $values = [];
            foreach ($this->children as $k => $child) {
                $flags = $child->flags();
                foreach ($flags as $branch) {
                    $values[] = array_merge($this->isRoot() ? [] : [$this->value], is_array($branch) ? $branch : [$branch]);
                }
            }

            return $values;
        } else {
            $value = $this->value;
            return [$value];
        }
    }

    /**
     * @return bool
     */
    public function isRoot()
    {
        return $this->parent == null;
    }

    /**
     * @return LogicOpNode|null
     */
    public function getParent()
    {
        return $this->parent;
    }

    /**
     * @return bool|null
     */
    public function getValue()
    {
        return $this->value;
    }

    /**
     * @param $value
     * @return LogicOpNode
     */
    public function getChild($value)
    {
        if (!isset($this->children[$value])) {
            throw new \RuntimeException("Child not found");
        }
        return $this->children[$value];
    }

    /**
     * @return array
     */
    public function split()
    {
        if (count($this->children) > 0) {
            throw new \RuntimeException("Sanity check - dont split twice");
        }

        $children = [new LogicOpNode($this, false), new LogicOpNode($this, true)];

$this is of type this<BitWasp\Bitcoin\Script\Path\LogicOpNode>, but the function expects a null|object<self>.

        foreach ($children as $child) {
            $this->children[] = $child;
        }
        return $children;
    }
}