Validator::checkSignatures() - Code Metrics - Inspection of "Merge pull request #256 from afk11/bump-buffertool..." - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( af1b10...bf42d9 )

by thomas

created 2016-02-05 21:07 UTC

Validator::checkSignatures() A

↳ Parent: Validator

Complexity

Conditions	4
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	10.75

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
c	3
b	0
f	1
dl	0
loc	13
ccs	2
cts	8
cp	0.25
rs	9.2
cc	4
eloc	7
nc	4
nop	2
crap	10.75

<?php

namespace BitWasp\Bitcoin\Transaction;

use BitWasp\Bitcoin\Script\Consensus\ConsensusInterface;
use BitWasp\Bitcoin\Script\ScriptInterface;

class Validator implements ValidatorInterface
{
    /**
     * @var TransactionInterface
     */
    private $transaction;

    /**
     * Validator constructor.
     * @param TransactionInterface $transaction
     */
    public function __construct(TransactionInterface $transaction)
    {
        $this->transaction = $transaction;
    }

    /**
     * @param ConsensusInterface $consensus
     * @param int $nInput
     * @param TransactionOutputInterface $output
     * @return bool
     */
    public function checkSignature(ConsensusInterface $consensus, $nInput, TransactionOutputInterface $output)
    {
        $witnesses = $this->transaction->getWitnesses();
        $witness = isset($witnesses[$nInput]) ? $witnesses[$nInput] : null;
        return $consensus->verify($this->transaction, $output->getScript(), $nInput, $output->getValue(), $witness);
    }

    /**
     * @param ConsensusInterface $consensus
     * @param TransactionOutputInterface[] $outputs
     * @return bool
     */
    public function checkSignatures(ConsensusInterface $consensus, array $outputs)
    {
        if (count($this->transaction->getInputs()) !== count($outputs)) {
            throw new \InvalidArgumentException('Incorrect scriptPubKey count');
        }

        $result = true;
        foreach ($outputs as $i => $txOut) {
            $result = $result && $this->checkSignature($consensus, $i, $txOut);
        }

        return $result;
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Transaction;
4
5		use BitWasp\Bitcoin\Script\Consensus\ConsensusInterface;
6		use BitWasp\Bitcoin\Script\ScriptInterface;
7
8		class Validator implements ValidatorInterface
9		{
10		/**
11		* @var TransactionInterface
12		*/
13		private $transaction;
14
15		/**
16		* Validator constructor.
17		* @param TransactionInterface $transaction
18		*/
19	54	public function __construct(TransactionInterface $transaction)
20		{
21	54	$this->transaction = $transaction;
22	54	}
23
24		/**
25		* @param ConsensusInterface $consensus
26		* @param int $nInput
27		* @param TransactionOutputInterface $output
28		* @return bool
29		*/
30	54	public function checkSignature(ConsensusInterface $consensus, $nInput, TransactionOutputInterface $output)
31		{
32	54	$witnesses = $this->transaction->getWitnesses();
33	54	$witness = isset($witnesses[$nInput]) ? $witnesses[$nInput] : null;
34	54	return $consensus->verify($this->transaction, $output->getScript(), $nInput, $output->getValue(), $witness);
35		}
36
37		/**
38		* @param ConsensusInterface $consensus
39		* @param TransactionOutputInterface[] $outputs
40		* @return bool
41		*/
42	54	public function checkSignatures(ConsensusInterface $consensus, array $outputs)
43		{
44		if (count($this->transaction->getInputs()) !== count($outputs)) {
45		throw new \InvalidArgumentException('Incorrect scriptPubKey count');
46		}
47
48	54	$result = true;
49		foreach ($outputs as $i => $txOut) {
50		$result = $result && $this->checkSignature($consensus, $i, $txOut);
51		}
52
53		return $result;
54		}
55		}
56

Bit-Wasp / bitcoin-php

Push — master ( af1b10...bf42d9 )

Validator::checkSignatures() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like