Validator::checkSignatures() - Code Metrics - Inspection of "Add script tests from bitcoin core" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#332)

by thomas

created 2016-07-01 03:41 UTC

Validator::checkSignatures() A

↳ Parent: Validator

Complexity

Conditions	4
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4.0312

Importance

Changes

Metric	Value
cc	4
eloc	7
c	0
b	0
f	0
nc	4
nop	2
dl	0
loc	13
ccs	7
cts	8
cp	0.875
crap	4.0312
rs	9.2

<?php

namespace BitWasp\Bitcoin\Transaction;

use BitWasp\Bitcoin\Script\Consensus\ConsensusInterface;

class Validator implements ValidatorInterface
{
    /**
     * @var TransactionInterface
     */
    private $transaction;

    /**
     * Validator constructor.
     * @param TransactionInterface $transaction
     */
    public function __construct(TransactionInterface $transaction)
    {
        $this->transaction = $transaction;
    }

    /**
     * @param ConsensusInterface $consensus
     * @param int $nInput
     * @param TransactionOutputInterface $output
     * @return bool
     */
    public function checkSignature(ConsensusInterface $consensus, $nInput, TransactionOutputInterface $output)
    {
        $witnesses = $this->transaction->getWitnesses();
        $witness = isset($witnesses[$nInput]) ? $witnesses[$nInput] : null;
        return $consensus->verify($this->transaction, $output->getScript(), $nInput, $output->getValue(), $witness);
    }

    /**
     * @param ConsensusInterface $consensus
     * @param TransactionOutputInterface[] $outputs
     * @return bool
     */
    public function checkSignatures(ConsensusInterface $consensus, array $outputs)
    {
        if (count($this->transaction->getInputs()) !== count($outputs)) {
            throw new \InvalidArgumentException('Incorrect scriptPubKey count');
        }

        $result = true;
        foreach ($outputs as $i => $txOut) {
            $result = $result && $this->checkSignature($consensus, $i, $txOut);
        }

        return $result;
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Transaction;
4
5		use BitWasp\Bitcoin\Script\Consensus\ConsensusInterface;
6
7		class Validator implements ValidatorInterface
8		{
9		/**
10		* @var TransactionInterface
11		*/
12		private $transaction;
13
14		/**
15		* Validator constructor.
16		* @param TransactionInterface $transaction
17		*/
18	75	public function __construct(TransactionInterface $transaction)
19		{
20	75	$this->transaction = $transaction;
21	75	}
22
23		/**
24		* @param ConsensusInterface $consensus
25		* @param int $nInput
26		* @param TransactionOutputInterface $output
27		* @return bool
28		*/
29	75	public function checkSignature(ConsensusInterface $consensus, $nInput, TransactionOutputInterface $output)
30		{
31	75	$witnesses = $this->transaction->getWitnesses();
32	75	$witness = isset($witnesses[$nInput]) ? $witnesses[$nInput] : null;
33	75	return $consensus->verify($this->transaction, $output->getScript(), $nInput, $output->getValue(), $witness);
34		}
35
36		/**
37		* @param ConsensusInterface $consensus
38		* @param TransactionOutputInterface[] $outputs
39		* @return bool
40		*/
41	66	public function checkSignatures(ConsensusInterface $consensus, array $outputs)
42		{
43	48	if (count($this->transaction->getInputs()) !== count($outputs)) {
44		throw new \InvalidArgumentException('Incorrect scriptPubKey count');
45		}
46
47	48	$result = true;
48	66	foreach ($outputs as $i => $txOut) {
49	48	$result = $result && $this->checkSignature($consensus, $i, $txOut);
50	32	}
51
52	48	return $result;
53		}
54		}
55

Bit-Wasp / bitcoin-php

Pull Request — master (#332)

Validator::checkSignatures() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like