Transaction - Code Metrics - Inspection of "Add script tests from bitcoin core" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#332)

by thomas

created 2016-07-01 03:41 UTC

Transaction C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	297
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	19

Test Coverage

Coverage

82.98%

Importance

Changes	5
Bugs	1	Features	2

Metric	Value
c	5
b	1
f	2
dl	0
loc	297
ccs	78
cts	94
cp	0.8298
rs	5.8305
wmc	41
lcom	1
cbo	19

23 Methods

Rating	Name	Size	Complexity
C	__construct()	27	7
A	__clone()	5	1
A	getTxHash()	4	1
A	getTxId()	4	1
A	getWitnessTxId()	4	1
A	getVersion()	4	1
A	getInputs()	4	1
A	getInput()	4	1
A	getOutputs()	4	1
A	getOutput()	4	1
A	getWitnesses()	4	1
A	getWitness()	4	1
A	makeOutpoint()	5	1
A	getLockTime()	4	1
A	getSignatureHash()	4	1
A	getValueOut()	10	2
A	isCoinbase()	4	2
C	equals()	34	11
A	validator()	4	1
A	getBuffer()	4	1
A	getWitnessBuffer()	4	1
A	makeUtxo()	4	1
A	__debugInfo()	10	1

How to fix Complexity

<?php

namespace BitWasp\Bitcoin\Transaction;

use BitWasp\Bitcoin\Bitcoin;
use BitWasp\Bitcoin\Collection\Transaction\TransactionInputCollection;
use BitWasp\Bitcoin\Collection\Transaction\TransactionOutputCollection;
use BitWasp\Bitcoin\Collection\Transaction\TransactionWitnessCollection;
use BitWasp\Bitcoin\Crypto\Hash;
use BitWasp\Bitcoin\Script\ScriptWitnessInterface;
use BitWasp\Bitcoin\Serializable;
use BitWasp\Bitcoin\Serializer\Transaction\OldTransactionSerializer;
use BitWasp\Bitcoin\Serializer\Transaction\TransactionSerializer;
use BitWasp\Bitcoin\Transaction\SignatureHash\Hasher;
use BitWasp\Bitcoin\Utxo\Utxo;
use BitWasp\Buffertools\BufferInterface;
use BitWasp\CommonTrait\FunctionAliasArrayAccess;

class Transaction extends Serializable implements TransactionInterface
{
    use FunctionAliasArrayAccess;

    /**
     * @var int
     */
    private $version;

    /**
     * @var TransactionInputCollection
     */
    private $inputs;

    /**
     * @var TransactionOutputCollection
     */
    private $outputs;

    /**
     * @var TransactionWitnessCollection
     */
    private $witness;

    /**
     * @var int
     */
    private $lockTime;

    /**
     * Transaction constructor.
     *
     * @param int $nVersion
     * @param TransactionInputCollection|null $inputs
     * @param TransactionOutputCollection|null $outputs
     * @param TransactionWitnessCollection|null $witness
     * @param int $nLockTime
     */
    public function __construct(
        $nVersion = TransactionInterface::DEFAULT_VERSION,
        TransactionInputCollection $inputs = null,
        TransactionOutputCollection $outputs = null,
        TransactionWitnessCollection $witness = null,
        $nLockTime = 0
    ) {
        if ($nVersion > TransactionInterface::MAX_VERSION) {
            throw new \InvalidArgumentException('Version must be less than ' . TransactionInterface::MAX_VERSION);
        }

        if ($nLockTime < 0 || $nLockTime > TransactionInterface::MAX_LOCKTIME) {
            throw new \InvalidArgumentException('Locktime must be positive and less than ' . TransactionInterface::MAX_LOCKTIME);
        }

        $this->version = $nVersion;
        $this->inputs = $inputs ?: new TransactionInputCollection();
        $this->outputs = $outputs ?: new TransactionOutputCollection();
        $this->witness = $witness ?: new TransactionWitnessCollection();
        $this->lockTime = $nLockTime;

        $this
            ->initFunctionAlias('version', 'getVersion')
            ->initFunctionAlias('inputs', 'getInputs')
            ->initFunctionAlias('outputs', 'getOutputs')
            ->initFunctionAlias('locktime', 'getLockTime');
    }

    /**
     * @return Transaction
     */
    public function __clone()
    {
        $this->inputs = clone $this->inputs;
        $this->outputs = clone $this->outputs;
    }

    /**
     * @return BufferInterface
     */
    public function getTxHash()
    {
        return Hash::sha256d($this->getBuffer());
    }

    /**
     * @return BufferInterface
     */
    public function getTxId()
    {
        return $this->getTxHash()->flip();
    }

    /**
     * @return BufferInterface
     */
    public function getWitnessTxId()
    {
        return Hash::sha256d($this->getWitnessBuffer())->flip();
    }

    /**
     * @return int
     */
    public function getVersion()
    {
        return $this->version;
    }

    /**
     * Get the array of inputs in the transaction
     *
     * @return TransactionInputCollection
     */
    public function getInputs()
    {
        return $this->inputs;
    }

    /**
     * @param int $index
     * @return TransactionInputInterface
     */
    public function getInput($index)
    {
        return $this->inputs[$index];
    }

    /**
     * Get Outputs
     *
     * @return TransactionOutputCollection
     */
    public function getOutputs()
    {
        return $this->outputs;
    }

    /**
     * @param int $vout
     * @return TransactionOutputInterface
     */
    public function getOutput($vout)
    {
        return $this->outputs[$vout];
    }

    /**
     * @return TransactionWitnessCollection
     */
    public function getWitnesses()
    {
        return $this->witness;
    }

    /**
     * @return ScriptWitnessInterface
     */
    public function getWitness($index)
    {
        return $this->witness[$index];
    }

    /**
     * @param int $vout
     * @return OutPointInterface
     */
    public function makeOutpoint($vout)
    {
        $this->getOutput($vout);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        return new OutPoint($this->getTxId(), $vout);
    }

    /**
     * @param int $vout
     * @return Utxo
     */
    public function makeUtxo($vout)
    {
        return new Utxo(new OutPoint($this->getTxId(), $vout), $this->getOutput($vout));
    }

    /**
     * Get Lock Time
     *
     * @return int
     */
    public function getLockTime()
    {
        return $this->lockTime;
    }

    /**
     * @return Hasher
     */
    public function getSignatureHash()
    {
        return new Hasher($this);
    }

    /**
     * @return int|string
     */
    public function getValueOut()
    {
        $math = Bitcoin::getMath();
        $value = gmp_init(0);
        foreach ($this->outputs as $output) {
            $value = $math->add($value, gmp_init($output->getValue()));
        }

        return gmp_strval($value, 10);
    }

    /**
     * @return bool
     */
    public function isCoinbase()
    {
        return count($this->inputs) === 1 && $this->getInput(0)->isCoinBase();
    }

    /**
     * @param TransactionInterface $tx
     * @return bool
     */
    public function equals(TransactionInterface $tx)
    {
        $version = gmp_cmp($this->version, $tx->getVersion());
        if ($version !== 0) {
            return false;
        }

        $nIn = count($this->inputs);
        $nOut = count($this->outputs);
        $nWit = count($this->witness);
        if ($nIn !== count($tx->getInputs()) || $nOut !== count($tx->getOutputs()) || $nWit !== count($tx->getWitnesses())) {
            return false;
        }

        for ($i = 0; $i < $nIn; $i++) {
            if (false === $this->getInput($i)->equals($tx->getInput($i))) {
                return false;
            }
        }

        for ($i = 0; $i < $nOut; $i++) {
            if (false === $this->getOutput($i)->equals($tx->getOutput($i))) {
                return false;
            }
        }

        for ($i = 0; $i < $nWit; $i++) {
            if (false === $this->getWitness($i)->equals($tx->getWitness($i))) {
                return false;
            }
        }

        return gmp_cmp($this->lockTime, $tx->getLockTime()) === 0;
    }

    /**
     * @return Validator
     */
    public function validator()
    {
        return new Validator($this);
    }

    /**
     * @return BufferInterface
     */
    public function getBuffer()
    {
        return (new OldTransactionSerializer())->serialize($this);
    }

    /**
     * @return BufferInterface
     */
    public function getWitnessBuffer()
    {
        return (new TransactionSerializer())->serialize($this);
    }
    
    /**
     * @return array
     */
    public function __debugInfo()
    {
        return [
            'version' => $this->version,
            'vin' => $this->inputs,
            'vout' => $this->outputs,
            'vwit' => $this->witness,
            'locktime' => $this->lockTime
        ];
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Transaction;
4
5		use BitWasp\Bitcoin\Bitcoin;
6		use BitWasp\Bitcoin\Collection\Transaction\TransactionInputCollection;
7		use BitWasp\Bitcoin\Collection\Transaction\TransactionOutputCollection;
8		use BitWasp\Bitcoin\Collection\Transaction\TransactionWitnessCollection;
9		use BitWasp\Bitcoin\Crypto\Hash;
10		use BitWasp\Bitcoin\Script\ScriptWitnessInterface;
11		use BitWasp\Bitcoin\Serializable;
12		use BitWasp\Bitcoin\Serializer\Transaction\OldTransactionSerializer;
13		use BitWasp\Bitcoin\Serializer\Transaction\TransactionSerializer;
14		use BitWasp\Bitcoin\Transaction\SignatureHash\Hasher;
15		use BitWasp\Bitcoin\Utxo\Utxo;
16		use BitWasp\Buffertools\BufferInterface;
17		use BitWasp\CommonTrait\FunctionAliasArrayAccess;
18
19		class Transaction extends Serializable implements TransactionInterface
20		{
21		use FunctionAliasArrayAccess;
22
23		/**
24		* @var int
25		*/
26		private $version;
27
28		/**
29		* @var TransactionInputCollection
30		*/
31		private $inputs;
32
33		/**
34		* @var TransactionOutputCollection
35		*/
36		private $outputs;
37
38		/**
39		* @var TransactionWitnessCollection
40		*/
41		private $witness;
42
43		/**
44		* @var int
45		*/
46		private $lockTime;
47
48		/**
49		* Transaction constructor.
50		*
51		* @param int $nVersion
52		* @param TransactionInputCollection\|null $inputs
53		* @param TransactionOutputCollection\|null $outputs
54		* @param TransactionWitnessCollection\|null $witness
55		* @param int $nLockTime
56		*/
57	3936	public function __construct(
58		$nVersion = TransactionInterface::DEFAULT_VERSION,
59		TransactionInputCollection $inputs = null,
60		TransactionOutputCollection $outputs = null,
61		TransactionWitnessCollection $witness = null,
62		$nLockTime = 0
63		) {
64	3936	if ($nVersion > TransactionInterface::MAX_VERSION) {
65	3	throw new \InvalidArgumentException('Version must be less than ' . TransactionInterface::MAX_VERSION);
66		}
67
68	3933	if ($nLockTime < 0 \|\| $nLockTime > TransactionInterface::MAX_LOCKTIME) {
69	3	throw new \InvalidArgumentException('Locktime must be positive and less than ' . TransactionInterface::MAX_LOCKTIME);
70		}
71
72	3930	$this->version = $nVersion;
73	3930	$this->inputs = $inputs ?: new TransactionInputCollection();
74	3930	$this->outputs = $outputs ?: new TransactionOutputCollection();
75	3930	$this->witness = $witness ?: new TransactionWitnessCollection();
76	3930	$this->lockTime = $nLockTime;
77
78	2620	$this
79	3930	->initFunctionAlias('version', 'getVersion')
80	3930	->initFunctionAlias('inputs', 'getInputs')
81	3930	->initFunctionAlias('outputs', 'getOutputs')
82	3930	->initFunctionAlias('locktime', 'getLockTime');
83	3930	}
84
85		/**
86		* @return Transaction
87		*/
88	244	public function __clone()
89		{
90	244	$this->inputs = clone $this->inputs;
91	244	$this->outputs = clone $this->outputs;
92	244	}
93
94		/**
95		* @return BufferInterface
96		*/
97	3360	public function getTxHash()
98		{
99	3360	return Hash::sha256d($this->getBuffer());
100		}
101
102		/**
103		* @return BufferInterface
104		*/
105	3360	public function getTxId()
106		{
107	3360	return $this->getTxHash()->flip();
108		}
109
110		/**
111		* @return BufferInterface
112		*/
113		public function getWitnessTxId()
114		{
115		return Hash::sha256d($this->getWitnessBuffer())->flip();
116		}
117
118		/**
119		* @return int
120		*/
121	3441	public function getVersion()
122		{
123	3441	return $this->version;
124		}
125
126		/**
127		* Get the array of inputs in the transaction
128		*
129		* @return TransactionInputCollection
130		*/
131	3786	public function getInputs()
132		{
133	3786	return $this->inputs;
134		}
135
136		/**
137		* @param int $index
138		* @return TransactionInputInterface
139		*/
140	147	public function getInput($index)
141		{
142	147	return $this->inputs[$index];
143		}
144
145		/**
146		* Get Outputs
147		*
148		* @return TransactionOutputCollection
149		*/
150	3459	public function getOutputs()
151	18	{
152	3459	return $this->outputs;
153		}
154
155		/**
156		* @param int $vout
157		* @return TransactionOutputInterface
158		*/
159	3351	public function getOutput($vout)
160		{
161	3351	return $this->outputs[$vout];
162		}
163
164		/**
165		* @return TransactionWitnessCollection
166		*/
167	235	public function getWitnesses()
168		{
169	235	return $this->witness;
170		}
171
172		/**
173		* @return ScriptWitnessInterface
174		*/
175		public function getWitness($index)
176		{
177		return $this->witness[$index];
178		}
179
180		/**
181		* @param int $vout
182		* @return OutPointInterface
183		*/
184	3264	public function makeOutpoint($vout)
185		{
186	3264	$this->getOutput($vout);
		0 ignored issues – show Unused Code introduced 2015-12-16 03:40 UTC by Report Bug Copy Issue Report The call to the method `BitWasp\Bitcoin\Transact...ransaction::getOutput()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
187	3264	return new OutPoint($this->getTxId(), $vout);
188		}
189
190		/**
191		* @param int $vout
192		* @return Utxo
193		*/
194	48	public function makeUtxo($vout)
195		{
196	48	return new Utxo(new OutPoint($this->getTxId(), $vout), $this->getOutput($vout));
197		}
198
199		/**
200		* Get Lock Time
201		*
202		* @return int
203		*/
204	3444	public function getLockTime()
205		{
206	3444	return $this->lockTime;
207		}
208
209		/**
210		* @return Hasher
211		*/
212		public function getSignatureHash()
213		{
214		return new Hasher($this);
215		}
216
217		/**
218		* @return int\|string
219		*/
220	3	public function getValueOut()
221		{
222	3	$math = Bitcoin::getMath();
223	3	$value = gmp_init(0);
224	3	foreach ($this->outputs as $output) {
225	3	$value = $math->add($value, gmp_init($output->getValue()));
226	2	}
227
228	3	return gmp_strval($value, 10);
229		}
230
231		/**
232		* @return bool
233		*/
234	3	public function isCoinbase()
235		{
236	3	return count($this->inputs) === 1 && $this->getInput(0)->isCoinBase();
237		}
238
239		/**
240		* @param TransactionInterface $tx
241		* @return bool
242		*/
243	3	public function equals(TransactionInterface $tx)
244		{
245	3	$version = gmp_cmp($this->version, $tx->getVersion());
246	3	if ($version !== 0) {
247	3	return false;
248		}
249
250	3	$nIn = count($this->inputs);
251	3	$nOut = count($this->outputs);
252	3	$nWit = count($this->witness);
253	3	if ($nIn !== count($tx->getInputs()) \|\| $nOut !== count($tx->getOutputs()) \|\| $nWit !== count($tx->getWitnesses())) {
254	3	return false;
255		}
256
257	3	for ($i = 0; $i < $nIn; $i++) {
258	3	if (false === $this->getInput($i)->equals($tx->getInput($i))) {
259	3	return false;
260		}
261	2	}
262
263	3	for ($i = 0; $i < $nOut; $i++) {
264	3	if (false === $this->getOutput($i)->equals($tx->getOutput($i))) {
265	3	return false;
266		}
267	2	}
268
269	3	for ($i = 0; $i < $nWit; $i++) {
270		if (false === $this->getWitness($i)->equals($tx->getWitness($i))) {
271		return false;
272		}
273		}
274
275	3	return gmp_cmp($this->lockTime, $tx->getLockTime()) === 0;
276		}
277
278		/**
279		* @return Validator
280		*/
281	75	public function validator()
282		{
283	75	return new Validator($this);
284		}
285
286		/**
287		* @return BufferInterface
288		*/
289	3405	public function getBuffer()
290		{
291	3405	return (new OldTransactionSerializer())->serialize($this);
292		}
293
294		/**
295		* @return BufferInterface
296		*/
297	27	public function getWitnessBuffer()
298		{
299	27	return (new TransactionSerializer())->serialize($this);
300		}
301
302		/**
303		* @return array
304		*/
305		public function __debugInfo()
306		{
307		return [
308		'version' => $this->version,
309		'vin' => $this->inputs,
310		'vout' => $this->outputs,
311		'vwit' => $this->witness,
312		'locktime' => $this->lockTime
313		];
314		}
315		}
316

Bit-Wasp / bitcoin-php

Pull Request — master (#332)

Transaction C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

23 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like