Complex classes like Script often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Script, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | class Script extends Serializable implements ScriptInterface |
||
| 15 | { |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @var Opcodes |
||
| 19 | */ |
||
| 20 | protected $opCodes; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @var string |
||
| 24 | */ |
||
| 25 | protected $script; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * @param BufferInterface $script |
||
| 29 | * @param Opcodes|null $opCodes |
||
| 30 | */ |
||
| 31 | 4143 | public function __construct(BufferInterface $script = null, Opcodes $opCodes = null) |
|
| 32 | { |
||
| 33 | 4143 | $this->script = $script instanceof BufferInterface ? $script->getBinary() : ''; |
|
| 34 | 4143 | $this->opCodes = $opCodes ?: new Opcodes(); |
|
| 35 | 4143 | } |
|
| 36 | |||
| 37 | /** |
||
| 38 | * @return BufferInterface |
||
| 39 | */ |
||
| 40 | 4089 | public function getBuffer() |
|
| 41 | { |
||
| 42 | 4089 | return new Buffer($this->script); |
|
| 43 | } |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @return Parser |
||
| 47 | */ |
||
| 48 | 3912 | public function getScriptParser() |
|
| 49 | { |
||
| 50 | 3912 | return new Parser(Bitcoin::getMath(), $this); |
|
| 51 | } |
||
| 52 | |||
| 53 | /** |
||
| 54 | * Get all opcodes |
||
| 55 | * |
||
| 56 | * @return Opcodes |
||
| 57 | */ |
||
| 58 | 348 | public function getOpCodes() |
|
| 59 | { |
||
| 60 | 348 | return $this->opCodes; |
|
| 61 | } |
||
| 62 | |||
| 63 | /** |
||
| 64 | * Return a buffer containing the hash of this script. |
||
| 65 | * |
||
| 66 | * @return BufferInterface |
||
| 67 | */ |
||
| 68 | 75 | public function getScriptHash() |
|
| 69 | { |
||
| 70 | 75 | return Hash::sha256ripe160($this->getBuffer()); |
|
| 71 | } |
||
| 72 | |||
| 73 | /** |
||
| 74 | * @param bool|true $accurate |
||
| 75 | * @return int |
||
| 76 | */ |
||
| 77 | 24 | public function countSigOps($accurate = true) |
|
| 106 | |||
| 107 | /** |
||
| 108 | * @param WitnessProgram $program |
||
| 109 | * @param ScriptWitnessInterface $scriptWitness |
||
| 110 | * @return int |
||
| 111 | */ |
||
| 112 | private function witnessSigOps(WitnessProgram $program, ScriptWitnessInterface $scriptWitness) |
||
| 113 | { |
||
| 114 | if ($program->getVersion() == 0) { |
||
| 115 | $size = $program->getProgram()->getSize(); |
||
| 116 | if ($size === 32 && count($scriptWitness) > 0) { |
||
| 117 | $script = new Script($scriptWitness->bottom()); |
||
| 118 | return $script->countSigOps(true); |
||
| 119 | } |
||
| 120 | |||
| 121 | if ($size === 20) { |
||
| 122 | return 1; |
||
| 123 | } |
||
| 124 | } |
||
| 125 | |||
| 126 | return 0; |
||
| 127 | } |
||
| 128 | |||
| 129 | /** |
||
| 130 | * @param ScriptInterface $scriptSig |
||
| 131 | * @param ScriptWitnessInterface $scriptWitness |
||
| 132 | * @param int $flags |
||
| 133 | * @return int |
||
| 134 | */ |
||
| 135 | public function countWitnessSigOps(ScriptInterface $scriptSig, ScriptWitnessInterface $scriptWitness, $flags) |
||
| 136 | { |
||
| 137 | if ($flags & InterpreterInterface::VERIFY_WITNESS === 0) { |
||
| 138 | return 0; |
||
| 139 | } |
||
| 140 | |||
| 141 | $program = null; |
||
| 142 | if ($this->isWitness($program)) { |
||
| 143 | /** @var WitnessProgram $program */ |
||
| 144 | return $this->witnessSigOps($program, $scriptWitness); |
||
| 145 | } |
||
| 146 | |||
| 147 | if ((new OutputClassifier())->isPayToScriptHash($this)) { |
||
| 148 | $parsed = $scriptSig->getScriptParser()->decode(); |
||
| 149 | $subscript = new Script(end($parsed)->getData()); |
||
| 150 | if ($subscript->isWitness($program)) { |
||
| 151 | /** @var WitnessProgram $program */ |
||
| 152 | return $this->witnessSigOps($program, $scriptWitness); |
||
| 153 | } |
||
| 154 | } |
||
| 155 | |||
| 156 | return 0; |
||
| 157 | } |
||
| 158 | |||
| 159 | /** |
||
| 160 | * @param ScriptInterface $scriptSig |
||
| 161 | * @return int |
||
| 162 | */ |
||
| 163 | 9 | public function countP2shSigOps(ScriptInterface $scriptSig) |
|
| 164 | { |
||
| 165 | 9 | if (!(new OutputClassifier())->isPayToScriptHash($this)) { |
|
| 166 | 3 | return $this->countSigOps(true); |
|
| 167 | } |
||
| 168 | |||
| 169 | try { |
||
| 170 | 9 | $data = null; |
|
| 171 | 9 | foreach ($scriptSig->getScriptParser() as $exec) { |
|
| 172 | 9 | if ($exec->getOp() > Opcodes::OP_16) { |
|
| 173 | 3 | return 0; |
|
| 174 | } |
||
| 175 | |||
| 176 | 6 | if ($exec->isPush()) { |
|
| 177 | 6 | $data = $exec->getData(); |
|
| 178 | 4 | } |
|
| 179 | 6 | } |
|
| 180 | |||
| 181 | 9 | if (!$data instanceof BufferInterface) { |
|
| 182 | 3 | return 0; |
|
| 183 | } |
||
| 184 | |||
| 185 | 6 | return (new Script($data))->countSigOps(true); |
|
| 186 | } catch (\Exception $e) { |
||
| 187 | return 0; |
||
| 188 | } |
||
| 189 | } |
||
| 190 | |||
| 191 | /** |
||
| 192 | * @return bool |
||
| 193 | */ |
||
| 194 | 126 | public function isPushOnly() |
|
| 204 | |||
| 205 | /** |
||
| 206 | * @param WitnessProgram|null $program |
||
| 207 | * @return bool |
||
| 208 | */ |
||
| 209 | 168 | public function isWitness(& $program = null) |
|
| 210 | { |
||
| 211 | 168 | $buffer = $this->getBuffer(); |
|
| 212 | 168 | $size = $buffer->getSize(); |
|
| 213 | 168 | if ($size < 4 || $size > 34) { |
|
| 214 | 39 | return false; |
|
| 215 | } |
||
| 216 | |||
| 217 | 135 | $script = $this->getScriptParser()->decode(); |
|
| 218 | 135 | if (!isset($script[0]) || !isset($script[1])) { |
|
| 219 | 3 | return false; |
|
| 220 | } |
||
| 221 | |||
| 222 | 132 | $version = $script[0]->getOp(); |
|
| 223 | 132 | if ($version != Opcodes::OP_0 && ($version < Opcodes::OP_1 || $version > Opcodes::OP_16)) { |
|
| 224 | 48 | return false; |
|
| 225 | } |
||
| 226 | |||
| 227 | 111 | $witness = $script[1]; |
|
| 228 | 111 | if ($script[1]->isPush() && $size === $witness->getDataSize() + 2) { |
|
| 229 | 108 | $program = new WitnessProgram(decodeOpN($version), $witness->getData()); |
|
| 230 | 108 | return true; |
|
| 231 | } |
||
| 232 | |||
| 233 | 3 | return false; |
|
| 234 | } |
||
| 235 | |||
| 236 | /** |
||
| 237 | * @param ScriptInterface $script |
||
| 238 | * @return bool |
||
| 239 | */ |
||
| 240 | 12 | public function equals(ScriptInterface $script) |
|
| 244 | |||
| 245 | /** |
||
| 246 | * @return array |
||
| 247 | */ |
||
| 248 | public function __debugInfo() |
||
| 249 | { |
||
| 250 | return [ |
||
| 251 | 'script' => $this->script |
||
| 252 | ]; |
||
| 253 | } |
||
| 254 | } |
||
| 255 |