WitnessScriptFactory::create() - Code Metrics - Inspection of "Segwit h0" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#241)

by thomas

created 2016-02-03 14:27 UTC

WitnessScriptFactory::create() A

↳ Parent: WitnessScriptFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	2

<?php

namespace BitWasp\Bitcoin\Script\Factory;

use BitWasp\Bitcoin\Script\Opcodes;
use BitWasp\Bitcoin\Script\Parser\Operation;
use BitWasp\Bitcoin\Script\Script;
use BitWasp\Bitcoin\Script\ScriptInterface;
use BitWasp\Bitcoin\Script\WitnessProgram;

class WitnessScriptFactory
{
    /**
     * @var OutputScriptFactory
     */
    private $scriptPubKey;

    /**
     * @var Opcodes
     */
    private $opcodes;

    /**
     * WitnessScriptFactory constructor.
     * @param OutputScriptFactory $scriptPubKey
     * @param P2shScriptFactory $redeemScript
     * @param Opcodes $opcodes
     */
    public function __construct(OutputScriptFactory $scriptPubKey, P2shScriptFactory $redeemScript, Opcodes $opcodes)
    {
        $this->scriptPubKey = $scriptPubKey;
        $this->redeemScript = $redeemScript;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->opcodes = $opcodes;
    }

    /**
     * @param int $version
     * @param ScriptInterface $script
     * @return WitnessProgram
     */
    public function create($version, ScriptInterface $script)
    {
        return new WitnessProgram($version, $script);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Parse a ScriptInterface into a WitnessProgram
     *
     * @param ScriptInterface $script
     * @return WitnessProgram
     */
    public function parse(ScriptInterface $script)
    {
        $parser = $script->getScriptParser();
        $decoded = $parser->decode();

        /**
         * @var Operation $versionPush
         * @var Operation $witnessPush
         */
        list ($versionPush, $witnessPush) = $decoded;
        $version = $versionPush->getData()->getInt();
        $program = new Script($witnessPush->getData());

        return new WitnessProgram($version, $program, $this->opcodes);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace BitWasp\Bitcoin\Script\Factory;
4
5			use BitWasp\Bitcoin\Script\Opcodes;
6			use BitWasp\Bitcoin\Script\Parser\Operation;
7			use BitWasp\Bitcoin\Script\Script;
8			use BitWasp\Bitcoin\Script\ScriptInterface;
9			use BitWasp\Bitcoin\Script\WitnessProgram;
10
11			class WitnessScriptFactory
12			{
13			/**
14			* @var OutputScriptFactory
15			*/
16			private $scriptPubKey;
17
18			/**
19			* @var Opcodes
20			*/
21			private $opcodes;
22
23			/**
24			* WitnessScriptFactory constructor.
25			* @param OutputScriptFactory $scriptPubKey
26			* @param P2shScriptFactory $redeemScript
27			* @param Opcodes $opcodes
28			*/
29			public function __construct(OutputScriptFactory $scriptPubKey, P2shScriptFactory $redeemScript, Opcodes $opcodes)
30			{
31			$this->scriptPubKey = $scriptPubKey;
32			$this->redeemScript = $redeemScript;
			0 ignored issues – show Bug introduced 2016-02-03 16:40 UTC by Report Bug Copy Issue Report The property `redeemScript` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
33			$this->opcodes = $opcodes;
34			}
35
36			/**
37			* @param int $version
38			* @param ScriptInterface $script
39			* @return WitnessProgram
40			*/
41			public function create($version, ScriptInterface $script)
42			{
43			return new WitnessProgram($version, $script);
			0 ignored issues – show Documentation introduced 2016-02-03 16:40 UTC by Report Bug Copy Issue Report `$script` is of type `object<BitWasp\Bitcoin\Script\ScriptInterface>`, but the function expects a `object<BitWasp\Buffertools\BufferInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44			}
45
46			/**
47			* Parse a ScriptInterface into a WitnessProgram
48			*
49			* @param ScriptInterface $script
50			* @return WitnessProgram
51			*/
52			public function parse(ScriptInterface $script)
53			{
54			$parser = $script->getScriptParser();
55			$decoded = $parser->decode();
56
57			/**
58			* @var Operation $versionPush
59			* @var Operation $witnessPush
60			*/
61			list ($versionPush, $witnessPush) = $decoded;
62			$version = $versionPush->getData()->getInt();
63			$program = new Script($witnessPush->getData());
64
65			return new WitnessProgram($version, $program, $this->opcodes);
			0 ignored issues – show Documentation introduced 2016-02-03 16:40 UTC by Report Bug Copy Issue Report `$program` is of type `object<BitWasp\Bitcoin\Script\Script>`, but the function expects a `object<BitWasp\Buffertools\BufferInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Unused Code introduced 2016-02-03 16:40 UTC by Report Bug Copy Issue Report The call to `WitnessProgram::__construct()` has too many arguments starting with `$this->opcodes`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
66			}
67			}
68

Bit-Wasp / bitcoin-php

Pull Request — master (#241)

WitnessScriptFactory::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like