BitWasp\Bitcoin\Key\PublicKeyFactory

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	fromHex()	0	4	1
A	fromBuffer()	0	6	1
A	validateHex()	0	9	2

<?php

declare(strict_types=1);

namespace BitWasp\Bitcoin\Key;

use BitWasp\Bitcoin\Crypto\EcAdapter\Adapter\EcAdapterInterface;
use BitWasp\Bitcoin\Crypto\EcAdapter\EcSerializer;
use BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface;
use BitWasp\Bitcoin\Crypto\EcAdapter\Serializer\Key\PublicKeySerializerInterface;
use BitWasp\Buffertools\Buffer;
use BitWasp\Buffertools\BufferInterface;

class PublicKeyFactory
{
    /**
     * @param string $hex
     * @param EcAdapterInterface|null $ecAdapter
     * @return PublicKeyInterface
     * @throws \Exception
     */
    public static function fromHex(string $hex, EcAdapterInterface $ecAdapter = null): PublicKeyInterface
    {
        return self::fromBuffer(Buffer::hex($hex), $ecAdapter);
    }

    /**
     * @param BufferInterface $buffer
     * @param EcAdapterInterface|null $ecAdapter
     * @return PublicKeyInterface
     */
    public static function fromBuffer(BufferInterface $buffer, EcAdapterInterface $ecAdapter = null): PublicKeyInterface
    {
        return EcSerializer::getSerializer(PublicKeySerializerInterface::class, true, $ecAdapter)
            ->parse($buffer)
        ;
    }

    /**
     * @param BufferInterface|string $hex
     * @param EcAdapterInterface|null $ecAdapter
     * @return bool
     */
    public static function validateHex($hex, EcAdapterInterface $ecAdapter = null)
    {
        try {
            self::fromHex($hex, $ecAdapter);

It seems like $hex defined by parameter $hex on line 44 can also be of type object<BitWasp\Buffertools\BufferInterface>; however, BitWasp\Bitcoin\Key\PublicKeyFactory::fromHex() does only seem to accept string, maybe add an additional type check?

            return true;
        } catch (\Exception $e) {
            return false;
        }
    }
}