BlockHeaderSerializer::getTemplate() - Code Metrics - Inspection of "TransactionInterface: add getBaseSerialization & g..." - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#446)

by thomas

created 2017-01-20 08:43 UTC

BlockHeaderSerializer::getTemplate() A

↳ Parent: BlockHeaderSerializer::fromParser()

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	0
dl	0
loc	11
ccs	9
cts	9
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php

namespace BitWasp\Bitcoin\Serializer\Block;

use BitWasp\Bitcoin\Block\BlockHeader;
use BitWasp\Bitcoin\Block\BlockHeaderInterface;
use BitWasp\Bitcoin\Serializer\Types;
use BitWasp\Buffertools\Buffer;
use BitWasp\Buffertools\Exceptions\ParserOutOfRange;
use BitWasp\Buffertools\Parser;

class BlockHeaderSerializer
{
    public function __construct()
    {
        $this->hash = Types::bytestringle(32);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->uint32le = Types::uint32le();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->int32le = Types::int32le();

    }

    /**
     * @param \BitWasp\Buffertools\BufferInterface|string $string
     * @return BlockHeader
     * @throws ParserOutOfRange
     */
    public function parse($string)
    {
        return $this->fromParser(new Parser($string));
    }

    /**
     * @param Parser $parser
     * @return BlockHeader
     * @throws ParserOutOfRange
     */
    public function fromParser(Parser $parser)
    {
        try {
            return new BlockHeader(
                $this->int32le->read($parser),

                $this->hash->read($parser),
                $this->hash->read($parser),
                (int) $this->uint32le->read($parser),
                (int) $this->uint32le->read($parser),
                (int) $this->uint32le->read($parser)
            );
        } catch (ParserOutOfRange $e) {
            throw new ParserOutOfRange('Failed to extract full block header from parser');
        }
    }

    /**
     * @param BlockHeaderInterface $header
     * @return \BitWasp\Buffertools\BufferInterface
     */
    public function serialize(BlockHeaderInterface $header)
    {
        return new Buffer(
            $this->int32le->write($header->getVersion()) .

            $this->hash->write($header->getPrevBlock()) .
            $this->hash->write($header->getMerkleRoot()) .
            $this->uint32le->write($header->getTimestamp()) .
            $this->uint32le->write($header->getBits()) .
            $this->uint32le->write($header->getNonce())
        );
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Serializer\Block;
4
5		use BitWasp\Bitcoin\Block\BlockHeader;
6		use BitWasp\Bitcoin\Block\BlockHeaderInterface;
7		use BitWasp\Bitcoin\Serializer\Types;
8		use BitWasp\Buffertools\Buffer;
9		use BitWasp\Buffertools\Exceptions\ParserOutOfRange;
10		use BitWasp\Buffertools\Parser;
11
12		class BlockHeaderSerializer
13		{
14		public function __construct()
15		{
16		$this->hash = Types::bytestringle(32);
		0 ignored issues – show Bug introduced 2017-01-18 12:59 UTC by Report Bug Copy Issue Report The property `hash` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17		$this->uint32le = Types::uint32le();
		0 ignored issues – show Bug introduced 2017-01-18 12:59 UTC by Report Bug Copy Issue Report The property `uint32le` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18	1242	$this->int32le = Types::int32le();
		0 ignored issues – show Bug introduced 2017-01-18 12:59 UTC by Report Bug Copy Issue Report The property `int32le` does not seem to exist. Did you mean `uint32le`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
19		}
20	1242
21	1242	/**
22		* @param \BitWasp\Buffertools\BufferInterface\|string $string
23		* @return BlockHeader
24		* @throws ParserOutOfRange
25		*/
26		public function parse($string)
27		{
28	30	return $this->fromParser(new Parser($string));
29		}
30	30
31		/**
32		* @param Parser $parser
33		* @return BlockHeader
34		* @throws ParserOutOfRange
35		*/
36	1242	public function fromParser(Parser $parser)
37		{
38	1242	try {
39	1242	return new BlockHeader(
40	1242	$this->int32le->read($parser),
		0 ignored issues – show Bug introduced 2017-01-18 12:59 UTC by Report Bug Copy Issue Report The property `int32le` does not seem to exist. Did you mean `uint32le`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
41	1242	$this->hash->read($parser),
42	1242	$this->hash->read($parser),
43	1242	(int) $this->uint32le->read($parser),
44	1242	(int) $this->uint32le->read($parser),
45	1242	(int) $this->uint32le->read($parser)
46		);
47		} catch (ParserOutOfRange $e) {
48		throw new ParserOutOfRange('Failed to extract full block header from parser');
49		}
50		}
51
52		/**
53	108	* @param BlockHeaderInterface $header
54		* @return \BitWasp\Buffertools\BufferInterface
55		*/
56		public function serialize(BlockHeaderInterface $header)
57	108	{
58		return new Buffer(
59	90	$this->int32le->write($header->getVersion()) .
		0 ignored issues – show Bug introduced 2017-01-18 12:59 UTC by Report Bug Copy Issue Report The property `int32le` does not seem to exist. Did you mean `uint32le`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
60	45	$this->hash->write($header->getPrevBlock()) .
61	45	$this->hash->write($header->getMerkleRoot()) .
62	45	$this->uint32le->write($header->getTimestamp()) .
63	45	$this->uint32le->write($header->getBits()) .
64	90	$this->uint32le->write($header->getNonce())
65		);
66	45	}
67		}
68

Bit-Wasp / bitcoin-php

Pull Request — master (#446)

BlockHeaderSerializer::getTemplate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like