Complex classes like Script often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Script, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | class Script extends Serializable implements ScriptInterface |
||
| 15 | { |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @var Opcodes |
||
| 19 | */ |
||
| 20 | protected $opCodes; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @var string |
||
| 24 | */ |
||
| 25 | protected $script; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * @param BufferInterface $script |
||
| 29 | * @param Opcodes|null $opCodes |
||
| 30 | */ |
||
| 31 | 1656 | public function __construct(BufferInterface $script = null, Opcodes $opCodes = null) |
|
| 32 | { |
||
| 33 | 1656 | $this->script = $script instanceof BufferInterface ? $script->getBinary() : ''; |
|
| 34 | 1656 | $this->opCodes = $opCodes ?: new Opcodes(); |
|
| 35 | 1656 | } |
|
| 36 | |||
| 37 | /** |
||
| 38 | * @return BufferInterface |
||
| 39 | */ |
||
| 40 | 1476 | public function getBuffer() |
|
| 44 | |||
| 45 | /** |
||
| 46 | * @return Parser |
||
| 47 | */ |
||
| 48 | 1140 | public function getScriptParser() |
|
| 52 | |||
| 53 | /** |
||
| 54 | * Get all opcodes |
||
| 55 | * |
||
| 56 | * @return Opcodes |
||
| 57 | */ |
||
| 58 | 696 | public function getOpCodes() |
|
| 62 | |||
| 63 | /** |
||
| 64 | * Return a buffer containing the hash of this script. |
||
| 65 | * |
||
| 66 | * @return BufferInterface |
||
| 67 | */ |
||
| 68 | 156 | public function getScriptHash() |
|
| 72 | |||
| 73 | /** |
||
| 74 | * @param bool|true $accurate |
||
| 75 | * @return int |
||
| 76 | */ |
||
| 77 | 48 | public function countSigOps($accurate = true) |
|
| 106 | |||
| 107 | /** |
||
| 108 | * @param WitnessProgram $program |
||
| 109 | * @param ScriptWitnessInterface $scriptWitness |
||
| 110 | * @return int |
||
| 111 | */ |
||
| 112 | private function witnessSigOps(WitnessProgram $program, ScriptWitnessInterface $scriptWitness) |
||
| 128 | |||
| 129 | /** |
||
| 130 | * @param ScriptInterface $scriptSig |
||
| 131 | * @param ScriptWitnessInterface $scriptWitness |
||
| 132 | * @param int $flags |
||
| 133 | * @return int |
||
| 134 | */ |
||
| 135 | public function countWitnessSigOps(ScriptInterface $scriptSig, ScriptWitnessInterface $scriptWitness, $flags) |
||
| 158 | |||
| 159 | 18 | /** |
|
| 160 | * @param ScriptInterface $scriptSig |
||
| 161 | 18 | * @return int |
|
| 162 | 6 | */ |
|
| 163 | public function countP2shSigOps(ScriptInterface $scriptSig) |
||
| 190 | 84 | ||
| 191 | 84 | /** |
|
| 192 | 12 | * @return bool |
|
| 193 | */ |
||
| 194 | 138 | public function isPushOnly() |
|
| 204 | |||
| 205 | 108 | /** |
|
| 206 | 108 | * @param WitnessProgram|null $program |
|
| 207 | 108 | * @return bool |
|
| 208 | 36 | */ |
|
| 209 | public function isWitness(WitnessProgram & $program = null) |
||
| 235 | } |
||
| 236 |