BlockHeader - Code Metrics - Inspection of "flush cache when disabling" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#359)

by Ruben de

created 2016-07-20 12:03 UTC

BlockHeader A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	148
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

74.29%

Importance

Changes	5
Bugs	2	Features	0

Metric	Value
c	5
b	2
f	0
dl	0
loc	148
ccs	26
cts	35
cp	0.7429
rs	10
wmc	17
lcom	1
cbo	6

10 Methods

Rating	Name	Size	Complexity
A	__construct()	17	3
A	getHash()	4	1
A	getVersion()	4	1
A	getPrevBlock()	4	1
A	getMerkleRoot()	4	1
A	getBits()	4	1
A	getNonce()	4	1
A	getTimestamp()	4	1
B	equals()	9	6
A	getBuffer()	4	1

<?php

namespace BitWasp\Bitcoin\Block;

use BitWasp\Bitcoin\Crypto\Hash;
use BitWasp\Bitcoin\Serializable;
use BitWasp\Bitcoin\Serializer\Block\BlockHeaderSerializer;
use BitWasp\Buffertools\BufferInterface;

class BlockHeader extends Serializable implements BlockHeaderInterface
{

    /**
     * @var int
     */
    private $version;

    /**
     * @var BufferInterface
     */
    private $prevBlock;

    /**
     * @var BufferInterface
     */
    private $merkleRoot;

    /**
     * @var int
     */
    private $timestamp;

    /**
     * @var int
     */
    private $bits;

    /**
     * @var int
     */
    private $nonce;

    /**
     * @param int $version
     * @param BufferInterface $prevBlock
     * @param BufferInterface $merkleRoot
     * @param int $timestamp
     * @param int $bits
     * @param int $nonce
     */
    public function __construct($version, BufferInterface $prevBlock, BufferInterface $merkleRoot, $timestamp, $bits, $nonce)
    {
        if ($prevBlock->getSize() !== 32) {
            throw new \InvalidArgumentException('BlockHeader prevBlock must be a 32-byte Buffer');
        }

        if ($merkleRoot->getSize() !== 32) {
            throw new \InvalidArgumentException('BlockHeader merkleRoot must be a 32-byte Buffer');
        }

        $this->version = $version;
        $this->prevBlock = $prevBlock;
        $this->merkleRoot = $merkleRoot;
        $this->timestamp = $timestamp;
        $this->bits = $bits;
        $this->nonce = $nonce;
    }

    /**
     * @return BufferInterface
     */
    public function getHash()
    {
        return Hash::sha256d($this->getBuffer())->flip();
    }

    /**
     * Get the version for this block
     *
     * {@inheritdoc}
     * @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getVersion()
     */
    public function getVersion()
    {
        return $this->version;
    }

    /**
     * {@inheritdoc}
     * @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getPrevBlock()
     */
    public function getPrevBlock()
    {
        return $this->prevBlock;
    }

    /**
     * {@inheritdoc}
     * @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getMerkleRoot()
     */
    public function getMerkleRoot()
    {
        return $this->merkleRoot;
    }

    /**
     * {@inheritdoc}
     * @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getBits()
     */
    public function getBits()
    {
        return $this->bits;
    }

    /**
     * {@inheritdoc}
     * @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getNonce()
     */
    public function getNonce()
    {
        return $this->nonce;
    }

    /**
     * Get the timestamp for this block
     *
     * {@inheritdoc}
     * @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getTimestamp()
     */
    public function getTimestamp()
    {
        return $this->timestamp;
    }

    /**
     * @param BlockHeaderInterface $other
     * @return bool
     */
    public function equals(BlockHeaderInterface $other)
    {
        return $this->version === $other->getVersion()
            && $this->prevBlock->equals($other->getPrevBlock())
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            && $this->merkleRoot->equals($other->getMerkleRoot())
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            && $this->timestamp === $other->getTimestamp()
            && $this->bits === $other->getBits()
            && $this->nonce === $other->getNonce();
    }

    /**
     * {@inheritdoc}
     * @see \BitWasp\Buffertools\SerializableInterface::getBuffer()
     */
    public function getBuffer()
    {
        return (new BlockHeaderSerializer())->serialize($this);
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Block;
4
5		use BitWasp\Bitcoin\Crypto\Hash;
6		use BitWasp\Bitcoin\Serializable;
7		use BitWasp\Bitcoin\Serializer\Block\BlockHeaderSerializer;
8		use BitWasp\Buffertools\BufferInterface;
9
10		class BlockHeader extends Serializable implements BlockHeaderInterface
11		{
12
13		/**
14		* @var int
15		*/
16		private $version;
17
18		/**
19		* @var BufferInterface
20		*/
21		private $prevBlock;
22
23		/**
24		* @var BufferInterface
25		*/
26		private $merkleRoot;
27
28		/**
29		* @var int
30		*/
31		private $timestamp;
32
33		/**
34		* @var int
35		*/
36		private $bits;
37
38		/**
39		* @var int
40		*/
41		private $nonce;
42
43		/**
44		* @param int $version
45		* @param BufferInterface $prevBlock
46		* @param BufferInterface $merkleRoot
47		* @param int $timestamp
48		* @param int $bits
49		* @param int $nonce
50		*/
51	63	public function __construct($version, BufferInterface $prevBlock, BufferInterface $merkleRoot, $timestamp, $bits, $nonce)
52		{
53	63	if ($prevBlock->getSize() !== 32) {
54		throw new \InvalidArgumentException('BlockHeader prevBlock must be a 32-byte Buffer');
55		}
56
57	63	if ($merkleRoot->getSize() !== 32) {
58		throw new \InvalidArgumentException('BlockHeader merkleRoot must be a 32-byte Buffer');
59		}
60
61	63	$this->version = $version;
62	63	$this->prevBlock = $prevBlock;
63	63	$this->merkleRoot = $merkleRoot;
64	63	$this->timestamp = $timestamp;
65	63	$this->bits = $bits;
66	63	$this->nonce = $nonce;
67	63	}
68
69		/**
70		* @return BufferInterface
71		*/
72	573	public function getHash()
73		{
74	573	return Hash::sha256d($this->getBuffer())->flip();
75		}
76
77		/**
78		* Get the version for this block
79		*
80		* {@inheritdoc}
81		* @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getVersion()
82		*/
83	600	public function getVersion()
84		{
85	600	return $this->version;
86		}
87
88		/**
89		* {@inheritdoc}
90		* @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getPrevBlock()
91		*/
92	600	public function getPrevBlock()
93		{
94	600	return $this->prevBlock;
95		}
96
97		/**
98		* {@inheritdoc}
99		* @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getMerkleRoot()
100		*/
101	609	public function getMerkleRoot()
102		{
103	609	return $this->merkleRoot;
104		}
105
106		/**
107		* {@inheritdoc}
108		* @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getBits()
109		*/
110	597	public function getBits()
111		{
112	597	return $this->bits;
113		}
114
115		/**
116		* {@inheritdoc}
117		* @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getNonce()
118		*/
119	600	public function getNonce()
120		{
121	600	return $this->nonce;
122		}
123
124		/**
125		* Get the timestamp for this block
126		*
127		* {@inheritdoc}
128		* @see \BitWasp\Bitcoin\Block\BlockHeaderInterface::getTimestamp()
129		*/
130	600	public function getTimestamp()
131		{
132	600	return $this->timestamp;
133		}
134
135		/**
136		* @param BlockHeaderInterface $other
137		* @return bool
138		*/
139		public function equals(BlockHeaderInterface $other)
140		{
141		return $this->version === $other->getVersion()
142		&& $this->prevBlock->equals($other->getPrevBlock())
		0 ignored issues – show Documentation introduced 2016-07-19 18:30 UTC by Report Bug Copy Issue Report `$other->getPrevBlock()` is of type `object<BitWasp\Buffertools\BufferInterface>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
143		&& $this->merkleRoot->equals($other->getMerkleRoot())
		0 ignored issues – show Documentation introduced 2016-07-19 18:30 UTC by Report Bug Copy Issue Report `$other->getMerkleRoot()` is of type `object<BitWasp\Buffertools\BufferInterface>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
144		&& $this->timestamp === $other->getTimestamp()
145		&& $this->bits === $other->getBits()
146		&& $this->nonce === $other->getNonce();
147		}
148
149		/**
150		* {@inheritdoc}
151		* @see \BitWasp\Buffertools\SerializableInterface::getBuffer()
152		*/
153	576	public function getBuffer()
154		{
155	576	return (new BlockHeaderSerializer())->serialize($this);
156		}
157		}
158

Bit-Wasp / bitcoin-php

Pull Request — master (#359)

BlockHeader A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

Duplication Side-by-Side

Filter issues like