Operation::__construct() - Code Metrics - Inspection of "Pad multisig zeroes" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#523)

by thomas

created 2017-08-30 13:28 UTC

Operation::__construct() A

↳ Parent: Operation

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	3
dl	0
loc	7
ccs	6
cts	6
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace BitWasp\Bitcoin\Script\Parser;

use BitWasp\Bitcoin\Script\Opcodes;
use BitWasp\Buffertools\BufferInterface;

class Operation
{
    /**
     * @var bool
     */
    private $push;

    /**
     * @var int
     */
    private $opCode;

    /**
     * @var BufferInterface
     */
    private $pushData;

    /**
     * @var int
     */
    private $pushDataSize;

    /**
     * Operation constructor.
     * @param int $opCode
     * @param BufferInterface $pushData
     * @param int $pushDataSize
     */
    public function __construct($opCode, BufferInterface $pushData, $pushDataSize = 0)
    {
        $this->push = $opCode >= 0 && $opCode <= Opcodes::OP_PUSHDATA4;
        $this->opCode = $opCode;
        $this->pushData = $pushData;
        $this->pushDataSize = $pushDataSize;
    }

    /**
     * @return bool
     */
    public function isPush()
    {
        return $this->push;
    }

    /**
     * @return int
     */
    public function getOp()
    {
        return $this->opCode;
    }

    /**
     * @return BufferInterface
     */
    public function getData()
    {
        return $this->pushData;
    }

    /**
     * @return int
     */
    public function getDataSize()
    {
        if (!$this->push) {
            throw new \RuntimeException("Op wasn't a push operation");
        }

        return $this->pushDataSize;
    }

    /**
     * @return BufferInterface|int
     */
    public function encode()
    {
        if ($this->push) {
            return $this->pushData;
        } else {
            return $this->opCode;
        }
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Script\Parser;
4
5		use BitWasp\Bitcoin\Script\Opcodes;
6		use BitWasp\Buffertools\BufferInterface;
7
8		class Operation
9		{
10		/**
11		* @var bool
12		*/
13		private $push;
14
15		/**
16		* @var int
17		*/
18		private $opCode;
19
20		/**
21		* @var BufferInterface
22		*/
23		private $pushData;
24
25		/**
26		* @var int
27		*/
28		private $pushDataSize;
29
30		/**
31		* Operation constructor.
32		* @param int $opCode
33		* @param BufferInterface $pushData
34		* @param int $pushDataSize
35		*/
36	2566	public function __construct($opCode, BufferInterface $pushData, $pushDataSize = 0)
37		{
38	2566	$this->push = $opCode >= 0 && $opCode <= Opcodes::OP_PUSHDATA4;
39	2566	$this->opCode = $opCode;
40	2566	$this->pushData = $pushData;
41	2566	$this->pushDataSize = $pushDataSize;
42	2566	}
43
44		/**
45		* @return bool
46		*/
47	2528	public function isPush()
48		{
49	2528	return $this->push;
50		}
51
52		/**
53		* @return int
54		*/
55	2546	public function getOp()
56		{
57	2546	return $this->opCode;
58		}
59
60		/**
61		* @return BufferInterface
62		*/
63	2532	public function getData()
64		{
65	2532	return $this->pushData;
66		}
67
68		/**
69		* @return int
70		*/
71	1900	public function getDataSize()
72		{
73	1900	if (!$this->push) {
74		throw new \RuntimeException("Op wasn't a push operation");
75		}
76
77	1900	return $this->pushDataSize;
78		}
79
80		/**
81		* @return BufferInterface\|int
82		*/
83		public function encode()
84		{
85		if ($this->push) {
86		return $this->pushData;
87		} else {
88		return $this->opCode;
89		}
90		}
91		}
92

Bit-Wasp / bitcoin-php

Pull Request — master (#523)

Operation::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like