Issues in WitnessTransactionSerializer.php - New Issues - Inspection of "Segwit h2" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#240)

by thomas

created 2016-02-03 14:17 UTC

Transaction/WitnessTransactionSerializer.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace BitWasp\Bitcoin\Serializer\Transaction;

use BitWasp\Bitcoin\Bitcoin;
use BitWasp\Bitcoin\Collection\Transaction\TransactionInputCollection;
use BitWasp\Bitcoin\Collection\Transaction\TransactionOutputCollection;
use BitWasp\Bitcoin\Collection\Transaction\TransactionWitnessCollection;
use BitWasp\Bitcoin\Script\ScriptWitnessInterface;
use BitWasp\Buffertools\Buffer;
use BitWasp\Buffertools\BufferInterface;
use BitWasp\Buffertools\ByteOrder;
use BitWasp\Buffertools\Parser;
use BitWasp\Bitcoin\Transaction\Transaction;
use BitWasp\Bitcoin\Transaction\TransactionInterface;
use BitWasp\Buffertools\TemplateFactory;
use BitWasp\Buffertools\Types\Int32;
use BitWasp\Buffertools\Types\Uint32;
use BitWasp\Buffertools\Types\Uint8;
use BitWasp\Buffertools\Types\VarInt;
use BitWasp\Buffertools\Types\VarString;
use BitWasp\Buffertools\Types\Vector;

class WitnessTransactionSerializer
{
    /**
     * @var TransactionInputSerializer
     */
    public $inputSerializer;

    /**
     * @var TransactionOutputSerializer
     */
    public $outputSerializer;

    /**
     *
     */
    public function __construct()
    {
        $this->inputSerializer = new TransactionInputSerializer(new OutPointSerializer());
        $this->outputSerializer = new TransactionOutputSerializer;
        $this->witnessSerializer = new ScriptWitnessSerializer();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @return \BitWasp\Buffertools\Template
     */
    private function getTemplate()
    {
        return (new TemplateFactory())
            ->int32le()
            ->int8()
            ->int8()
            ->vector(function (Parser & $parser) {
                return $this->inputSerializer->fromParser($parser);
            })
            ->vector(function (Parser &$parser) {
                return $this->outputSerializer->fromParser($parser);
            })
            ->vector(function (Parser $parser) {
                return $this->witnessSerializer->fromParser($parser);
            })
            ->uint32le()
            ->getTemplate();
    }

    public function s(TransactionInterface $transaction)
    {
        return $this->getTemplate()->write([
            $transaction->getVersion(),
            0,
            1,
            $transaction->getInputs()->all(),
            $transaction->getOutputs()->all(),
            $transaction->getWitnesses()->all(),
            $transaction->getLockTime()
        ]);
    }

    /**
     * @param TransactionInterface $transaction
     * @return BufferInterface
     */
    public function serialize(TransactionInterface $transaction)
    {
        $math = Bitcoin::getMath();
        $int32le = new Int32($math, ByteOrder::LE);
        $uint32le = new Uint32($math, ByteOrder::LE);

        $varint = new VarInt($math, ByteOrder::LE);
        $inputsSerializer = new Vector($varint, function (Parser $parser) {
            return $this->inputSerializer->fromParser($parser);
        });
        $flagsSerializer = new Uint8($math, ByteOrder::BE);
        $outputsSerializer = new Vector($varint, function (Parser $parser) {
            return $this->outputSerializer->fromParser($parser);
        });
        $witnessSerializer = new Vector($varint, function (Parser $parser) {
            return $this->witnessSerializer->fromParser($parser);
        });

        $binary = $int32le->write($transaction->getVersion());
        $flags = 0;
        if (!$transaction->getWitnesses()->isNull()) {
            $flags |= 1;
        }

        if ($flags) {
            // Dummy
            $binary .= $flagsSerializer->write(0);
            $binary .= $flagsSerializer->write($flags);
        }

        $binary .= $inputsSerializer->write($transaction->getInputs()->all());
        $binary .= $outputsSerializer->write($transaction->getOutputs()->all());

        if ($flags & 1) {
            $w = array_map(function (ScriptWitnessInterface $scriptWitness) {
                return $this->witnessSerializer->serialize($scriptWitness);
            }, $transaction->getWitnesses()->all());
            $binary .= $witnessSerializer->write($w);
        }

        $binary .= $uint32le->write($transaction->getLockTime());

        return new Buffer($binary, null, $math);
    }

    /**
     * @param Parser $parser
     * @return Transaction
     * @throws \BitWasp\Buffertools\Exceptions\ParserOutOfRange
     * @throws \Exception
     */
    public function fromParser(Parser $parser)
    {
        $math = Bitcoin::getMath();
        $int32le = new Int32($math, ByteOrder::LE);
        $uint32le = new Uint32($math, ByteOrder::LE);

        $varint = new VarInt($math, ByteOrder::LE);
        $inputsSerializer = new Vector($varint, function (Parser $parser) {
            return $this->inputSerializer->fromParser($parser);
        });
        $flagsSerializer = new Uint8($math, ByteOrder::BE);
        $outputsSerializer = new Vector($varint, function (Parser $parser) {
            return $this->outputSerializer->fromParser($parser);
        });

        $vcharSerializer = new VarString($varint);
        $witnessSerializer = new Vector($varint, function (Parser $parser) use ($vcharSerializer) {
            return $vcharSerializer->read($parser);
        });

        $version = $int32le->read($parser);
        $dummy = (int) $flagsSerializer->read($parser);
        if ($dummy !== 0) {
            throw new \RuntimeException('Non-zero dummy in witness-bearing transaction');
        }

        $flags = (int) $flagsSerializer->read($parser);
        if ($math->cmp($flags, 0) != 0) {
            $vInputs = $inputsSerializer->read($parser);
            $vOutputs = $outputsSerializer->read($parser);
        } else {
            throw new \RuntimeException('Unknown flag');
        }

        $vWitness = [];
        if ($flags & 1) {
            $flags ^= 1;
            $vWitness = $witnessSerializer->read($parser);
        }

        if ($flags) {
            throw new \RuntimeException('Unknown optional data');
        }

        $locktime = $uint32le->read($parser);

        return new Transaction(
            $version,
            new TransactionInputCollection($vInputs),
            new TransactionOutputCollection($vOutputs),
            new TransactionWitnessCollection($vWitness),
            $locktime
        );
    }

    /**
     * @param $hex
     * @return Transaction
     */
    public function parse($hex)
    {
        $parser = new Parser($hex);
        return $this->fromParser($parser);
    }
}


1			<?php
2
3			namespace BitWasp\Bitcoin\Serializer\Transaction;
4
5			use BitWasp\Bitcoin\Bitcoin;
6			use BitWasp\Bitcoin\Collection\Transaction\TransactionInputCollection;
7			use BitWasp\Bitcoin\Collection\Transaction\TransactionOutputCollection;
8			use BitWasp\Bitcoin\Collection\Transaction\TransactionWitnessCollection;
9			use BitWasp\Bitcoin\Script\ScriptWitnessInterface;
10			use BitWasp\Buffertools\Buffer;
11			use BitWasp\Buffertools\BufferInterface;
12			use BitWasp\Buffertools\ByteOrder;
13			use BitWasp\Buffertools\Parser;
14			use BitWasp\Bitcoin\Transaction\Transaction;
15			use BitWasp\Bitcoin\Transaction\TransactionInterface;
16			use BitWasp\Buffertools\TemplateFactory;
17			use BitWasp\Buffertools\Types\Int32;
18			use BitWasp\Buffertools\Types\Uint32;
19			use BitWasp\Buffertools\Types\Uint8;
20			use BitWasp\Buffertools\Types\VarInt;
21			use BitWasp\Buffertools\Types\VarString;
22			use BitWasp\Buffertools\Types\Vector;
23
24			class WitnessTransactionSerializer
25			{
26			/**
27			* @var TransactionInputSerializer
28			*/
29			public $inputSerializer;
30
31			/**
32			* @var TransactionOutputSerializer
33			*/
34			public $outputSerializer;
35
36			/**
37			*
38			*/
39			public function __construct()
40			{
41			$this->inputSerializer = new TransactionInputSerializer(new OutPointSerializer());
42			$this->outputSerializer = new TransactionOutputSerializer;
43			$this->witnessSerializer = new ScriptWitnessSerializer();
			0 ignored issues – show Bug introduced 2016-02-03 15:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `witnessSerializer` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			}
45
46			/**
47			* @return \BitWasp\Buffertools\Template
48			*/
49			private function getTemplate()
50			{
51			return (new TemplateFactory())
52			->int32le()
53			->int8()
54			->int8()
55			->vector(function (Parser & $parser) {
56			return $this->inputSerializer->fromParser($parser);
57			})
58			->vector(function (Parser &$parser) {
59			return $this->outputSerializer->fromParser($parser);
60			})
61			->vector(function (Parser $parser) {
62			return $this->witnessSerializer->fromParser($parser);
63			})
64			->uint32le()
65			->getTemplate();
66			}
67
68			public function s(TransactionInterface $transaction)
69			{
70			return $this->getTemplate()->write([
71			$transaction->getVersion(),
72			0,
73			1,
74			$transaction->getInputs()->all(),
75			$transaction->getOutputs()->all(),
76			$transaction->getWitnesses()->all(),
77			$transaction->getLockTime()
78			]);
79			}
80
81			/**
82			* @param TransactionInterface $transaction
83			* @return BufferInterface
84			*/
85			public function serialize(TransactionInterface $transaction)
86			{
87			$math = Bitcoin::getMath();
88			$int32le = new Int32($math, ByteOrder::LE);
89			$uint32le = new Uint32($math, ByteOrder::LE);
90
91			$varint = new VarInt($math, ByteOrder::LE);
92			$inputsSerializer = new Vector($varint, function (Parser $parser) {
93			return $this->inputSerializer->fromParser($parser);
94			});
95			$flagsSerializer = new Uint8($math, ByteOrder::BE);
96			$outputsSerializer = new Vector($varint, function (Parser $parser) {
97			return $this->outputSerializer->fromParser($parser);
98			});
99			$witnessSerializer = new Vector($varint, function (Parser $parser) {
100			return $this->witnessSerializer->fromParser($parser);
101			});
102
103			$binary = $int32le->write($transaction->getVersion());
104			$flags = 0;
105			if (!$transaction->getWitnesses()->isNull()) {
106			$flags \|= 1;
107			}
108
109			if ($flags) {
110			// Dummy
111			$binary .= $flagsSerializer->write(0);
112			$binary .= $flagsSerializer->write($flags);
113			}
114
115			$binary .= $inputsSerializer->write($transaction->getInputs()->all());
116			$binary .= $outputsSerializer->write($transaction->getOutputs()->all());
117
118			if ($flags & 1) {
119			$w = array_map(function (ScriptWitnessInterface $scriptWitness) {
120			return $this->witnessSerializer->serialize($scriptWitness);
121			}, $transaction->getWitnesses()->all());
122			$binary .= $witnessSerializer->write($w);
123			}
124
125			$binary .= $uint32le->write($transaction->getLockTime());
126
127			return new Buffer($binary, null, $math);
128			}
129
130			/**
131			* @param Parser $parser
132			* @return Transaction
133			* @throws \BitWasp\Buffertools\Exceptions\ParserOutOfRange
134			* @throws \Exception
135			*/
136			public function fromParser(Parser $parser)
137			{
138			$math = Bitcoin::getMath();
139			$int32le = new Int32($math, ByteOrder::LE);
140			$uint32le = new Uint32($math, ByteOrder::LE);
141
142			$varint = new VarInt($math, ByteOrder::LE);
143			$inputsSerializer = new Vector($varint, function (Parser $parser) {
144			return $this->inputSerializer->fromParser($parser);
145			});
146			$flagsSerializer = new Uint8($math, ByteOrder::BE);
147			$outputsSerializer = new Vector($varint, function (Parser $parser) {
148			return $this->outputSerializer->fromParser($parser);
149			});
150
151			$vcharSerializer = new VarString($varint);
152			$witnessSerializer = new Vector($varint, function (Parser $parser) use ($vcharSerializer) {
153			return $vcharSerializer->read($parser);
154			});
155
156			$version = $int32le->read($parser);
157			$dummy = (int) $flagsSerializer->read($parser);
158			if ($dummy !== 0) {
159			throw new \RuntimeException('Non-zero dummy in witness-bearing transaction');
160			}
161
162			$flags = (int) $flagsSerializer->read($parser);
163			if ($math->cmp($flags, 0) != 0) {
164			$vInputs = $inputsSerializer->read($parser);
165			$vOutputs = $outputsSerializer->read($parser);
166			} else {
167			throw new \RuntimeException('Unknown flag');
168			}
169
170			$vWitness = [];
171			if ($flags & 1) {
172			$flags ^= 1;
173			$vWitness = $witnessSerializer->read($parser);
174			}
175
176			if ($flags) {
177			throw new \RuntimeException('Unknown optional data');
178			}
179
180			$locktime = $uint32le->read($parser);
181
182			return new Transaction(
183			$version,
184			new TransactionInputCollection($vInputs),
185			new TransactionOutputCollection($vOutputs),
186			new TransactionWitnessCollection($vWitness),
187			$locktime
188			);
189			}
190
191			/**
192			* @param $hex
193			* @return Transaction
194			*/
195			public function parse($hex)
196			{
197			$parser = new Parser($hex);
198			return $this->fromParser($parser);
199			}
200			}
201

Bit-Wasp / bitcoin-php

Pull Request — master (#240)

Transaction/WitnessTransactionSerializer.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like