PayToPubkey::__construct() - Code Metrics - Inspection of "Refactor output classifier" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#286)

by thomas

created 2016-03-26 17:11 UTC

PayToPubkey::__construct() A

↳ Parent: PayToPubkey

Complexity

Conditions	4
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	4.074

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	5
cts	6
cp	0.8333
rs	9.2
cc	4
eloc	5
nc	2
nop	1
crap	4.074

<?php

namespace BitWasp\Bitcoin\Script\ScriptInfo;

use BitWasp\Bitcoin\Key\PublicKeyFactory;
use BitWasp\Bitcoin\Script\Opcodes;
use BitWasp\Bitcoin\Script\ScriptInterface;
use BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface;

class PayToPubkey implements ScriptInfoInterface
{
    /**
     * @var PublicKeyInterface
     */
    private $publicKey;

    /**
     * @param ScriptInterface $script
     */
    public function __construct(ScriptInterface $script)
    {
        $chunks = $script->getScriptParser()->decode();
        if (count($chunks) !== 2 || !$chunks[0]->isPush() || $chunks[1]->getOp() !== Opcodes::OP_CHECKSIG) {
            throw new \InvalidArgumentException('Malformed pay-to-pubkey script');
        }
        $this->publicKey = PublicKeyFactory::fromHex($chunks[0]->getData());
    }

    /**
     * @return int
     */
    public function getRequiredSigCount()
    {
        return 1;
    }

    /**
     * @return int
     */
    public function getKeyCount()
    {
        return 1;
    }

    /**
     * @param PublicKeyInterface $publicKey
     * @return bool
     */
    public function checkInvolvesKey(PublicKeyInterface $publicKey)
    {
        return $publicKey->getBinary() === $this->publicKey->getBinary();
    }

    /**
     * @return PublicKeyInterface[]
     */
    public function getKeys()
    {
        return [$this->publicKey];
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Script\ScriptInfo;
4
5		use BitWasp\Bitcoin\Key\PublicKeyFactory;
6		use BitWasp\Bitcoin\Script\Opcodes;
7		use BitWasp\Bitcoin\Script\ScriptInterface;
8		use BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface;
9
10		class PayToPubkey implements ScriptInfoInterface
11		{
12		/**
13		* @var PublicKeyInterface
14		*/
15		private $publicKey;
16
17		/**
18		* @param ScriptInterface $script
19		*/
20	6	public function __construct(ScriptInterface $script)
21		{
22	6	$chunks = $script->getScriptParser()->decode();
23	6	if (count($chunks) !== 2 \|\| !$chunks[0]->isPush() \|\| $chunks[1]->getOp() !== Opcodes::OP_CHECKSIG) {
24		throw new \InvalidArgumentException('Malformed pay-to-pubkey script');
25		}
26	6	$this->publicKey = PublicKeyFactory::fromHex($chunks[0]->getData());
27	6	}
28
29		/**
30		* @return int
31		*/
32	6	public function getRequiredSigCount()
33		{
34	6	return 1;
35		}
36
37		/**
38		* @return int
39		*/
40	6	public function getKeyCount()
41		{
42	6	return 1;
43		}
44
45		/**
46		* @param PublicKeyInterface $publicKey
47		* @return bool
48		*/
49	6	public function checkInvolvesKey(PublicKeyInterface $publicKey)
50		{
51	6	return $publicKey->getBinary() === $this->publicKey->getBinary();
52		}
53
54		/**
55		* @return PublicKeyInterface[]
56		*/
57	6	public function getKeys()
58		{
59	6	return [$this->publicKey];
60		}
61		}
62

Bit-Wasp / bitcoin-php

Pull Request — master (#286)

PayToPubkey::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like