BitWasp\Bitcoin\Serializer\Script\ScriptWitnessSerializer

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

60%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	fromParser()	0	10	2
A	serialize()	0	10	2

<?php

namespace BitWasp\Bitcoin\Serializer\Script;

use BitWasp\Bitcoin\Script\ScriptWitness;
use BitWasp\Bitcoin\Script\ScriptWitnessInterface;
use BitWasp\Bitcoin\Serializer\Types;
use BitWasp\Buffertools\Buffer;
use BitWasp\Buffertools\BufferInterface;
use BitWasp\Buffertools\Buffertools;
use BitWasp\Buffertools\Parser;
use BitWasp\Buffertools\Template;

class ScriptWitnessSerializer
{
    /**
     * @var Template
     */
    private $varstring;

    public function __construct()
    {
        $this->varstring = Types::varstring();

It seems like \BitWasp\Bitcoin\Serializer\Types::varstring() of type object<BitWasp\Buffertools\Types\VarString> is incompatible with the declared type object<BitWasp\Buffertools\Template> of property $varstring.

    }

    /**
     * @param Parser $parser
     * @param $size
     * @return ScriptWitness
     */
    public function fromParser(Parser $parser, $size)
    {
        $entries = [];
        for ($j = 0; $j < $size; $j++) {
            $data = $this->varstring->parse($parser);
            $entries[] = $data;
        }

        return new ScriptWitness($entries);
    }

    /**
     * @param ScriptWitnessInterface $witness
     * @return BufferInterface
     */
    public function serialize(ScriptWitnessInterface $witness)
    {
        $parser = new Parser();
        $parser->appendBuffer(Buffertools::numToVarInt($witness->count()));

The method appendBuffer() does not seem to exist on object<BitWasp\Buffertools\Parser>.

        foreach ($witness as $value) {
            $parser->appendBuffer(new Buffer($this->varstring->write($value)));

$this->varstring->write($value) is of type object<BitWasp\Buffertools\Buffer>, but the function expects a string.

The method appendBuffer() does not seem to exist on object<BitWasp\Buffertools\Parser>.

        }

        return $parser->getBuffer();
    }
}