Complex classes like Script often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Script, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | class Script extends Serializable implements ScriptInterface |
||
| 15 | { |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @var Opcodes |
||
| 19 | */ |
||
| 20 | protected $opCodes; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @var string |
||
| 24 | */ |
||
| 25 | protected $script; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * @param BufferInterface $script |
||
| 29 | * @param Opcodes|null $opCodes |
||
| 30 | */ |
||
| 31 | 1590 | public function __construct(BufferInterface $script = null, Opcodes $opCodes = null) |
|
| 36 | |||
| 37 | /** |
||
| 38 | * @return BufferInterface |
||
| 39 | */ |
||
| 40 | 1602 | public function getBuffer() |
|
| 44 | |||
| 45 | /** |
||
| 46 | * @return Parser |
||
| 47 | */ |
||
| 48 | 1446 | public function getScriptParser() |
|
| 52 | |||
| 53 | /** |
||
| 54 | * Get all opcodes |
||
| 55 | * |
||
| 56 | * @return Opcodes |
||
| 57 | */ |
||
| 58 | 6 | public function getOpCodes() |
|
| 62 | |||
| 63 | /** |
||
| 64 | * Return a buffer containing the hash of this script. |
||
| 65 | * |
||
| 66 | * @return BufferInterface |
||
| 67 | */ |
||
| 68 | 18 | public function getScriptHash() |
|
| 72 | |||
| 73 | /** |
||
| 74 | * @return BufferInterface |
||
| 75 | */ |
||
| 76 | 75 | public function getWitnessScriptHash() |
|
| 80 | |||
| 81 | /** |
||
| 82 | * @param bool|true $accurate |
||
| 83 | * @return int |
||
| 84 | */ |
||
| 85 | 18 | public function countSigOps($accurate = true) |
|
| 86 | { |
||
| 87 | 18 | $count = 0; |
|
| 88 | 18 | $parser = $this->getScriptParser(); |
|
| 89 | |||
| 90 | 18 | $lastOp = 0xff; |
|
| 91 | try { |
||
| 92 | 18 | foreach ($parser as $exec) { |
|
| 93 | 12 | $op = $exec->getOp(); |
|
| 94 | |||
| 95 | // None of these are pushdatas, so just an opcode |
||
| 96 | 12 | if ($op === Opcodes::OP_CHECKSIG || $op === Opcodes::OP_CHECKSIGVERIFY) { |
|
| 97 | 6 | $count++; |
|
| 98 | 12 | } elseif ($op === Opcodes::OP_CHECKMULTISIG || $op === Opcodes::OP_CHECKMULTISIGVERIFY) { |
|
| 99 | 10 | if ($accurate && ($lastOp >= Opcodes::OP_1 && $lastOp <= Opcodes::OP_16)) { |
|
| 100 | 8 | $count += decodeOpN($lastOp); |
|
| 101 | } else { |
||
| 102 | 4 | $count += 20; |
|
| 103 | } |
||
| 104 | } |
||
| 105 | |||
| 106 | 16 | $lastOp = $op; |
|
| 107 | } |
||
| 108 | 2 | } catch (\Exception $e) { |
|
| 109 | /* Script parsing failures don't count, and terminate the loop */ |
||
| 110 | } |
||
| 111 | |||
| 112 | 18 | return $count; |
|
| 113 | } |
||
| 114 | |||
| 115 | /** |
||
| 116 | * @param WitnessProgram $program |
||
| 117 | * @param ScriptWitnessInterface $scriptWitness |
||
| 118 | * @return int |
||
| 119 | */ |
||
| 120 | 2 | private function witnessSigOps(WitnessProgram $program, ScriptWitnessInterface $scriptWitness) |
|
| 121 | { |
||
| 122 | 2 | if ($program->getVersion() === 0) { |
|
| 123 | 2 | $size = $program->getProgram()->getSize(); |
|
| 124 | 2 | if ($size === 32 && count($scriptWitness) > 0) { |
|
| 125 | 2 | $script = new Script($scriptWitness->bottom()); |
|
| 126 | 2 | return $script->countSigOps(true); |
|
| 127 | } |
||
| 128 | |||
| 129 | if ($size === 20) { |
||
| 130 | return 1; |
||
| 131 | } |
||
| 132 | } |
||
| 133 | |||
| 134 | return 0; |
||
| 135 | } |
||
| 136 | |||
| 137 | /** |
||
| 138 | * @param ScriptInterface $scriptSig |
||
| 139 | * @param ScriptWitnessInterface $scriptWitness |
||
| 140 | * @param int $flags |
||
| 141 | * @return int |
||
| 142 | */ |
||
| 143 | 2 | public function countWitnessSigOps(ScriptInterface $scriptSig, ScriptWitnessInterface $scriptWitness, $flags) |
|
| 144 | { |
||
| 145 | 2 | if ($flags & InterpreterInterface::VERIFY_WITNESS === 0) { |
|
| 146 | return 0; |
||
| 147 | } |
||
| 148 | |||
| 149 | 2 | $program = null; |
|
| 150 | 2 | if ($this->isWitness($program)) { |
|
| 151 | /** @var WitnessProgram $program */ |
||
| 152 | 2 | return $this->witnessSigOps($program, $scriptWitness); |
|
| 153 | } |
||
| 154 | |||
| 155 | if ((new OutputClassifier())->isPayToScriptHash($this)) { |
||
| 156 | $parsed = $scriptSig->getScriptParser()->decode(); |
||
| 157 | $subscript = new Script(end($parsed)->getData()); |
||
| 158 | if ($subscript->isWitness($program)) { |
||
| 159 | /** @var WitnessProgram $program */ |
||
| 160 | return $this->witnessSigOps($program, $scriptWitness); |
||
| 161 | } |
||
| 162 | } |
||
| 163 | |||
| 164 | return 0; |
||
| 165 | } |
||
| 166 | |||
| 167 | /** |
||
| 168 | * @param ScriptInterface $scriptSig |
||
| 169 | * @return int |
||
| 170 | */ |
||
| 171 | 8 | public function countP2shSigOps(ScriptInterface $scriptSig) |
|
| 172 | { |
||
| 173 | 8 | if (!(new OutputClassifier())->isPayToScriptHash($this)) { |
|
| 174 | 4 | return $this->countSigOps(true); |
|
| 175 | } |
||
| 176 | |||
| 177 | try { |
||
| 178 | 8 | $data = null; |
|
| 179 | 8 | foreach ($scriptSig->getScriptParser() as $exec) { |
|
| 180 | 8 | if ($exec->getOp() > Opcodes::OP_16) { |
|
| 181 | 2 | return 0; |
|
| 182 | } |
||
| 183 | |||
| 184 | 6 | if ($exec->isPush()) { |
|
| 185 | 6 | $data = $exec->getData(); |
|
| 186 | } |
||
| 187 | } |
||
| 188 | |||
| 189 | 8 | if (!$data instanceof BufferInterface) { |
|
| 190 | 2 | return 0; |
|
| 191 | } |
||
| 192 | |||
| 193 | 6 | return (new Script($data))->countSigOps(true); |
|
| 194 | } catch (\Exception $e) { |
||
| 195 | return 0; |
||
| 196 | } |
||
| 197 | } |
||
| 198 | |||
| 199 | /** |
||
| 200 | * @return bool |
||
| 201 | */ |
||
| 202 | 106 | public function isPushOnly() |
|
| 203 | { |
||
| 204 | 106 | foreach ($this->getScriptParser()->decode() as $entity) { |
|
| 205 | 106 | if ($entity->getOp() > Opcodes::OP_16) { |
|
| 206 | 106 | return false; |
|
| 207 | } |
||
| 208 | } |
||
| 209 | |||
| 210 | 97 | return true; |
|
| 211 | } |
||
| 212 | |||
| 213 | /** |
||
| 214 | * @param WitnessProgram|null $program |
||
| 215 | * @return bool |
||
| 216 | */ |
||
| 217 | 123 | public function isWitness(& $program = null) |
|
| 243 | |||
| 244 | /** |
||
| 245 | * @param ScriptInterface $script |
||
| 246 | * @return bool |
||
| 247 | */ |
||
| 248 | 149 | public function equals(ScriptInterface $script) |
|
| 252 | |||
| 253 | /** |
||
| 254 | * @return string |
||
| 255 | */ |
||
| 256 | 2 | public function __debugInfo() |
|
| 257 | { |
||
| 268 | } |
||
| 269 |