P2pkhScriptDataFactory::convertKeyToScriptData() - Code Metrics - Inspection of "KeyToScriptHelper: return types and cleanup" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 460d12...eabe8c )

by thomas

created 2018-11-29 23:31 UTC

P2pkhScriptDataFactory::convertKeyToScriptData() A

↳ Parent: P2pkhScriptDataFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0185

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	10
ccs	5
cts	6
cp	0.8333
crap	2.0185
rs	9.9332
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace BitWasp\Bitcoin\Key\KeyToScript\Factory;

use BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface;
use BitWasp\Bitcoin\Key\KeyToScript\ScriptAndSignData;
use BitWasp\Bitcoin\Script\ScriptFactory;
use BitWasp\Bitcoin\Script\ScriptType;
use BitWasp\Bitcoin\Transaction\Factory\SignData;

class P2pkhScriptDataFactory extends KeyToScriptDataFactory
{
    /**
     * @return string
     */
    public function getScriptType(): string
    {
        return ScriptType::P2PKH;
    }

    /**
     * @param PublicKeyInterface ...$keys
     * @return ScriptAndSignData
     */
    protected function convertKeyToScriptData(PublicKeyInterface ...$keys): ScriptAndSignData
    {
        if (count($keys) !== 1) {
            throw new \InvalidArgumentException("Invalid number of keys");
        }
        return new ScriptAndSignData(
            ScriptFactory::scriptPubKey()->p2pkh($keys[0]->getPubKeyHash($this->pubKeySerializer)),
            new SignData()
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace BitWasp\Bitcoin\Key\KeyToScript\Factory;
6
7		use BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface;
8		use BitWasp\Bitcoin\Key\KeyToScript\ScriptAndSignData;
9		use BitWasp\Bitcoin\Script\ScriptFactory;
10		use BitWasp\Bitcoin\Script\ScriptType;
11		use BitWasp\Bitcoin\Transaction\Factory\SignData;
12
13		class P2pkhScriptDataFactory extends KeyToScriptDataFactory
14		{
15		/**
16		* @return string
17		*/
18	32	public function getScriptType(): string
19		{
20	32	return ScriptType::P2PKH;
21		}
22
23		/**
24		* @param PublicKeyInterface ...$keys
25		* @return ScriptAndSignData
26		*/
27	16	protected function convertKeyToScriptData(PublicKeyInterface ...$keys): ScriptAndSignData
28		{
29	16	if (count($keys) !== 1) {
30		throw new \InvalidArgumentException("Invalid number of keys");
31		}
32	16	return new ScriptAndSignData(
33	16	ScriptFactory::scriptPubKey()->p2pkh($keys[0]->getPubKeyHash($this->pubKeySerializer)),
34	16	new SignData()
35		);
36		}
37		}
38

Bit-Wasp / bitcoin-php

Push — master ( 460d12...eabe8c )

P2pkhScriptDataFactory::convertKeyToScriptData() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like