ScriptWitness::equals() - Code Metrics - Inspection of "Add methods to assist with equality checks" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#278)

by thomas

created 2016-03-18 02:47 UTC

ScriptWitness::equals() A

↳ Parent: ScriptWitness

Complexity

Conditions	4
Paths	4

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	15
ccs	1
cts	1
cp	1
rs	9.2
cc	4
eloc	8
nc	4
nop	1
crap	4

<?php

namespace BitWasp\Bitcoin\Script;

use BitWasp\Bitcoin\Collection\StaticCollection;
use BitWasp\Bitcoin\Serializer\Script\ScriptWitnessSerializer;
use BitWasp\Buffertools\BufferInterface;

class ScriptWitness extends StaticCollection implements ScriptWitnessInterface
{
    /**
     * ScriptWitness constructor.
     * @param BufferInterface[] $sigValues
     */
    public function __construct(array $sigValues)
    {
        $this->set = new \SplFixedArray(count($sigValues));
        foreach ($sigValues as $idx => $push) {
            if (!$push instanceof BufferInterface) {
                throw new \InvalidArgumentException('Must provide BufferInterface[] to ScriptWitness');
            }
            $this->set->offsetSet($idx, $push);
        }
    }

    public function __clone()
    {
        $outputs = $this->set;
        $this->set = new \SplFixedArray(count($outputs));

        foreach ($outputs as $idx => $output) {
            $this->set->offsetSet($idx, $output);
        }
    }

    /**
     * @return BufferInterface
     */
    public function bottom()
    {
        return parent::offsetGet(count($this) - 1);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @return BufferInterface
     */
    public function current()
    {
        return $this->set->current();
    }

    /**
     * @param int $offset
     * @return BufferInterface
     */
    public function offsetGet($offset)
    {
        if (!$this->set->offsetExists($offset)) {
            throw new \OutOfRangeException('No offset found');
        }

        return $this->set->offsetGet($offset);
    }

    /**
     * @param int $start
     * @param int $length
     * @return ScriptWitness
     */
    public function slice($start, $length)
    {
        $end = $this->set->getSize();
        if ($start > $end || $length > $end) {
            throw new \RuntimeException('Invalid start or length');
        }

        $sliced = array_slice($this->set->toArray(), $start, $length);
        return new self($sliced);
    }

    /**
     * @param ScriptWitnessInterface $witness
     * @return bool
     */
    public function equals(ScriptWitnessInterface $witness)
    {
        $nStack = count($this);
        if ($nStack !== count($witness)) {
            return false;
        }

        for ($i = 0; $i < $nStack; $i++) {
            if (false === $this->offsetGet($i)->equals($witness->offsetGet($i))) {
                return false;
            }
        }

        return true;
    }

    /**
     * @return \BitWasp\Buffertools\BufferInterface
     */
    public function getBuffer()
    {
        return (new ScriptWitnessSerializer())->serialize($this);
    }
}


1		<?php
2
3		namespace BitWasp\Bitcoin\Script;
4
5		use BitWasp\Bitcoin\Collection\StaticCollection;
6		use BitWasp\Bitcoin\Serializer\Script\ScriptWitnessSerializer;
7		use BitWasp\Buffertools\BufferInterface;
8
9		class ScriptWitness extends StaticCollection implements ScriptWitnessInterface
10		{
11		/**
12		* ScriptWitness constructor.
13		* @param BufferInterface[] $sigValues
14		*/
15	90	public function __construct(array $sigValues)
16		{
17	90	$this->set = new \SplFixedArray(count($sigValues));
18	90	foreach ($sigValues as $idx => $push) {
19	30	if (!$push instanceof BufferInterface) {
20		throw new \InvalidArgumentException('Must provide BufferInterface[] to ScriptWitness');
21		}
22	30	$this->set->offsetSet($idx, $push);
23	90	}
24	90	}
25
26		public function __clone()
27		{
28		$outputs = $this->set;
29		$this->set = new \SplFixedArray(count($outputs));
30
31		foreach ($outputs as $idx => $output) {
32		$this->set->offsetSet($idx, $output);
33		}
34		}
35
36		/**
37		* @return BufferInterface
38		*/
39		public function bottom()
40		{
41		return parent::offsetGet(count($this) - 1);
		0 ignored issues – show Comprehensibility Bug introduced 2016-02-03 03:56 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`offsetGet()` instead of `bottom()`). Are you sure this is correct? If so, you might want to change this to `$this->offsetGet()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
42		}
43
44		/**
45		* @return BufferInterface
46		*/
47	30	public function current()
48		{
49	30	return $this->set->current();
50		}
51
52		/**
53		* @param int $offset
54		* @return BufferInterface
55		*/
56	30	public function offsetGet($offset)
57		{
58	30	if (!$this->set->offsetExists($offset)) {
59		throw new \OutOfRangeException('No offset found');
60		}
61
62	30	return $this->set->offsetGet($offset);
63		}
64
65		/**
66		* @param int $start
67		* @param int $length
68		* @return ScriptWitness
69		*/
70	18	public function slice($start, $length)
71		{
72	18	$end = $this->set->getSize();
73	18	if ($start > $end \|\| $length > $end) {
74		throw new \RuntimeException('Invalid start or length');
75		}
76
77	18	$sliced = array_slice($this->set->toArray(), $start, $length);
78	18	return new self($sliced);
79		}
80
81		/**
82		* @param ScriptWitnessInterface $witness
83		* @return bool
84	54	*/
85		public function equals(ScriptWitnessInterface $witness)
86	54	{
87		$nStack = count($this);
88		if ($nStack !== count($witness)) {
89		return false;
90		}
91
92		for ($i = 0; $i < $nStack; $i++) {
93		if (false === $this->offsetGet($i)->equals($witness->offsetGet($i))) {
94		return false;
95		}
96		}
97
98		return true;
99		}
100
101		/**
102		* @return \BitWasp\Buffertools\BufferInterface
103		*/
104		public function getBuffer()
105		{
106		return (new ScriptWitnessSerializer())->serialize($this);
107		}
108		}
109

Bit-Wasp / bitcoin-php

Pull Request — master (#278)

ScriptWitness::equals() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like