UpdatableInput::addNonWitnessTx() - Code Metrics - Inspection of "[WIP] PSBT format" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#759)

by thomas

created 2018-12-16 21:25 UTC

UpdatableInput::addNonWitnessTx() A

↳ Parent: UpdatableInput

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	1
dl	0
loc	10
ccs	7
cts	7
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace BitWasp\Bitcoin\Transaction\PSBT;

use BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface;
use BitWasp\Bitcoin\Script\ScriptInterface;
use BitWasp\Bitcoin\Transaction\TransactionInterface;
use BitWasp\Bitcoin\Transaction\TransactionOutputInterface;

class UpdatableInput
{
    private $psbt;
    private $nIn;
    private $input;

    public function __construct(
        PSBT $psbt,
        int $nIn,
        PSBTInput $input
    ) {
        $this->psbt = $psbt;
        $this->nIn = $nIn;
        $this->input = $input;
    }

    public function input(): PSBTInput
    {
        return $this->input;
    }

    public function addNonWitnessTx(TransactionInterface $tx)
    {
        $outPoint = $this->psbt->getTransaction()->getInputs()[$this->nIn]->getOutPoint();
        if (!$outPoint->getTxId()->equals($tx->getTxId())) {
            throw new \RuntimeException("Non-witness txid differs from unsigned tx input {$this->nIn}");
        }
        if ($outPoint->getVout() > count($tx->getOutputs()) - 1) {
            throw new \RuntimeException("unsigned tx outpoint does not exist in this transaction");
        }
        $this->input = $this->input->withNonWitnessTx($tx);
    }

    public function addWitnessTxOut(TransactionOutputInterface $txOut)
    {
        $this->input = $this->input->withWitnessTxOut($txOut);
    }

    public function addRedeemScript(ScriptInterface $script)
    {
        $this->input = $this->input->withRedeemScript($script);
    }

    public function addWitnessScript(ScriptInterface $script)
    {
        $this->input = $this->input->withWitnessScript($script);
    }

    public function addDerivation(PublicKeyInterface $key, PSBTBip32Derivation $derivation)
    {
        $this->input = $this->input->withDerivation($key, $derivation);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace BitWasp\Bitcoin\Transaction\PSBT;
6
7		use BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface;
8		use BitWasp\Bitcoin\Script\ScriptInterface;
9		use BitWasp\Bitcoin\Transaction\TransactionInterface;
10		use BitWasp\Bitcoin\Transaction\TransactionOutputInterface;
11
12		class UpdatableInput
13		{
14		private $psbt;
15		private $nIn;
16		private $input;
17
18	10	public function __construct(
19		PSBT $psbt,
20		int $nIn,
21		PSBTInput $input
22		) {
23	10	$this->psbt = $psbt;
24	10	$this->nIn = $nIn;
25	10	$this->input = $input;
26	10	}
27
28	8	public function input(): PSBTInput
29		{
30	8	return $this->input;
31		}
32
33	4	public function addNonWitnessTx(TransactionInterface $tx)
34		{
35	4	$outPoint = $this->psbt->getTransaction()->getInputs()[$this->nIn]->getOutPoint();
36	4	if (!$outPoint->getTxId()->equals($tx->getTxId())) {
37	1	throw new \RuntimeException("Non-witness txid differs from unsigned tx input {$this->nIn}");
38		}
39	3	if ($outPoint->getVout() > count($tx->getOutputs()) - 1) {
40	1	throw new \RuntimeException("unsigned tx outpoint does not exist in this transaction");
41		}
42	2	$this->input = $this->input->withNonWitnessTx($tx);
43	2	}
44
45	3	public function addWitnessTxOut(TransactionOutputInterface $txOut)
46		{
47	3	$this->input = $this->input->withWitnessTxOut($txOut);
48	3	}
49
50	2	public function addRedeemScript(ScriptInterface $script)
51		{
52	2	$this->input = $this->input->withRedeemScript($script);
53	2	}
54
55	2	public function addWitnessScript(ScriptInterface $script)
56		{
57	2	$this->input = $this->input->withWitnessScript($script);
58	2	}
59
60	1	public function addDerivation(PublicKeyInterface $key, PSBTBip32Derivation $derivation)
61		{
62	1	$this->input = $this->input->withDerivation($key, $derivation);
63	1	}
64		}
65

Bit-Wasp / bitcoin-php

Pull Request — master (#759)

UpdatableInput::addNonWitnessTx() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like