P2wpkhScriptDataFactory::convertKeyToScriptData() - Code Metrics - Inspection of "V1Hasher: remove useless assignment" - Bit-Wasp/bitcoin-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 280df4...3ba82a )

by thomas

created 2018-12-07 23:50 UTC

P2wpkhScriptDataFactory::convertKeyToScriptData() A

↳ Parent: P2wpkhScriptDataFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3.1406

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	3
nop	1
dl	0
loc	11
ccs	6
cts	8
cp	0.75
crap	3.1406
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace BitWasp\Bitcoin\Key\KeyToScript\Factory;

use BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface;
use BitWasp\Bitcoin\Key\KeyToScript\ScriptAndSignData;
use BitWasp\Bitcoin\Script\ScriptFactory;
use BitWasp\Bitcoin\Script\ScriptType;
use BitWasp\Bitcoin\Transaction\Factory\SignData;

class P2wpkhScriptDataFactory extends KeyToScriptDataFactory
{
    /**
     * @return string
     */
    public function getScriptType(): string
    {
        return ScriptType::P2WKH;
    }

    /**
     * @param PublicKeyInterface ...$keys
     * @return ScriptAndSignData
     */
    protected function convertKeyToScriptData(PublicKeyInterface ...$keys): ScriptAndSignData
    {
        if (count($keys) !== 1) {
            throw new \InvalidArgumentException("Invalid number of keys");
        }
        if (!$keys[0]->isCompressed()) {
            throw new \InvalidArgumentException("Cannot create P2WPKH address for non-compressed public key");
        }
        return new ScriptAndSignData(
            ScriptFactory::scriptPubKey()->p2wkh($keys[0]->getPubKeyHash($this->pubKeySerializer)),
            new SignData()
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace BitWasp\Bitcoin\Key\KeyToScript\Factory;
6
7		use BitWasp\Bitcoin\Crypto\EcAdapter\Key\PublicKeyInterface;
8		use BitWasp\Bitcoin\Key\KeyToScript\ScriptAndSignData;
9		use BitWasp\Bitcoin\Script\ScriptFactory;
10		use BitWasp\Bitcoin\Script\ScriptType;
11		use BitWasp\Bitcoin\Transaction\Factory\SignData;
12
13		class P2wpkhScriptDataFactory extends KeyToScriptDataFactory
14		{
15		/**
16		* @return string
17		*/
18	22	public function getScriptType(): string
19		{
20	22	return ScriptType::P2WKH;
21		}
22
23		/**
24		* @param PublicKeyInterface ...$keys
25		* @return ScriptAndSignData
26		*/
27	12	protected function convertKeyToScriptData(PublicKeyInterface ...$keys): ScriptAndSignData
28		{
29	12	if (count($keys) !== 1) {
30		throw new \InvalidArgumentException("Invalid number of keys");
31		}
32	12	if (!$keys[0]->isCompressed()) {
33		throw new \InvalidArgumentException("Cannot create P2WPKH address for non-compressed public key");
34		}
35	12	return new ScriptAndSignData(
36	12	ScriptFactory::scriptPubKey()->p2wkh($keys[0]->getPubKeyHash($this->pubKeySerializer)),
37	12	new SignData()
38		);
39		}
40		}
41

Bit-Wasp / bitcoin-php

Push — master ( 280df4...3ba82a )

P2wpkhScriptDataFactory::convertKeyToScriptData() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like